Fix/moengage id reset handle (#635)

* fix: handled reset on user id change

* fix: removed unused codes

* bump minor v

Co-authored-by: Nawaz Uddin <nawazuddin@Nawazs-MacBook-Pro.local>

Author: Julio Farah

integrations/moengage/lib/index.js

@@ -104,12 +104,6 @@ MoEngage.prototype.loaded = function() {
 
 MoEngage.prototype.identify = function(identify) {
   var self = this;
-  // Important: MoEngage require you to manually call reset to wipe the unique id for the session
-  // if you don't do this and call add_unique_user_id w/ a different userId, it will overwrite the previous user's
-  // unique id and all their traits so we need to manually check if it's a new user since `analytics.reset()` is not
-  // mapped for ajs integrations
-  // analytics.js regenerates anonymousId if you call `.identify()` with a unique userId value different from the cache
-  if (this.initializedAnonymousId !== identify.anonymousId()) this.reset();
   if (identify.userId()) this._client.add_unique_user_id(identify.userId());
 
   // send common traits
@@ -160,22 +154,9 @@ MoEngage.prototype.identify = function(identify) {
  */
 
 MoEngage.prototype.track = function(track) {
-  // Important: MoEngage require you to manually call reset to wipe the unique id for the session
-  // if you don't do this and call add_unique_user_id w/ a different userId, it will overwrite the previous user's
-  // unique id and all their traits so we need to manually check if it's a new user since `analytics.reset()` is not
-  // mapped for ajs integrations
-  // analytics.js regenerates anonymousId if you call `.identify()` with a unique userId value different from the cache
-  if (this.initializedAnonymousId !== track.anonymousId()) this.reset();
   this._client.track_event(track.event(), track.properties());
 };
 
-/**
- * Reset
- *
- * @api public
- */
-
-MoEngage.prototype.reset = function() {
-  this.initializedAnonymousId = this.analytics.user().anonymousId();
-  this._client.destroy_session();
+MoEngage.prototype.alias = function(alias) {
+  if (alias.to()) this._client.update_unique_user_id(alias.to());
 };

integrations/moengage/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/analytics.js-integration-moengage",
   "description": "The MoEngage analytics.js integration.",
-  "version": "1.0.7",
+  "version": "1.0.8",
   "keywords": [
     "analytics.js",
     "analytics.js-integration",

integrations/moengage/test/index.test.js

@@ -150,13 +150,7 @@ describe('MoEngage', function() {
             'The anonymous ID should be different after an identify call'
           );
         }
-        analytics.called(moengage._client.destroy_session);
         analytics.called(moengage._client.add_unique_user_id, 'night king');
-        if (moengage.initializedAnonymousId !== nightKingAnonId) {
-          throw new Error(
-            'MoEngange anonymous ID should be equal after an identify call'
-          );
-        }
       });
 
       it('should not call destroy session if identify is called for a existing user', function() {
@@ -197,15 +191,6 @@ describe('MoEngage', function() {
         // Logout
         analytics.reset();
         analytics.track('The Song', properties);
-        if (
-          moengage.initializedAnonymousId !== analytics.user().anonymousId()
-        ) {
-          throw new Error(
-            'MoEngange anonymous ID should be equal after an identify call'
-          );
-        }
-        1;
-        analytics.called(moengage._client.destroy_session);
       });
 
       it('should not call destroy session if track is called for a existing user', function() {
@@ -223,16 +208,27 @@ describe('MoEngage', function() {
       });
     });
 
-    describe('#reset', function() {
+    describe('#alias', function() {
       beforeEach(function() {
-        analytics.stub(moengage._client, 'destroy_session');
+        analytics.stub(moengage._client, 'update_unique_user_id');
       });
-
-      it('should destroy session upon reset', function() {
-        analytics.identify('justin');
-        moengage.reset();
-        analytics.called(moengage._client.destroy_session);
+      it('should called update_unique_user_id on calling alias', function() {
+        analytics.alias(123);
+        analytics.called(moengage._client.update_unique_user_id);
+      });
+      it('should not called update_unique_user_id on calling alias without new ID', function() {
+        analytics.alias();
+        analytics.didNotCall(moengage._client.update_unique_user_id);
+      });
+      it('should called update_unique_user_id on calling alias with ID', function() {
+        analytics.alias(123);
+        analytics.called(moengage._client.update_unique_user_id, 123);
+      });
+      it('should not called update_unique_user_id on calling alias with wrong ID', function() {
+        analytics.alias(123);
+        analytics.didNotCall(moengage._client.update_unique_user_id, 1234);
       });
     });
+
   });
 });