Open
Conversation
…t versions are created after updates
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tcrespog
reviewed
Feb 20, 2026
Comment on lines
+52
to
+53
| @CommandLine.Option(names = {"-f", "--filter"}, description = "Show only pipeline versions with name that contain the given word") | ||
| public String filter; |
Contributor
There was a problem hiding this comment.
- Should the filter be called
searchto be more aligned with the API endpoint param? - Apart from the name, the filter also supports special keywords to search by other properties. Should those be indicated?
Comment on lines
+55
to
+56
| @CommandLine.Option(names = {"--is-published"}, description = "Show only published pipeline versions if true, draft versions only if false, all versions by default", required = false) | ||
| Boolean isPublishedOption = null; |
Contributor
There was a problem hiding this comment.
Is required = false necessary? Aren't the other options also required = false implicitly?
Comment on lines
+73
to
+79
| .forEach(version -> table.addRow( | ||
| version.getName(), | ||
| version.getIsDefault() ? "yes" : "no", | ||
| showFullHash ? version.getHash() : FormatHelper.formatLargeStringWithEllipsis(version.getHash(), 40), | ||
| version.getCreatorUserName(), | ||
| FormatHelper.formatTime(version.getDateCreated()) | ||
| )); |
Contributor
There was a problem hiding this comment.
Should the version ID (launch ID) get printed too? The pipelines versions view command accepts the version ID too, but it wouldn't be displayed anywhere otherwise.
Comment on lines
+334
to
+335
| // GET-only: no request body to verify. Path and query parameter matching (search, isPublished) | ||
| // in the mocks below is sufficient to assert the CLI sends the correct parameters to the server. |
Contributor
There was a problem hiding this comment.
I'd say these explanations next to the section might not be necessary. In fact, in this case it could be somewhat confusing (we are asserting the output too).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipelines versionssubcommand group (list,view,update) to manage pipeline versions--version-id/--version-nameinto existing commands:pipelines view,pipelines export,pipelines update, andlaunchpipelines addgains--version-nameto name the initial version on creationpipelines updatedetects when a versionable field change creates a draft version and reports itpipelines viewdisplays version info (name, default flag, hash) when a version is specifiedpipelines exportincludes the version name in the exported JSON so it survives import round-tripspipelines labelscommands into alabels/sub-package mirroring theversions/structureTest plan
./gradlew test— all unit tests passTOWER_CLI=./build/native/nativeCompile/tw ./gradlew test— all unit tests pass in binary modeTesting guidelines
Setup
Test 1: Create pipeline with initial version name
Verify: Pipeline is created successfully.
Test 2: List versions
Verify: All list variants return v1.0 as the single published version.
Test 3: View version by name and by ID
Verify: Both show version details (ID, name, hash, default flag, creator, timestamps).
Test 4: View pipeline with version targeting
Verify: The first two show Version Name, Version Is Default, and Version Hash rows. The third (no version) omits version info.
Test 5: Update non-versionable field (no draft)
Verify: Output says "Pipeline updated" without any draft message.
Test 6: Update versionable field (creates draft)
Verify:
DRAFT_IDis a non-null version ID. Output includes "New draft version created" message.Test 7: Confirm draft appears in version list
Verify: Two versions shown — v1.0 (published, default) and one unnamed draft.
Test 8: Rename draft version
Verify: Version updated successfully.
Test 9: Set version as default
Verify: Version updated successfully.
Test 10: Update a specific version by name
Verify: Pipeline updated without creating a new draft.
Test 11: Export with version targeting
Verify: The first two include
"version": {"name": "v1.0"}in the JSON. The third (default version) omits the version field.Test 12: Export + import round-trip
Verify: Imported pipeline exists and can be viewed.
Cleanup