After review modifications

Signed-off-by: fjtirado <ftirados@redhat.com>

Author: fjtirado

impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowApplication.java

@@ -58,6 +58,7 @@
 
 public class WorkflowApplication implements AutoCloseable {
 
+  private final String id;
   private final TaskExecutorFactory taskFactory;
   private final ExpressionFactory exprFactory;
   private final ResourceLoaderFactory resourceLoaderFactory;
@@ -108,6 +109,7 @@ private WorkflowApplication(Builder builder) {
     this.templateResolver = builder.templateResolver;
     this.functionReader = builder.functionReader;
     this.defaultCatalogURI = builder.defaultCatalogURI;
+    this.id = builder.id;
   }
 
   public TaskExecutorFactory taskFactory() {
@@ -165,6 +167,7 @@ public SchemaValidator getValidator(SchemaInline inline) {
           };
     }
 
+    private String id;
     private TaskExecutorFactory taskFactory;
     private Collection<ExpressionFactory> exprFactories = new HashSet<>();
     private Collection<WorkflowExecutionListener> listeners =
@@ -198,6 +201,11 @@ private Builder() {
           .forEach(a -> additionalObjects.put(a.name(), a));
     }
 
+    public Builder withId(String id) {
+      this.id = id;
+      return this;
+    }
+
     public Builder withListener(WorkflowExecutionListener listener) {
       listeners.add(listener);
       return this;
@@ -304,13 +312,14 @@ public Builder withDefaultCatalogURI(URI defaultCatalogURI) {
     }
 
     public WorkflowApplication build() {
+
       if (modelFactory == null) {
         modelFactory =
             loadFirst(WorkflowModelFactory.class)
                 .orElseThrow(
                     () ->
                         new IllegalStateException(
-                            "WorkflowModelFactory instance has to be set in WorkflowApplication or present in the classpath"));
+                            "WorkflowModelFactory instance has to be set in WorkflowApplication or pr^eesent in the classpath"));
       }
       if (contextFactory == null) {
         contextFactory = modelFactory;
@@ -360,6 +369,9 @@ public WorkflowApplication build() {
       if (defaultCatalogURI == null) {
         defaultCatalogURI = URI.create("https://github.com/serverlessworkflow/catalog");
       }
+      if (id == null) {
+        id = idFactory.get();
+      }
       return new WorkflowApplication(this);
     }
   }
@@ -453,6 +465,10 @@ public URI defaultCatalogURI() {
     return defaultCatalogURI;
   }
 
+  public String id() {
+    return id;
+  }
+
   public <T> Optional<T> additionalObject(
       String name, WorkflowContext workflowContext, TaskContext taskContext) {
     return Optional.ofNullable(additionalObjects.get(name))

impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowDefinition.java

@@ -165,6 +165,11 @@ public void addTaskExecutor(WorkflowMutablePosition position, TaskExecutor<?> ta
     executors.put(position.jsonPointer(), taskExecutor);
   }
 
+  @Override
+  public WorkflowDefinitionId id() {
+    return definitionId;
+  }
+
   @Override
   public void close() {
     safeClose(resourceLoader);

impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowDefinitionData.java

@@ -22,4 +22,6 @@ public interface WorkflowDefinitionData {
   Workflow workflow();
 
   WorkflowApplication application();
+
+  WorkflowDefinitionId id();
 }

impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowDefinitionId.java

@@ -32,4 +32,8 @@ public static WorkflowDefinitionId of(Workflow workflow) {
   public static WorkflowDefinitionId fromName(String name) {
     return new WorkflowDefinitionId(DEFAULT_NAMESPACE, name, DEFAULT_VERSION);
   }
+
+  public String toString(String separator) {
+    return namespace + separator + name + separator + version;
+  }
 }

impl/persistence/api/src/main/java/io/serverlessworkflow/impl/marshaller/MarshallingUtils.java

@@ -0,0 +1,59 @@
+/*
+ * Copyright 2020-Present The Serverless Workflow Specification Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.serverlessworkflow.impl.marshaller;
+
+import io.serverlessworkflow.impl.WorkflowModel;
+import java.io.ByteArrayOutputStream;
+import java.time.Instant;
+import java.util.function.BiConsumer;
+
+public class MarshallingUtils {
+
+  private MarshallingUtils() {}
+
+  public static byte[] writeInstant(WorkflowBufferFactory factory, Instant instant) {
+    return writeValue(factory, instant, (b, v) -> b.writeInstant(v));
+  }
+
+  public static byte[] writeEnum(WorkflowBufferFactory factory, Enum enumInstance) {
+    return writeValue(factory, enumInstance, (b, v) -> b.writeEnum(v));
+  }
+
+  public static byte[] writeModel(WorkflowBufferFactory factory, WorkflowModel model) {
+    return writeValue(factory, model, (b, v) -> b.writeObject(v));
+  }
+
+  public static byte[] writeShort(WorkflowBufferFactory factory, short value) {
+    return writeValue(factory, value, (b, v) -> b.writeShort(value));
+  }
+
+  public static byte[] writeBoolean(WorkflowBufferFactory factory, boolean value) {
+    return writeValue(factory, value, (b, v) -> b.writeBoolean(value));
+  }
+
+  public static byte[] writeString(WorkflowBufferFactory factory, String value) {
+    return writeValue(factory, value, (b, v) -> b.writeString(value));
+  }
+
+  private static <T> byte[] writeValue(
+      WorkflowBufferFactory factory, T value, BiConsumer<WorkflowOutputBuffer, T> valueConsumer) {
+    ByteArrayOutputStream bytesOut = new ByteArrayOutputStream();
+    try (WorkflowOutputBuffer buffer = factory.output(bytesOut)) {
+      valueConsumer.accept(buffer, value);
+    }
+    return bytesOut.toByteArray();
+  }
+}

…/impl/persistence/bigmap/TaskStatus.java …workflow/impl/marshaller/TaskStatus.javaimpl/persistence/bigmap/src/main/java/io/serverlessworkflow/impl/persistence/bigmap/TaskStatus.java renamed to impl/persistence/api/src/main/java/io/serverlessworkflow/impl/marshaller/TaskStatus.java impl/persistence/bigmap/src/main/java/io/serverlessworkflow/impl/persistence/bigmap/TaskStatus.java renamed to impl/persistence/api/src/main/java/io/serverlessworkflow/impl/marshaller/TaskStatus.java

@@ -13,9 +13,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package io.serverlessworkflow.impl.persistence.bigmap;
+package io.serverlessworkflow.impl.marshaller;
 
-enum TaskStatus {
+public enum TaskStatus {
   COMPLETED,
   RETRIED
 }

impl/persistence/api/src/main/java/io/serverlessworkflow/impl/persistence/AbstractPersistenceInstanceWriter.java

@@ -0,0 +1,43 @@
+/*
+ * Copyright 2020-Present The Serverless Workflow Specification Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.serverlessworkflow.impl.persistence;
+
+import static io.serverlessworkflow.impl.WorkflowUtils.safeClose;
+
+public class DefaultPersistenceInstanceHandlers extends PersistenceInstanceHandlers {
+
+  private final PersistenceInstanceStore store;
+
+  public static DefaultPersistenceInstanceHandlers from(PersistenceInstanceStore store) {
+    return new DefaultPersistenceInstanceHandlers(
+        new DefaultPersistenceInstanceWriter(store),
+        new DefaultPersistenceInstanceReader(store),
+        store);
+  }
+
+  private DefaultPersistenceInstanceHandlers(
+      PersistenceInstanceWriter writer,
+      PersistenceInstanceReader reader,
+      PersistenceInstanceStore store) {
+    super(writer, reader);
+    this.store = store;
+  }
+
+  @Override
+  public void close() {
+    safeClose(store);
+  }
+}

impl/persistence/api/src/main/java/io/serverlessworkflow/impl/persistence/DefaultPersistenceInstanceHandlers.java

@@ -23,16 +23,16 @@
 
 public class DefaultPersistenceInstanceReader implements PersistenceInstanceReader {
 
-  private final PersistenceInstanceStore<String> store;
+  private final PersistenceInstanceStore store;
 
-  protected DefaultPersistenceInstanceReader(PersistenceInstanceStore<String> store) {
+  protected DefaultPersistenceInstanceReader(PersistenceInstanceStore store) {
     this.store = store;
   }
 
   @Override
   public Stream<WorkflowInstance> scan(
       WorkflowDefinition definition, Collection<String> instanceIds) {
-    PersistenceInstanceTransaction<String> transaction = store.begin();
+    PersistenceInstanceTransaction transaction = store.begin();
     return instanceIds.stream()
         .map(id -> read(transaction, definition, id))
         .flatMap(Optional::stream)
@@ -41,7 +41,7 @@ public Stream<WorkflowInstance> scan(
 
   @Override
   public Optional<WorkflowInstance> find(WorkflowDefinition definition, String instanceId) {
-    PersistenceInstanceTransaction<String> transaction = store.begin();
+    PersistenceInstanceTransaction transaction = store.begin();
     try {
       return read(transaction, definition, instanceId);
     } catch (Exception ex) {
@@ -51,14 +51,14 @@ public Optional<WorkflowInstance> find(WorkflowDefinition definition, String ins
   }
 
   private Optional<WorkflowInstance> read(
-      PersistenceInstanceTransaction<String> t, WorkflowDefinition definition, String instanceId) {
+      PersistenceInstanceTransaction t, WorkflowDefinition definition, String instanceId) {
     return t.readWorkflowInfo(definition, instanceId)
         .map(i -> new WorkflowPersistenceInstance(definition, i));
   }
 
   @Override
   public Stream<WorkflowInstance> scanAll(WorkflowDefinition definition) {
-    PersistenceInstanceTransaction<String> transaction = store.begin();
+    PersistenceInstanceTransaction transaction = store.begin();
     return transaction
         .scanAll(definition)
         .onClose(() -> transaction.commit())