From d42beada89a373dd0dc8747b17397b95fdd3792c Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Sun, 14 Dec 2025 18:49:44 +0100 Subject: [PATCH 1/2] lib/list.c: Use for loop instead of while loop Signed-off-by: Alejandro Colomar --- lib/list.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/lib/list.c b/lib/list.c index 8fa0e085ac..39dd2be468 100644 --- a/lib/list.c +++ b/lib/list.c @@ -145,12 +145,8 @@ dup_list(char *const *list) tmp = xmalloc_T(i + 1, char *); - i = 0; - while (NULL != *list) { - tmp[i] = xstrdup (*list); - i++; - list++; - } + for (i = 0; NULL != list[i]; i++) + tmp[i] = xstrdup(list[i]); tmp[i] = NULL; return tmp; @@ -178,11 +174,9 @@ bool is_on_list (char *const *list, const char *member) assert (NULL != member); assert (NULL != list); - while (NULL != *list) { - if (streq(*list, member)) { + for (size_t i = 0; list[i] != NULL; i++) { + if (streq(list[i], member)) return true; - } - list++; } return false; From b829ea2e70fed9f808f0379d5a72144092bcad67 Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Sat, 3 Jan 2026 15:23:10 +0100 Subject: [PATCH 2/2] lib/list.c: Use size_t for array indices and sizes Reported-by: Tobias Stoeckmann Suggested-by: Tobias Stoeckmann Signed-off-by: Alejandro Colomar --- lib/list.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/list.c b/lib/list.c index 39dd2be468..190c211d9d 100644 --- a/lib/list.c +++ b/lib/list.c @@ -8,6 +8,8 @@ #include "config.h" +#include + #include "alloc/malloc.h" #include "prototypes.h" #include "defines.h" @@ -30,8 +32,8 @@ /*@only@*/char ** add_list(/*@returned@*/ /*@only@*/char **list, const char *member) { - int i; - char **tmp; + size_t i; + char **tmp; assert (NULL != member); assert (NULL != list); @@ -81,8 +83,8 @@ add_list(/*@returned@*/ /*@only@*/char **list, const char *member) /*@only@*/char ** del_list(/*@returned@*/ /*@only@*/char **list, const char *member) { - int i, j; - char **tmp; + size_t i, j; + char **tmp; assert (NULL != member); assert (NULL != list); @@ -136,8 +138,8 @@ del_list(/*@returned@*/ /*@only@*/char **list, const char *member) /*@only@*/char ** dup_list(char *const *list) { - int i; - char **tmp; + size_t i; + char **tmp; assert (NULL != list);