fix(terminal): cycle guard in collectWorkflowDescendants, workflow node running/canceled state

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/terminal.tsx

@@ -382,10 +382,13 @@ const WorkflowNodeRow = memo(function WorkflowNodeRow({
     () => Boolean(entry.error) || hasErrorInTree(children),
     [entry.error, children]
   )
-  const hasRunningDescendant = useMemo(() => hasRunningInTree(children), [children])
+  const hasRunningDescendant = useMemo(
+    () => Boolean(entry.isRunning) || hasRunningInTree(children),
+    [entry.isRunning, children]
+  )
   const hasCanceledDescendant = useMemo(
-    () => hasCanceledInTree(children) && !hasRunningDescendant,
-    [children, hasRunningDescendant]
+    () => (Boolean(entry.isCanceled) || hasCanceledInTree(children)) && !hasRunningDescendant,
+    [entry.isCanceled, children, hasRunningDescendant]
   )
 
   return (

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/utils.ts

@@ -199,13 +199,16 @@ interface IterationGroup {
  */
 function collectWorkflowDescendants(
   workflowBlockId: string,
-  workflowChildGroups: Map<string, ConsoleEntry[]>
+  workflowChildGroups: Map<string, ConsoleEntry[]>,
+  visited: Set<string> = new Set()
 ): ConsoleEntry[] {
+  if (visited.has(workflowBlockId)) return []
+  visited.add(workflowBlockId)
   const direct = workflowChildGroups.get(workflowBlockId) ?? []
   const result = [...direct]
   for (const entry of direct) {
     if (isWorkflowBlockType(entry.blockType)) {
-      result.push(...collectWorkflowDescendants(entry.blockId, workflowChildGroups))
+      result.push(...collectWorkflowDescendants(entry.blockId, workflowChildGroups, visited))
     }
   }
   return result