Skip to content

Commit 289e5f9

Browse files
committed
fix(terminal): render iteration children through EntryNodeRow for workflow block expansion
IterationNodeRow was rendering all children as flat BlockRow components, ignoring nodeType. Workflow blocks inside loop iterations were never rendered as WorkflowNodeRow, so they had no expand chevron or child tree.
1 parent a0822dc commit 289e5f9

1 file changed

Lines changed: 14 additions & 4 deletions

File tree

  • apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/terminal.tsx

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,12 +160,16 @@ const IterationNodeRow = memo(function IterationNodeRow({
160160
onSelectEntry,
161161
isExpanded,
162162
onToggle,
163+
expandedNodes,
164+
onToggleNode,
163165
}: {
164166
node: EntryNode
165167
selectedEntryId: string | null
166168
onSelectEntry: (entry: ConsoleEntry) => void
167169
isExpanded: boolean
168170
onToggle: () => void
171+
expandedNodes: Set<string>
172+
onToggleNode: (nodeId: string) => void
169173
}) {
170174
const { entry, children, iterationInfo } = node
171175
const hasError = Boolean(entry.error) || children.some((c) => c.entry.error)
@@ -226,11 +230,13 @@ const IterationNodeRow = memo(function IterationNodeRow({
226230
{isExpanded && hasChildren && (
227231
<div className={ROW_STYLES.nested}>
228232
{children.map((child) => (
229-
<BlockRow
233+
<EntryNodeRow
230234
key={child.entry.id}
231-
entry={child.entry}
232-
isSelected={selectedEntryId === child.entry.id}
233-
onSelect={onSelectEntry}
235+
node={child}
236+
selectedEntryId={selectedEntryId}
237+
onSelectEntry={onSelectEntry}
238+
expandedNodes={expandedNodes}
239+
onToggleNode={onToggleNode}
234240
/>
235241
))}
236242
</div>
@@ -346,6 +352,8 @@ const SubflowNodeRow = memo(function SubflowNodeRow({
346352
onSelectEntry={onSelectEntry}
347353
isExpanded={expandedNodes.has(iterNode.entry.id)}
348354
onToggle={() => onToggleNode(iterNode.entry.id)}
355+
expandedNodes={expandedNodes}
356+
onToggleNode={onToggleNode}
349357
/>
350358
))}
351359
</div>
@@ -520,6 +528,8 @@ const EntryNodeRow = memo(function EntryNodeRow({
520528
onSelectEntry={onSelectEntry}
521529
isExpanded={expandedNodes.has(node.entry.id)}
522530
onToggle={() => onToggleNode(node.entry.id)}
531+
expandedNodes={expandedNodes}
532+
onToggleNode={onToggleNode}
523533
/>
524534
)
525535
}

0 commit comments

Comments
 (0)