Skip to content

Commit 540e0be

Browse files
waleedlatif1claude
andcommitted
improvement(processing): remove dead setupExecutor method
The method body was just a debug log with an `any` parameter — logging now works entirely through trace spans with no executor integration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent a1b91c1 commit 540e0be

File tree

2 files changed

+0
-25
lines changed

2 files changed

+0
-25
lines changed

apps/sim/lib/logs/execution/logging-session.ts

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -239,18 +239,9 @@ export class LoggingSession {
239239
workflowState: this.workflowState,
240240
deploymentVersionId,
241241
})
242-
243-
if (this.requestId) {
244-
logger.debug(`[${this.requestId}] Started logging for execution ${this.executionId}`)
245-
}
246242
} else {
247243
this.isResume = true
248244
await this.loadExistingCost()
249-
if (this.requestId) {
250-
logger.debug(
251-
`[${this.requestId}] Resuming logging for existing execution ${this.executionId}`
252-
)
253-
}
254245
}
255246
} catch (error) {
256247
if (this.requestId) {
@@ -260,16 +251,6 @@ export class LoggingSession {
260251
}
261252
}
262253

263-
/**
264-
* Set up logging on an executor instance
265-
* Note: Logging now works through trace spans only, no direct executor integration needed
266-
*/
267-
setupExecutor(executor: any): void {
268-
if (this.requestId) {
269-
logger.debug(`[${this.requestId}] Logging session ready for execution ${this.executionId}`)
270-
}
271-
}
272-
273254
async complete(params: SessionCompleteParams = {}): Promise<void> {
274255
if (this.completed || this.completing) {
275256
return
@@ -341,10 +322,6 @@ export class LoggingSession {
341322
// Silently fail
342323
}
343324
}
344-
345-
if (this.requestId) {
346-
logger.debug(`[${this.requestId}] Completed logging for execution ${this.executionId}`)
347-
}
348325
} catch (error) {
349326
this.completing = false
350327
logger.error(`Failed to complete logging for execution ${this.executionId}:`, {

apps/sim/lib/workflows/executor/execution-core.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,8 +342,6 @@ export async function executeWorkflowCore(
342342
contextExtensions,
343343
})
344344

345-
loggingSession.setupExecutor(executorInstance)
346-
347345
// Convert initial workflow variables to their native types
348346
if (workflowVariables) {
349347
for (const [varId, variable] of Object.entries(workflowVariables)) {

0 commit comments

Comments
 (0)