fix: resolve PR review comments

- Rename imageFiles/videoFile subblock IDs to avoid canonicalParamId collision
- Add response.ok guard in embeddings and rerank transformResponse
- Remove unused truncation param from types
- Fix test pattern: use beforeEach/clearAllMocks instead of afterEach/resetAllMocks
- Add Array.isArray guard for JSON.parse of imageUrls

Author: fzowl

apps/sim/app/api/tools/voyageai/multimodal-embeddings/route.ts

@@ -77,7 +77,8 @@ export async function POST(request: NextRequest) {
     if (params.imageUrls?.trim()) {
       let urls: string[]
       try {
-        urls = JSON.parse(params.imageUrls)
+        const parsed = JSON.parse(params.imageUrls)
+        urls = Array.isArray(parsed) ? parsed : [parsed]
       } catch {
         urls = params.imageUrls
           .split(/[,\n]/)

apps/sim/blocks/blocks/voyageai.test.ts

@@ -173,9 +173,9 @@ describe('VoyageAIBlock', () => {
       )
       const ids = mmBlocks.map((sb) => sb.id)
       expect(ids).toContain('multimodalInput')
-      expect(ids).toContain('imageFiles')
+      expect(ids).toContain('imageFilesUpload')
       expect(ids).toContain('imageFilesRef')
-      expect(ids).toContain('videoFile')
+      expect(ids).toContain('videoFileUpload')
       expect(ids).toContain('videoFileRef')
       expect(ids).toContain('multimodalModel')
     })

apps/sim/blocks/blocks/voyageai.ts

@@ -73,7 +73,7 @@ export const VoyageAIBlock: BlockConfig = {
       condition: { field: 'operation', value: 'multimodal_embeddings' },
     },
     {
-      id: 'imageFiles',
+      id: 'imageFilesUpload',
       title: 'Image Files',
       type: 'file-upload',
       canonicalParamId: 'imageFiles',
@@ -101,7 +101,7 @@ export const VoyageAIBlock: BlockConfig = {
       mode: 'advanced',
     },
     {
-      id: 'videoFile',
+      id: 'videoFileUpload',
       title: 'Video File',
       type: 'file-upload',
       canonicalParamId: 'videoFile',

apps/sim/tools/voyageai/embeddings.ts

@@ -57,6 +57,9 @@ export const embeddingsTool: ToolConfig<VoyageAIEmbeddingsParams, VoyageAIEmbedd
 
   transformResponse: async (response) => {
     const data = await response.json()
+    if (!response.ok) {
+      throw new Error(data.detail ?? data.message ?? `VoyageAI API error: ${response.status}`)
+    }
     return {
       success: true,
       output: {

apps/sim/tools/voyageai/rerank.ts

@@ -66,6 +66,9 @@ export const rerankTool: ToolConfig<VoyageAIRerankParams, VoyageAIRerankResponse
 
   transformResponse: async (response, params) => {
     const data = await response.json()
+    if (!response.ok) {
+      throw new Error(data.detail ?? data.message ?? `VoyageAI API error: ${response.status}`)
+    }
     const originalDocuments: string[] = params
       ? typeof params.documents === 'string'
         ? JSON.parse(params.documents)

apps/sim/tools/voyageai/types.ts

@@ -5,7 +5,6 @@ export interface VoyageAIEmbeddingsParams {
   input: string | string[]
   model?: string
   inputType?: 'query' | 'document'
-  truncation?: boolean
 }
 
 export interface VoyageAIRerankParams {
@@ -14,7 +13,6 @@ export interface VoyageAIRerankParams {
   documents: string | string[]
   model?: string
   topK?: number
-  truncation?: boolean
 }
 
 export interface VoyageAIEmbeddingsResponse extends ToolResponse {

apps/sim/tools/voyageai/voyageai.test.ts

@@ -2,7 +2,7 @@
  * @vitest-environment node
  */
 import { ToolTester } from '@sim/testing/builders'
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { embeddingsTool } from '@/tools/voyageai/embeddings'
 import { multimodalEmbeddingsTool } from '@/tools/voyageai/multimodal-embeddings'
 import { rerankTool } from '@/tools/voyageai/rerank'
@@ -12,11 +12,7 @@ describe('Voyage AI Embeddings Tool', () => {
 
   beforeEach(() => {
     tester = new ToolTester(embeddingsTool as any)
-  })
-
-  afterEach(() => {
-    tester.cleanup()
-    vi.resetAllMocks()
+    vi.clearAllMocks()
   })
 
   describe('Tool metadata', () => {
@@ -276,11 +272,7 @@ describe('Voyage AI Rerank Tool', () => {
 
   beforeEach(() => {
     tester = new ToolTester(rerankTool as any)
-  })
-
-  afterEach(() => {
-    tester.cleanup()
-    vi.resetAllMocks()
+    vi.clearAllMocks()
   })
 
   describe('Tool metadata', () => {