chore(triggers): deprecate trigger-save subblock (#4107)

* chore(triggers): deprecate trigger-save subblock

Remove the defunct triggerSave subblock from all 102 trigger definitions,
the SubBlockType union, SYSTEM_SUBBLOCK_IDS, tool params, and command
templates. Retain the backwards-compat filter in getTrigger() for any
legacy stored data.

* fix(triggers): remove leftover no-op blocks.push() in linear utils

* chore(triggers): remove orphaned triggerId property and stale comments

Author: waleedlatif1

.claude/commands/add-trigger.md

@@ -423,7 +423,6 @@ export const {service}PollingTrigger: TriggerConfig = {
   subBlocks: [
     { id: 'triggerCredentials', type: 'oauth-input', title: 'Credentials', serviceId: '{service}', requiredScopes: [], required: true, mode: 'trigger', supportsCredentialSets: true },
     // ... service-specific config fields (dropdowns, inputs, switches) ...
-    { id: 'triggerSave', type: 'trigger-save', title: '', hideFromPreview: true, mode: 'trigger', triggerId: '{service}_poller' },
     { id: 'triggerInstructions', type: 'text', title: 'Setup Instructions', hideFromPreview: true, mode: 'trigger', defaultValue: '...' },
   ],
 
@@ -486,7 +485,6 @@ Add to `helm/sim/values.yaml` under the existing polling cron jobs:
 - [ ] Handler implements `PollingProviderHandler` at `lib/webhooks/polling/{service}.ts`
 - [ ] Trigger config has `polling: true` and defines subBlocks manually (no `buildTriggerSubBlocks`)
 - [ ] Provider string matches across: trigger config, handler, `POLLING_PROVIDERS`, polling registry
-- [ ] `triggerSave` subBlock `triggerId` matches trigger config `id`
 - [ ] First poll seeds state and emits nothing
 - [ ] Added provider to `POLLING_PROVIDERS` in `triggers/constants.ts`
 - [ ] Added handler to `POLLING_HANDLERS` in `lib/webhooks/polling/registry.ts`

.cursor/commands/add-trigger.md

@@ -418,7 +418,6 @@ export const {service}PollingTrigger: TriggerConfig = {
   subBlocks: [
     { id: 'triggerCredentials', type: 'oauth-input', title: 'Credentials', serviceId: '{service}', requiredScopes: [], required: true, mode: 'trigger', supportsCredentialSets: true },
     // ... service-specific config fields (dropdowns, inputs, switches) ...
-    { id: 'triggerSave', type: 'trigger-save', title: '', hideFromPreview: true, mode: 'trigger', triggerId: '{service}_poller' },
     { id: 'triggerInstructions', type: 'text', title: 'Setup Instructions', hideFromPreview: true, mode: 'trigger', defaultValue: '...' },
   ],
 
@@ -481,7 +480,6 @@ Add to `helm/sim/values.yaml` under the existing polling cron jobs:
 - [ ] Handler implements `PollingProviderHandler` at `lib/webhooks/polling/{service}.ts`
 - [ ] Trigger config has `polling: true` and defines subBlocks manually (no `buildTriggerSubBlocks`)
 - [ ] Provider string matches across: trigger config, handler, `POLLING_PROVIDERS`, polling registry
-- [ ] `triggerSave` subBlock `triggerId` matches trigger config `id`
 - [ ] First poll seeds state and emits nothing
 - [ ] Added provider to `POLLING_PROVIDERS` in `triggers/constants.ts`
 - [ ] Added handler to `POLLING_HANDLERS` in `lib/webhooks/polling/registry.ts`

apps/sim/blocks/blocks.test.ts

@@ -399,7 +399,6 @@ describe.concurrent('Blocks Module', () => {
         'mcp-dynamic-args',
         'input-format',
         'response-format',
-        'trigger-save',
         'file-upload',
         'input-mapping',
         'variables-input',

apps/sim/blocks/blocks/linear.ts

@@ -2561,7 +2561,6 @@ export const LinearV2Block: BlockConfig<LinearResponse> = {
       (sb) =>
         !sb.id?.startsWith('webhookUrlDisplay') &&
         !sb.id?.startsWith('webhookSecret') &&
-        !sb.id?.startsWith('triggerSave') &&
         !sb.id?.startsWith('triggerInstructions') &&
         !sb.id?.startsWith('selectedTriggerId')
     ),

apps/sim/blocks/types.ts

@@ -153,10 +153,6 @@ export type SubBlockType =
   | 'response-format' // Response structure format
   | 'filter-builder' // Filter conditions builder
   | 'sort-builder' // Sort conditions builder
-  /**
-   * @deprecated Legacy trigger save subblock type.
-   */
-  | 'trigger-save' // Trigger save button with validation
   | 'file-upload' // File uploader
   | 'input-mapping' // Map parent variables to child workflow input schema
   | 'variables-input' // Variable assignments for updating workflow variables
@@ -414,8 +410,6 @@ export interface SubBlockConfig {
   dependsOn?: string[] | { all?: string[]; any?: string[] }
   // Copyable-text specific: Use webhook URL from webhook management hook
   useWebhookUrl?: boolean
-  // Trigger-save specific: The trigger ID for validation and saving
-  triggerId?: string
   // Dropdown/Combobox: Function to fetch options dynamically
   // Works with both 'dropdown' (select-only) and 'combobox' (editable with expression support)
   fetchOptions?: (blockId: string) => Promise<Array<{ label: string; id: string }>>

apps/sim/tools/params.ts

@@ -869,7 +869,6 @@ const EXCLUDED_SUBBLOCK_TYPES = new Set([
   'eval-input',
   'webhook-config',
   'schedule-info',
-  'trigger-save',
   'input-format',
   'response-format',
   'mcp-server-selector',

apps/sim/triggers/airtable/webhook.ts

@@ -47,14 +47,6 @@ export const airtableWebhookTrigger: TriggerConfig = {
       defaultValue: false,
       mode: 'trigger',
     },
-    {
-      id: 'triggerSave',
-      title: '',
-      type: 'trigger-save',
-      hideFromPreview: true,
-      mode: 'trigger',
-      triggerId: 'airtable_webhook',
-    },
     {
       id: 'triggerInstructions',
       title: 'Setup Instructions',

apps/sim/triggers/attio/utils.ts

@@ -56,13 +56,6 @@ export function buildAttioTriggerSubBlocks(triggerId: string): SubBlockConfig[]
       required: true,
       condition: { field: 'selectedTriggerId', value: triggerId },
     },
-    {
-      id: 'triggerSave',
-      title: 'Save',
-      type: 'trigger-save',
-      mode: 'trigger',
-      condition: { field: 'selectedTriggerId', value: triggerId },
-    },
     {
       id: 'triggerInstructions',
       title: 'Setup Instructions',

apps/sim/triggers/calendly/invitee_canceled.ts

@@ -38,18 +38,6 @@ export const calendlyInviteeCanceledTrigger: TriggerConfig = {
         value: 'calendly_invitee_canceled',
       },
     },
-    {
-      id: 'triggerSave',
-      title: '',
-      type: 'trigger-save',
-      hideFromPreview: true,
-      mode: 'trigger',
-      triggerId: 'calendly_invitee_canceled',
-      condition: {
-        field: 'selectedTriggerId',
-        value: 'calendly_invitee_canceled',
-      },
-    },
     {
       id: 'triggerInstructions',
       title: 'Setup Instructions',

apps/sim/triggers/calendly/invitee_created.ts

@@ -47,18 +47,6 @@ export const calendlyInviteeCreatedTrigger: TriggerConfig = {
         value: 'calendly_invitee_created',
       },
     },
-    {
-      id: 'triggerSave',
-      title: '',
-      type: 'trigger-save',
-      hideFromPreview: true,
-      mode: 'trigger',
-      triggerId: 'calendly_invitee_created',
-      condition: {
-        field: 'selectedTriggerId',
-        value: 'calendly_invitee_created',
-      },
-    },
     {
       id: 'triggerInstructions',
       title: 'Setup Instructions',