fix(landing): address PR review issues and convention violations

- Fix auth modal race condition: show loading state instead of redirecting when provider status hasn't loaded yet
- Fix auth modal HTTP error caching: reject non-200 responses so they aren't permanently cached
- Replace <img> with next/image <Image> in auth modal
- Use cn() instead of template literal class concatenation in hero, footer-cta
- Remove commented-out dead code in footer, landing, sitemap
- Remove unused arrow property from FooterItem interface
- Convert relative imports to absolute in integrations/[slug]/page
- Remove no-op sanitizedName variable in signup form
- Remove unnecessary async from llms-full.txt route
- Remove extraneous non-TSDoc comment in auth modal

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: waleedlatif1

apps/sim/app/(auth)/signup/signup-form.tsx

@@ -241,8 +241,6 @@ function SignupFormContent({ githubAvailable, googleAvailable, isProduction }: S
         return
       }
 
-      const sanitizedName = trimmedName
-
       let token: string | undefined
       const widget = turnstileRef.current
       if (turnstileSiteKey && widget) {
@@ -265,7 +263,7 @@ function SignupFormContent({ githubAvailable, googleAvailable, isProduction }: S
         {
           email: emailValue,
           password: passwordValue,
-          name: sanitizedName,
+          name: trimmedName,
         },
         {
           headers: {

apps/sim/app/(landing)/components/auth-modal/auth-modal.tsx

@@ -2,6 +2,7 @@
 
 import { useCallback, useEffect, useState } from 'react'
 import { Loader2, X } from 'lucide-react'
+import Image from 'next/image'
 import { useRouter } from 'next/navigation'
 import { Modal, ModalClose, ModalContent, ModalTitle, ModalTrigger } from '@/components/emcn'
 import { GithubIcon, GoogleIcon } from '@/components/icons'
@@ -26,14 +27,23 @@ interface ProviderStatus {
 
 let fetchPromise: Promise<ProviderStatus> | null = null
 
+const FALLBACK_STATUS: ProviderStatus = {
+  githubAvailable: false,
+  googleAvailable: false,
+  isProduction: false,
+}
+
 function fetchProviderStatus(): Promise<ProviderStatus> {
   if (fetchPromise) return fetchPromise
   fetchPromise = fetch('/api/auth/providers')
-    .then((r) => r.json())
+    .then((r) => {
+      if (!r.ok) throw new Error(`HTTP ${r.status}`)
+      return r.json()
+    })
     .then((data: ProviderStatus) => data)
     .catch(() => {
       fetchPromise = null
-      return { githubAvailable: false, googleAvailable: false, isProduction: false }
+      return FALLBACK_STATUS
     })
   return fetchPromise
 }
@@ -54,7 +64,7 @@ export function AuthModal({ children, defaultView = 'login', source }: AuthModal
 
   const handleOpenChange = useCallback(
     (nextOpen: boolean) => {
-      if (nextOpen && !hasSocial) {
+      if (nextOpen && providerStatus && !hasSocial) {
         router.push(defaultView === 'login' ? '/login' : '/signup')
         return
       }
@@ -64,15 +74,14 @@ export function AuthModal({ children, defaultView = 'login', source }: AuthModal
         captureClientEvent('auth_modal_opened', { view: defaultView, source })
       }
     },
-    [defaultView, hasSocial, router, source]
+    [defaultView, hasSocial, providerStatus, router, source]
   )
 
   const handleSocialLogin = useCallback(async (provider: 'github' | 'google') => {
     setSocialLoading(provider)
     try {
       await client.signIn.social({ provider, callbackURL: '/workspace' })
     } catch {
-      // Redirect handles success; errors are typically cancelled flows
     } finally {
       setSocialLoading(null)
     }
@@ -107,11 +116,12 @@ export function AuthModal({ children, defaultView = 'login', source }: AuthModal
           ) : (
             <>
               <div className='flex flex-col items-start gap-6 pe-10'>
-                <img
+                <Image
                   src={brand.logoUrl || '/logo/sim-landing.svg'}
                   alt={brand.name}
                   width={71}
                   height={22}
+                  unoptimized
                   className='h-[22px] w-auto shrink-0 object-contain'
                 />
                 <div className='flex flex-col gap-1 text-left'>

apps/sim/app/(landing)/components/footer/footer-cta.tsx

@@ -2,6 +2,7 @@
 
 import { useCallback, useRef, useState } from 'react'
 import { ArrowUp } from 'lucide-react'
+import { cn } from '@/lib/core/utils/cn'
 import { captureClientEvent } from '@/lib/posthog/client'
 import { AuthModal } from '@/app/(landing)/components/auth-modal/auth-modal'
 import { useLandingSubmit } from '@/app/(landing)/components/landing-preview/components/landing-preview-panel/landing-preview-panel'
@@ -96,7 +97,7 @@ export function FooterCTA() {
           href='https://docs.sim.ai'
           target='_blank'
           rel='noopener noreferrer'
-          className={`${CTA_BUTTON} border-[var(--landing-border-strong)] text-[var(--landing-text)] transition-colors hover:bg-[var(--landing-bg-elevated)]`}
+          className={cn(CTA_BUTTON, 'border-[var(--landing-border-strong)] text-[var(--landing-text)] transition-colors hover:bg-[var(--landing-bg-elevated)]')}
           onClick={() =>
             trackLandingCta({
               label: 'Docs',
@@ -110,7 +111,7 @@ export function FooterCTA() {
         <AuthModal defaultView='signup' source='footer_cta'>
           <button
             type='button'
-            className={`${CTA_BUTTON} gap-2 border-white bg-white text-black transition-colors hover:border-[#E0E0E0] hover:bg-[#E0E0E0]`}
+            className={cn(CTA_BUTTON, 'gap-2 border-white bg-white text-black transition-colors hover:border-[#E0E0E0] hover:bg-[#E0E0E0]')}
             onClick={() =>
               trackLandingCta({
                 label: 'Get started',

apps/sim/app/(landing)/components/footer/footer.tsx

@@ -9,7 +9,6 @@ interface FooterItem {
   label: string
   href: string
   external?: boolean
-  arrow?: boolean
   externalArrow?: boolean
 }
 
@@ -26,10 +25,8 @@ const PRODUCT_LINKS: FooterItem[] = [
 
 const RESOURCES_LINKS: FooterItem[] = [
   { label: 'Blog', href: '/blog' },
-  // { label: 'Templates', href: '/templates' },
   { label: 'Docs', href: 'https://docs.sim.ai', external: true },
   { label: 'Models', href: '/models' },
-  // { label: 'Academy', href: '/academy' },
   { label: 'Partners', href: '/partners' },
   { label: 'Careers', href: 'https://jobs.ashbyhq.com/sim', external: true, externalArrow: true },
   { label: 'Changelog', href: '/changelog' },

apps/sim/app/(landing)/components/hero/hero.tsx

@@ -1,6 +1,7 @@
 'use client'
 
 import dynamic from 'next/dynamic'
+import { cn } from '@/lib/core/utils/cn'
 import { AuthModal } from '@/app/(landing)/components/auth-modal/auth-modal'
 import { DemoRequestModal } from '@/app/(landing)/components/demo-request/demo-request-modal'
 import { trackLandingCta } from '@/app/(landing)/landing-analytics'
@@ -16,7 +17,6 @@ const LandingPreview = dynamic(
   }
 )
 
-/** Shared base classes for CTA link buttons — matches Deploy/Run button styling in the preview panel. */
 const CTA_BASE =
   'inline-flex items-center h-[32px] rounded-[5px] border px-2.5 font-[430] font-season text-sm'
 
@@ -56,7 +56,7 @@ export default function Hero() {
           <DemoRequestModal theme='light'>
             <button
               type='button'
-              className={`${CTA_BASE} border-[var(--landing-border-strong)] bg-transparent text-[var(--landing-text)] transition-colors hover:bg-[var(--landing-bg-elevated)]`}
+              className={cn(CTA_BASE, 'border-[var(--landing-border-strong)] bg-transparent text-[var(--landing-text)] transition-colors hover:bg-[var(--landing-bg-elevated)]')}
               aria-label='Get a demo'
               onClick={() =>
                 trackLandingCta({ label: 'Get a demo', section: 'hero', destination: 'demo_modal' })
@@ -68,7 +68,7 @@ export default function Hero() {
           <AuthModal defaultView='signup' source='hero'>
             <button
               type='button'
-              className={`${CTA_BASE} gap-2 border-white bg-white text-black transition-colors hover:border-[#E0E0E0] hover:bg-[#E0E0E0]`}
+              className={cn(CTA_BASE, 'gap-2 border-white bg-white text-black transition-colors hover:border-[#E0E0E0] hover:bg-[#E0E0E0]')}
               aria-label='Get started with Sim'
               onClick={() =>
                 trackLandingCta({

apps/sim/app/(landing)/integrations/[slug]/page.tsx

@@ -5,12 +5,12 @@ import { notFound } from 'next/navigation'
 import { getBaseUrl } from '@/lib/core/utils/urls'
 import { AuthModal } from '@/app/(landing)/components/auth-modal/auth-modal'
 import { TEMPLATES } from '@/app/workspace/[workspaceId]/home/components/template-prompts/consts'
-import { IntegrationIcon } from '../components/integration-icon'
-import { blockTypeToIconMap } from '../data/icon-mapping'
-import integrations from '../data/integrations.json'
-import type { AuthType, FAQItem, Integration } from '../data/types'
-import { IntegrationFAQ } from './components/integration-faq'
-import { TemplateCardButton } from './components/template-card-button'
+import { IntegrationIcon } from '@/app/(landing)/integrations/components/integration-icon'
+import { blockTypeToIconMap } from '@/app/(landing)/integrations/data/icon-mapping'
+import integrations from '@/app/(landing)/integrations/data/integrations.json'
+import type { AuthType, FAQItem, Integration } from '@/app/(landing)/integrations/data/types'
+import { IntegrationFAQ } from '@/app/(landing)/integrations/[slug]/components/integration-faq'
+import { TemplateCardButton } from '@/app/(landing)/integrations/[slug]/components/template-card-button'
 
 const allIntegrations = integrations as Integration[]
 const INTEGRATION_COUNT = allIntegrations.length

apps/sim/app/(landing)/landing.tsx

@@ -3,7 +3,6 @@ import { martianMono } from '@/app/_styles/fonts/martian-mono/martian-mono'
 import { season } from '@/app/_styles/fonts/season/season'
 import {
   Collaboration,
-  // Enterprise,
   Features,
   Footer,
   Hero,
@@ -31,7 +30,7 @@ import { LandingAnalytics } from '@/app/(landing)/landing-analytics'
  * - Section `id` attributes serve as fragment anchors for precise AI citations.
  * - Content ordering prioritizes answer-first patterns: definition (Hero) ->
  *   examples (Templates) -> capabilities (Features) -> social proof (Collaboration) ->
- *   enterprise (Enterprise) -> pricing (Pricing) -> testimonials (Testimonials).
+ *   pricing (Pricing) -> testimonials (Testimonials).
  */
 export default async function Landing() {
   const blogPosts = await getNavBlogPosts()
@@ -65,7 +64,6 @@ export default async function Landing() {
           <Templates />
           <Features />
           <Collaboration />
-          {/* <Enterprise /> */}
           <Pricing />
           <Testimonials />
         </article>

apps/sim/app/llms-full.txt/route.ts

@@ -1,6 +1,6 @@
 import { getBaseUrl } from '@/lib/core/utils/urls'
 
-export async function GET() {
+export function GET() {
   const baseUrl = getBaseUrl()
 
   const llmsFullContent = `# Sim — The AI Workspace | Build, Deploy & Manage AI Agents

apps/sim/app/sitemap.ts

@@ -66,10 +66,6 @@ export default async function sitemap(): Promise<MetadataRoute.Sitemap> {
       url: `${baseUrl}/blog/tags`,
       lastModified: now,
     },
-    // {
-    //   url: `${baseUrl}/templates`,
-    //   lastModified: now,
-    // },
     {
       url: `${baseUrl}/changelog`,
       lastModified: now,