Highlight color/style not working correctly with ST3 build 3047

[jguice]

There is an odd default styling being applied to matches. Here's my settings file:

{
  "regex" : [{
    "pattern" : "\\S*\\s*TODO.*",
    "color_scope" : "foo",
  }],
  "enabled" : true,
  "on_load" : true,
  "on_modify" : true,
}

Without any definition for the scope in my theme I get a really odd styling:

If I add a definition to the theme for the scope I get some really strange behavior. For instance if I specify a background color that is the same color as the current them bg, it is ignored. If it's different then it will be applied though.

Also whitespace character markers show up for matched content even though they are set to selection only (the sublime default).

I can't seem to get the foreground color to change at all and specifying italics does nothing.

I've tried multiple themes to check that it's not a problem with a particular one.

There are no errors or seemingly related messages in the console (but I can send a log anyhow if it might help).

Thanks,
Josh

[jguice]

I should add that I'm using the Twilight theme by default and I can't find anywhere in the theme where it specifies black on white with a "mint" border ;)

[skuroda]

I've been meaning to do some clean up on this plugin, so I'll investigate it when it does. Though, I'll try to explain what I think is happening. First, that coloring from your image is what it defaults to if the scope can't be found. When you tried adding it to the tmTheme file, I'm assuming you used foo as your scope name. I'm not sure why it would be ignored if it's the same color as the background. When you specified it, was it with the "foreground" key or "background"? If I recall correctly, the method I use to perform the highlighting uses "foreground" color. I know, it's kind of intuitive, but that's what the API does. As for highlighting spaces, there isn't anything I can do about that. Adding regions effectively creates a "selection". So again, not something I can easily manage unfortunately.

[jguice]

Ah, I would expect it to default to not coloring/styling the match at all but I may not understand fully how this is implemented ;)

I tried a variety of scope names but obsevered no difference in behavior. I also used both foreground and background (together, separate, etc.)

My assumption was that this plugin was just giving me a way to set a scope for a particular regex match which I could then style using standard theme syntax. Sounds like the plugin is applying its own style instead though and only defering to the theme style for some of the look.

I did start to become suspicious that sublime was seeing that as a persisten selection of some kind (and therefore showing the whitespace markers). ST3 really needs a way for someone to style particular keywords, lines, etc. without having to modify the bundled language files. :(

[skuroda]

Without a scope specified, it will default to one that I found in my theme file (it was an arbitrary decision). When you specify one though, it should reference scopes defined in your theme file. Well, then again, I am just using a method in the API, so it's just the behavior I expect. Of course, I could be doing something wrong in the plugin too. It shouldn't apply any styling (beyond the default without a scope being specified). I'll keep this updated though as I progress.