Skip to content

Commit 74d4bd0

Browse files
Merge pull request #195 from skyflowapi/release/23.2.1
Release/23.2.1
2 parents 0a54b1d + a329ef9 commit 74d4bd0

File tree

6 files changed

+16
-6
lines changed

6 files changed

+16
-6
lines changed

.github/workflows/internal_release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
3434
- name: Commit changes
3535
run: |
36-
git config user.name ${{ secrets.SSH_ACTOR }}
36+
git config user.name ${{ github.actor }}
3737
git config user.email ${{ github.actor }}@users.noreply.github.com
3838
git add Skyflow.podspec
3939
git commit -m "[AUTOMATED] Private Release ${{ steps.previoustag.outputs.tag }}.$(git rev-parse --short $GITHUB_SHA)"

Skyflow.podspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Pod::Spec.new do |spec|
22

33
spec.name = "Skyflow"
44

5-
spec.version = "1.17.1"
5+
spec.version = "1.17.1-dev.e5f0290"
66
spec.summary = "skyflow-iOS"
77

88
spec.description = "Skyflow iOS SDK"
@@ -19,7 +19,7 @@ Pod::Spec.new do |spec|
1919
spec.ios.deployment_target = "9.0"
2020

2121

22-
spec.source = { :git => "https://github.com/skyflowapi/skyflow-iOS.git", :tag => "1.17.1" }
22+
spec.source = { :git => "https://github.com/skyflowapi/skyflow-iOS.git", :commit => "e5f0290" }
2323

2424
spec.source_files = "Sources/Skyflow/**/*.{swift}"
2525

Sources/Skyflow/elements/TextField.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -402,13 +402,13 @@ extension TextField {
402402
let currentState = state.getState()
403403
if self.errorTriggered == false {
404404
if self.hasFocus {
405-
updateInputStyle(collectInput!.inputStyles.empty)
405+
updateInputStyle(collectInput!.inputStyles.focus)
406406
errorMessage.alpha = 0.0
407407
}
408408
else if (currentState["isEmpty"] as! Bool || self.actualValue.isEmpty) {
409409
if currentState["isRequired"] as! Bool{
410410
isRequiredCheckFailed = true
411-
updateInputStyle(collectInput!.inputStyles.invalid)
411+
updateInputStyle(collectInput!.inputStyles.empty)
412412
errorMessage.alpha = 1.0
413413
}else {
414414
updateInputStyle(collectInput!.inputStyles.complete)

Sources/Skyflow/elements/TextFieldValidationDelegate.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ internal class TextFieldValidationDelegate: NSObject, UITextFieldDelegate {
5858
textField.text = "\(month)"
5959
}
6060
}
61+
self.collectField.onChangeHandler?((collectField.state as! StateforText).getStateForListener())
6162
self.collectField.updateActualValue()
6263
return false
6364
}

Tests/skyflow-iOS-elementTests/skyflow_iOS_elementTests.swift

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55

66
import XCTest
7+
import UIKit
78
@testable import Skyflow
89

910
// swiftlint:disable:next type_body_length
@@ -62,6 +63,14 @@ class skyflow_iOS_elementTests: XCTestCase {
6263

6364
XCTAssertEqual(skyflowElement.validate().count, 0)
6465
}
66+
func testStyleOnFocusElement(){
67+
skyflowElement.collectInput.inputStyles.focus?.borderColor = .red
68+
skyflowElement.collectInput.inputStyles.empty?.borderColor = .blue
69+
skyflowElement.collectInput.inputStyles.focus?.textColor = .red
70+
XCTAssertEqual(skyflowElement.collectInput.inputStyles.focus?.borderColor, .red)
71+
XCTAssertEqual(skyflowElement.collectInput.inputStyles.focus?.textColor, .red)
72+
XCTAssertEqual(skyflowElement.collectInput.inputStyles.empty?.borderColor, .blue)
73+
}
6574

6675
func testTextFieldDefaults() {
6776
XCTAssertNil(textField.textFieldBorderColor)

Tests/skyflow-iOS-errorTests/Skyflow_iOS_generalErrorTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class Skyflow_iOS_generalErrorTests: XCTestCase {
4747
func testSkyflowValidateCardExpirationDate() {
4848
let expiryDaterRule = SkyflowValidateCardExpirationDate(format: "mm/yy", error: SkyflowValidationErrorType.expirationDate.rawValue)
4949

50-
XCTAssertEqual(expiryDaterRule.validate("12/22"), true)
50+
XCTAssertEqual(expiryDaterRule.validate("12/30"), true)
5151

5252
XCTAssertEqual(expiryDaterRule.validate("12"), false)
5353
XCTAssertEqual(expiryDaterRule.validate("abc"), false)

0 commit comments

Comments
 (0)