From 110bba9157c630cd097a391cb1c9d14899a01b58 Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Thu, 2 Apr 2026 13:06:36 -0700 Subject: [PATCH] chore!: remove outdated "platform-improvements" survey fallback --- cmd/feedback/feedback.go | 11 ++--------- cmd/feedback/feedback_test.go | 11 ----------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/cmd/feedback/feedback.go b/cmd/feedback/feedback.go index 276bdcec..1bfe2726 100644 --- a/cmd/feedback/feedback.go +++ b/cmd/feedback/feedback.go @@ -68,9 +68,8 @@ const ( // Supported survey names const ( - SlackCLIFeedback = "slack-cli" - SlackPlatformFeedback = "slack-platform" - SlackPlatformFeedbackDeprecated = "platform-improvements" // DEPRECATED(semver:major) + SlackCLIFeedback = "slack-cli" + SlackPlatformFeedback = "slack-platform" ) type SurveyConfigInterface interface { @@ -241,12 +240,6 @@ func runFeedbackCommand(ctx context.Context, clients *shared.ClientFactory, cmd return nil } - // DEPRECATED(semver:major): Support the deprecated survey name for backwards compatibility - if surveyNameFlag == SlackPlatformFeedbackDeprecated { - surveyNameFlag = SlackPlatformFeedback - clients.IO.PrintWarning(ctx, "DEPRECATED: The '--name %s' flag is deprecated; use '--name %s' instead", SlackPlatformFeedbackDeprecated, SlackPlatformFeedback) - } - surveyNames, surveyPromptOptions := initSurveyOpts(ctx, clients, SurveyStore) if _, ok := SurveyStore[surveyNameFlag]; !ok && surveyNameFlag != "" { diff --git a/cmd/feedback/feedback_test.go b/cmd/feedback/feedback_test.go index 78e80d15..b5dee9ae 100644 --- a/cmd/feedback/feedback_test.go +++ b/cmd/feedback/feedback_test.go @@ -263,17 +263,6 @@ func TestShowSurveyMessages(t *testing.T) { func Test_Feedback_FeedbackCommand(t *testing.T) { testutil.TableTestCommand(t, testutil.CommandTests{ - // DEPRECATED(semver:major): Support the deprecated survey name for backwards compatibility - "supports deprecated --name platform-improvements": { - CmdArgs: []string{"--name", "platform-improvements"}, - Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) { - setupFeedbackCommandMocks(t, ctx, cm, cf) - }, - ExpectedOutputs: []string{ - "feedback@slack.com", - "https://docs.slack.dev/developer-support", - }, - }, "supports --name slack-cli": { CmdArgs: []string{"--name", "slack-cli"}, Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {