-
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathhttp_generic_client_test.go
More file actions
847 lines (713 loc) · 22.8 KB
/
http_generic_client_test.go
File metadata and controls
847 lines (713 loc) · 22.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
package httpx
import (
"bytes"
"context"
"encoding/json"
"io"
"net/http"
"net/http/httptest"
"strings"
"testing"
"time"
)
// Test data structures for generic client tests
type User struct {
ID int `json:"id"`
Name string `json:"name"`
Email string `json:"email"`
}
type Post struct {
ID int `json:"id"`
Title string `json:"title"`
Body string `json:"body"`
UserID int `json:"userId"`
}
type APIError struct {
Code string `json:"code"`
Message string `json:"message"`
}
// TestNewGenericClient tests the creation of a new generic client
func TestNewGenericClient(t *testing.T) {
t.Run("Default client", func(t *testing.T) {
client := NewGenericClient[User]()
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.httpClient == nil {
t.Error("httpClient should be initialized")
}
})
t.Run("With custom timeout", func(t *testing.T) {
timeout := 5 * time.Second
client := NewGenericClient[User](
WithTimeout[User](timeout),
)
if httpClient, ok := client.httpClient.(*http.Client); ok {
if httpClient.Timeout != timeout {
t.Errorf("Expected timeout %v, got %v", timeout, httpClient.Timeout)
}
} else {
t.Error("httpClient should be *http.Client")
}
})
t.Run("With custom HTTP client", func(t *testing.T) {
customClient := &http.Client{
Timeout: 10 * time.Second,
}
client := NewGenericClient[User](
WithHTTPClient[User](customClient),
)
if client.httpClient != customClient {
t.Error("Expected custom HTTP client to be used")
}
})
t.Run("With nil HTTP client (should be ignored)", func(t *testing.T) {
client := NewGenericClient[User](
WithHTTPClient[User](nil),
)
if client.httpClient == nil {
t.Error("httpClient should not be nil when nil option is provided")
}
})
}
// TestGenericClient_Execute tests the Execute method
func TestGenericClient_Execute(t *testing.T) {
t.Run("Successful GET request", func(t *testing.T) {
expectedUser := User{ID: 1, Name: "John Doe", Email: "john@example.com"}
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet {
t.Errorf("Expected GET method, got %s", r.Method)
}
w.Header().Set("Content-Type", "application/json")
if err := json.NewEncoder(w).Encode(expectedUser); err != nil {
t.Errorf("Failed to encode response: %v", err)
}
}))
defer server.Close()
client := NewGenericClient[User]()
req, _ := http.NewRequest(http.MethodGet, server.URL, nil)
resp, err := client.Execute(req)
if err != nil {
t.Fatalf("Execute failed: %v", err)
}
if resp.StatusCode != http.StatusOK {
t.Errorf("Expected status %d, got %d", http.StatusOK, resp.StatusCode)
}
if resp.Data.ID != expectedUser.ID {
t.Errorf("Expected ID %d, got %d", expectedUser.ID, resp.Data.ID)
}
if resp.Data.Name != expectedUser.Name {
t.Errorf("Expected Name %s, got %s", expectedUser.Name, resp.Data.Name)
}
})
t.Run("HTTP error response", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusNotFound)
if err := json.NewEncoder(w).Encode(map[string]string{
"message": "User not found",
}); err != nil {
t.Errorf("Failed to encode response: %v", err)
}
}))
defer server.Close()
client := NewGenericClient[User]()
req, _ := http.NewRequest(http.MethodGet, server.URL, nil)
_, err := client.Execute(req)
if err == nil {
t.Fatal("Expected error for 404 response")
}
errorResp, ok := err.(*ErrorResponse)
if !ok {
t.Fatalf("Expected ErrorResponse, got %T", err)
}
if errorResp.StatusCode != http.StatusNotFound {
t.Errorf("Expected status code %d, got %d", http.StatusNotFound, errorResp.StatusCode)
}
if !strings.Contains(errorResp.Message, "not found") {
t.Errorf("Expected error message about 'not found', got %s", errorResp.Message)
}
})
t.Run("Empty response body", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusNoContent)
}))
defer server.Close()
client := NewGenericClient[User]()
req, _ := http.NewRequest(http.MethodGet, server.URL, nil)
resp, err := client.Execute(req)
if err != nil {
t.Fatalf("Execute failed: %v", err)
}
if resp.StatusCode != http.StatusNoContent {
t.Errorf("Expected status %d, got %d", http.StatusNoContent, resp.StatusCode)
}
if len(resp.RawBody) != 0 {
t.Errorf("Expected empty body, got %d bytes", len(resp.RawBody))
}
})
t.Run("Invalid JSON response", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if _, err := w.Write([]byte("invalid json")); err != nil {
t.Errorf("Failed to write response: %v", err)
}
}))
defer server.Close()
client := NewGenericClient[User]()
req, _ := http.NewRequest(http.MethodGet, server.URL, nil)
_, err := client.Execute(req)
if err == nil {
t.Fatal("Expected error for invalid JSON")
}
if !strings.Contains(err.Error(), "unmarshal") {
t.Errorf("Expected unmarshal error, got: %v", err)
}
})
}
// TestGenericClient_ConvenienceMethods tests GET, POST, PUT, DELETE, PATCH methods
func TestGenericClient_ConvenienceMethods(t *testing.T) {
t.Run("Get method", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet {
t.Errorf("Expected GET, got %s", r.Method)
}
if err := json.NewEncoder(w).Encode(User{ID: 1, Name: "John"}); err != nil {
t.Errorf("Failed to encode response: %v", err)
}
}))
defer server.Close()
client := NewGenericClient[User]()
resp, err := client.Get(server.URL)
if err != nil {
t.Fatalf("Get failed: %v", err)
}
if resp.Data.ID != 1 {
t.Errorf("Expected ID 1, got %d", resp.Data.ID)
}
})
t.Run("Post method", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodPost {
t.Errorf("Expected POST, got %s", r.Method)
}
var user User
if err := json.NewDecoder(r.Body).Decode(&user); err != nil {
t.Errorf("Failed to decode request: %v", err)
}
user.ID = 123
if err := json.NewEncoder(w).Encode(user); err != nil {
t.Errorf("Failed to encode response: %v", err)
}
}))
defer server.Close()
client := NewGenericClient[User]()
userData, _ := json.Marshal(User{Name: "Jane", Email: "jane@example.com"})
resp, err := client.Post(server.URL, bytes.NewReader(userData))
if err != nil {
t.Fatalf("Post failed: %v", err)
}
if resp.Data.ID != 123 {
t.Errorf("Expected ID 123, got %d", resp.Data.ID)
}
})
t.Run("Put method", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodPut {
t.Errorf("Expected PUT, got %s", r.Method)
}
if err := json.NewEncoder(w).Encode(User{ID: 1, Name: "Updated"}); err != nil {
t.Errorf("Failed to encode response: %v", err)
}
}))
defer server.Close()
client := NewGenericClient[User]()
userData, _ := json.Marshal(User{ID: 1, Name: "Updated"})
resp, err := client.Put(server.URL, bytes.NewReader(userData))
if err != nil {
t.Fatalf("Put failed: %v", err)
}
if resp.Data.Name != "Updated" {
t.Errorf("Expected Name 'Updated', got %s", resp.Data.Name)
}
})
t.Run("Delete method", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
t.Errorf("Expected DELETE, got %s", r.Method)
}
w.WriteHeader(http.StatusNoContent)
}))
defer server.Close()
client := NewGenericClient[User]()
resp, err := client.Delete(server.URL)
if err != nil {
t.Fatalf("Delete failed: %v", err)
}
if resp.StatusCode != http.StatusNoContent {
t.Errorf("Expected status %d, got %d", http.StatusNoContent, resp.StatusCode)
}
})
t.Run("Patch method", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodPatch {
t.Errorf("Expected PATCH, got %s", r.Method)
}
if err := json.NewEncoder(w).Encode(User{ID: 1, Name: "Patched"}); err != nil {
t.Errorf("Failed to encode response: %v", err)
}
}))
defer server.Close()
client := NewGenericClient[User]()
patchData, _ := json.Marshal(map[string]string{"name": "Patched"})
resp, err := client.Patch(server.URL, bytes.NewReader(patchData))
if err != nil {
t.Fatalf("Patch failed: %v", err)
}
if resp.Data.Name != "Patched" {
t.Errorf("Expected Name 'Patched', got %s", resp.Data.Name)
}
})
}
// TestGenericClient_ExecuteRaw tests the ExecuteRaw method
func TestGenericClient_ExecuteRaw(t *testing.T) {
t.Run("Returns raw response", func(t *testing.T) {
expectedBody := "raw response body"
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if _, err := w.Write([]byte(expectedBody)); err != nil {
t.Errorf("Failed to write response: %v", err)
}
}))
defer server.Close()
client := NewGenericClient[User]()
req, _ := http.NewRequest(http.MethodGet, server.URL, nil)
resp, err := client.ExecuteRaw(req)
if err != nil {
t.Fatalf("ExecuteRaw failed: %v", err)
}
defer resp.Body.Close()
body, _ := io.ReadAll(resp.Body)
if string(body) != expectedBody {
t.Errorf("Expected body %s, got %s", expectedBody, string(body))
}
})
}
// TestGenericClient_Do tests the Do method alias
func TestGenericClient_Do(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if err := json.NewEncoder(w).Encode(User{ID: 1, Name: "Test"}); err != nil {
t.Errorf("Failed to encode response: %v", err)
}
}))
defer server.Close()
client := NewGenericClient[User]()
req, _ := http.NewRequest(http.MethodGet, server.URL, nil)
resp, err := client.Do(req)
if err != nil {
t.Fatalf("Do failed: %v", err)
}
if resp.Data.ID != 1 {
t.Errorf("Expected ID 1, got %d", resp.Data.ID)
}
}
// TestGenericClient_WithRequestBuilder tests integration with RequestBuilder
func TestGenericClient_WithRequestBuilder(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodPost {
t.Errorf("Expected POST, got %s", r.Method)
}
if r.Header.Get("Content-Type") != "application/json" {
t.Errorf("Expected Content-Type application/json, got %s", r.Header.Get("Content-Type"))
}
if r.Header.Get("Authorization") != "Bearer token123" {
t.Errorf("Expected Authorization header, got %s", r.Header.Get("Authorization"))
}
var post Post
if err := json.NewDecoder(r.Body).Decode(&post); err != nil {
t.Errorf("Failed to decode request: %v", err)
}
post.ID = 42
if err := json.NewEncoder(w).Encode(post); err != nil {
t.Errorf("Failed to encode response: %v", err)
}
}))
defer server.Close()
// Create client
client := NewGenericClient[Post]()
// Use RequestBuilder to create request with headers
post := Post{Title: "Test Post", Body: "Test content", UserID: 1}
req, err := NewRequestBuilder(server.URL).
WithMethodPOST().
WithPath("/posts").
WithContentType("application/json").
WithHeader("Authorization", "Bearer token123").
WithJSONBody(post).
Build()
if err != nil {
t.Fatalf("RequestBuilder.Build failed: %v", err)
}
// Execute request with client
resp, err := client.Do(req)
if err != nil {
t.Fatalf("client.Do failed: %v", err)
}
if resp.Data.ID != 42 {
t.Errorf("Expected ID 42, got %d", resp.Data.ID)
}
if resp.Data.Title != "Test Post" {
t.Errorf("Expected Title 'Test Post', got %s", resp.Data.Title)
}
}
// TestErrorResponse_Error tests the Error method of ErrorResponse
func TestErrorResponse_Error(t *testing.T) {
tests := []struct {
name string
err *ErrorResponse
expected string
}{
{
name: "With Message field",
err: &ErrorResponse{
StatusCode: 404,
Message: "Resource not found",
},
expected: "http 404: Resource not found",
},
{
name: "With ErrorMsg field",
err: &ErrorResponse{
StatusCode: 500,
ErrorMsg: "Internal server error",
},
expected: "http 500: Internal server error",
},
{
name: "Without message",
err: &ErrorResponse{
StatusCode: 400,
},
expected: "http 400: request failed",
},
{
name: "Message takes precedence over ErrorMsg",
err: &ErrorResponse{
StatusCode: 403,
Message: "Forbidden",
ErrorMsg: "Access denied",
},
expected: "http 403: Forbidden",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := tt.err.Error()
if result != tt.expected {
t.Errorf("Expected %q, got %q", tt.expected, result)
}
})
}
}
// TestGenericClient_MultipleTypes tests using multiple typed clients
func TestGenericClient_MultipleTypes(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if strings.Contains(r.URL.Path, "/users") {
if err := json.NewEncoder(w).Encode(User{ID: 1, Name: "John"}); err != nil {
t.Errorf("Failed to encode response: %v", err)
}
} else if strings.Contains(r.URL.Path, "/posts") {
if err := json.NewEncoder(w).Encode(Post{ID: 100, Title: "Test Post"}); err != nil {
t.Errorf("Failed to encode response: %v", err)
}
}
}))
defer server.Close()
// Create two clients with different types
userClient := NewGenericClient[User]()
postClient := NewGenericClient[Post]()
// Test user client
userResp, err := userClient.Get(server.URL + "/users/1")
if err != nil {
t.Fatalf("userClient.Get failed: %v", err)
}
if userResp.Data.Name != "John" {
t.Errorf("Expected user name John, got %s", userResp.Data.Name)
}
// Test post client
postResp, err := postClient.Get(server.URL + "/posts/100")
if err != nil {
t.Fatalf("postClient.Get failed: %v", err)
}
if postResp.Data.Title != "Test Post" {
t.Errorf("Expected post title 'Test Post', got %s", postResp.Data.Title)
}
}
// TestGenericClient_ContextPropagation tests context propagation
func TestGenericClient_ContextPropagation(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// Simulate slow response
time.Sleep(100 * time.Millisecond)
if err := json.NewEncoder(w).Encode(User{ID: 1}); err != nil {
t.Errorf("Failed to encode response: %v", err)
}
}))
defer server.Close()
client := NewGenericClient[User]()
// Create request with cancelled context
ctx, cancel := context.WithCancel(context.Background())
cancel() // Cancel immediately
req, _ := http.NewRequestWithContext(ctx, http.MethodGet, server.URL, nil)
_, err := client.Execute(req)
if err == nil {
t.Fatal("Expected error with cancelled context")
}
if !strings.Contains(err.Error(), "context") {
t.Errorf("Expected context error, got: %v", err)
}
}
// TestGenericClient_AllConfigurationOptions tests all the new configuration options
func TestGenericClient_AllConfigurationOptions(t *testing.T) {
t.Run("With all configuration options", func(t *testing.T) {
timeout := 15 * time.Second
maxRetries := 5
baseDelay := 1 * time.Second
maxDelay := 10 * time.Second
client := NewGenericClient[User](
WithTimeout[User](timeout),
WithMaxRetries[User](maxRetries),
WithRetryBaseDelay[User](baseDelay),
WithRetryMaxDelay[User](maxDelay),
WithRetryStrategy[User](JitterBackoffStrategy),
WithMaxIdleConns[User](50),
WithIdleConnTimeout[User](60*time.Second),
WithTLSHandshakeTimeout[User](5*time.Second),
WithExpectContinueTimeout[User](2*time.Second),
WithMaxIdleConnsPerHost[User](25),
WithDisableKeepAlive[User](false),
)
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.httpClient == nil {
t.Fatal("httpClient should be initialized")
}
// Verify the client was built with an HTTP client
if httpClient, ok := client.httpClient.(*http.Client); ok {
if httpClient.Timeout != timeout {
t.Errorf("Expected timeout %v, got %v", timeout, httpClient.Timeout)
}
// Verify the transport is configured
if httpClient.Transport == nil {
t.Error("Transport should be configured")
}
} else {
t.Error("Expected *http.Client as underlying client")
}
})
t.Run("WithRetryStrategyAsString", func(t *testing.T) {
client := NewGenericClient[User](
WithRetryStrategyAsString[User]("fixed"),
WithMaxRetries[User](3),
)
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.httpClient == nil {
t.Fatal("httpClient should be initialized")
}
})
t.Run("WithHTTPClient takes precedence", func(t *testing.T) {
customClient := &http.Client{
Timeout: 99 * time.Second,
}
client := NewGenericClient[User](
WithTimeout[User](15*time.Second), // Should be ignored
WithMaxRetries[User](5), // Should be ignored
WithHTTPClient[User](customClient), // Should take precedence
)
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.httpClient != customClient {
t.Error("Expected custom HTTP client to be used")
}
if httpClient, ok := client.httpClient.(*http.Client); ok {
if httpClient.Timeout != 99*time.Second {
t.Errorf("Expected timeout 99s, got %v", httpClient.Timeout)
}
}
})
t.Run("Default client with no options", func(t *testing.T) {
client := NewGenericClient[User]()
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.httpClient == nil {
t.Fatal("httpClient should be initialized")
}
// Should have default timeout from ClientBuilder
if httpClient, ok := client.httpClient.(*http.Client); ok {
if httpClient.Timeout != DefaultTimeout {
t.Errorf("Expected default timeout %v, got %v", DefaultTimeout, httpClient.Timeout)
}
}
})
t.Run("Invalid values should use ClientBuilder defaults", func(t *testing.T) {
// Use out-of-range values
client := NewGenericClient[User](
WithTimeout[User](0), // Invalid, should use default
WithMaxRetries[User](999), // Invalid, should use default
WithMaxIdleConns[User](9999), // Invalid, should use default
)
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.httpClient == nil {
t.Fatal("httpClient should be initialized")
}
// ClientBuilder should have applied defaults
if httpClient, ok := client.httpClient.(*http.Client); ok {
// Should have been corrected to default
if httpClient.Timeout != DefaultTimeout {
t.Errorf("Expected default timeout %v, got %v", DefaultTimeout, httpClient.Timeout)
}
}
})
t.Run("Mix of options and WithHTTPClient", func(t *testing.T) {
// Build a client using ClientBuilder
httpClient := NewClientBuilder().
WithMaxRetries(3).
WithRetryStrategy(ExponentialBackoffStrategy).
WithTimeout(10 * time.Second).
Build()
// Use it with GenericClient
client := NewGenericClient[User](
WithHTTPClient[User](httpClient),
)
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.httpClient != httpClient {
t.Error("Expected the built HTTP client to be used")
}
})
}
// TestGenericClient_OptionsIntegration tests that options actually affect behavior
func TestGenericClient_OptionsIntegration(t *testing.T) {
t.Run("Configured client is usable", func(t *testing.T) {
client := NewGenericClient[User](
WithTimeout[User](5*time.Second),
WithMaxRetries[User](2),
WithRetryStrategy[User](FixedDelayStrategy),
)
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
// The client should be functional (we won't make actual requests,
// but we can verify it's properly constructed)
if client.httpClient == nil {
t.Fatal("httpClient should be initialized")
}
// Verify we can call methods without panicking
if httpClient, ok := client.httpClient.(*http.Client); ok {
if httpClient.Transport == nil {
t.Error("Transport should be configured")
}
}
})
}
func TestGenericClient_WithProxy(t *testing.T) {
t.Run("Create client with proxy URL", func(t *testing.T) {
proxyURL := "http://proxy.example.com:8080"
client := NewGenericClient[User](
WithProxy[User](proxyURL),
)
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.proxyURL == nil {
t.Fatal("proxyURL should be set")
}
if *client.proxyURL != proxyURL {
t.Errorf("Expected proxy URL %s, got %s", proxyURL, *client.proxyURL)
}
})
t.Run("Create client with HTTPS proxy", func(t *testing.T) {
proxyURL := "https://secure-proxy.example.com:3128"
client := NewGenericClient[User](
WithProxy[User](proxyURL),
)
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.proxyURL == nil || *client.proxyURL != proxyURL {
t.Errorf("Expected proxy URL %s", proxyURL)
}
})
t.Run("Create client without proxy", func(t *testing.T) {
client := NewGenericClient[User]()
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.proxyURL != nil {
t.Error("proxyURL should be nil when not configured")
}
})
t.Run("Create client with empty proxy (disable)", func(t *testing.T) {
client := NewGenericClient[User](
WithProxy[User](""),
)
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.proxyURL == nil {
t.Fatal("proxyURL should be set (even if empty)")
}
if *client.proxyURL != "" {
t.Error("Expected empty proxy URL")
}
})
t.Run("Build HTTP client with proxy", func(t *testing.T) {
proxyURL := "http://proxy.example.com:8080"
client := NewGenericClient[User](
WithProxy[User](proxyURL),
)
if client.httpClient == nil {
t.Fatal("httpClient should be initialized")
}
// Verify the transport has proxy configured
if httpClient, ok := client.httpClient.(*http.Client); ok {
if rt, ok := httpClient.Transport.(*retryTransport); ok {
if transport, ok := rt.Transport.(*http.Transport); ok {
if transport.Proxy == nil {
t.Error("Expected Proxy to be configured")
}
} else {
t.Error("Expected *http.Transport")
}
} else {
t.Error("Expected *retryTransport")
}
} else {
t.Error("Expected *http.Client")
}
})
t.Run("Combine proxy with other options", func(t *testing.T) {
proxyURL := "http://proxy.example.com:8080"
client := NewGenericClient[User](
WithProxy[User](proxyURL),
WithTimeout[User](10*time.Second),
WithMaxRetries[User](3),
WithRetryStrategy[User](ExponentialBackoffStrategy),
)
if client == nil {
t.Fatal("NewGenericClient returned nil")
}
if client.proxyURL == nil || *client.proxyURL != proxyURL {
t.Error("Proxy URL should be configured")
}
if client.timeout == nil || *client.timeout != 10*time.Second {
t.Error("Timeout should be configured")
}
if client.maxRetries == nil || *client.maxRetries != 3 {
t.Error("MaxRetries should be configured")
}
})
}