Fix tests

Author: albertsola

tests/e2e/accounts/accounts_users/test_async_accounts_users.py

@@ -1,5 +1,3 @@
-# noqa: WPS204, WPS420, WPS421, WPS210, AAA01
-# noqa: WPS402
 import pytest
 
 from mpt_api_client.exceptions import MPTAPIError

tests/e2e/accounts/accounts_users/test_sync_accounts_users.py

@@ -1,4 +1,3 @@
-# noqa: WPS402
 import pytest
 
 from mpt_api_client.exceptions import MPTAPIError
@@ -8,7 +7,7 @@
 
 
 @pytest.fixture
-def users(mpt_vendor, account_id):  # noqa: WPS204
+def users(mpt_vendor, account_id):
     return mpt_vendor.accounts.accounts.users(account_id=account_id)  # noqa: WPS204
 
 
@@ -76,21 +75,23 @@ def created_account_user_group(mpt_vendor, created_account_user, created_user_gr
         print(f"TEARDOWN - Unable to delete account user group: {error.title}")  # noqa: WPS421
 
 
-def test_get_account_user_by_id(mpt_vendor, user_id, account_id):  # noqa: AAA01
+def test_get_account_user_by_id(mpt_vendor, user_id, account_id):
     """Test retrieving an account user by ID."""
     users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id)
-    account_user = users_obj.get(user_id)
-    assert account_user is not None
 
+    result = users_obj.get(user_id)
 
-def test_list_account_users(mpt_vendor, account_id):  # noqa: AAA01
+    assert result is not None
+
+
+def test_list_account_users(mpt_vendor, account_id):
     """Test listing account users."""
     limit = 10
-
     users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id)
-    account_users = users_obj.fetch_page(limit=limit)
 
-    assert len(account_users) > 0
+    result = users_obj.fetch_page(limit=limit)
+
+    assert len(result) > 0
 
 
 def test_get_account_user_by_id_not_found(mpt_vendor, invalid_user_id, account_id):
@@ -101,31 +102,34 @@ def test_get_account_user_by_id_not_found(mpt_vendor, invalid_user_id, account_i
         users_obj.get(invalid_user_id)
 
 
-def test_filter_account_users(mpt_vendor, user_id, account_id):  # noqa: AAA01
+def test_filter_account_users(mpt_vendor, user_id, account_id):
     """Test filtering account users."""
     select_fields = ["-name"]
-
     users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id)
     filtered_account_users = users_obj.filter(RQLQuery(id=user_id)).select(*select_fields)
-    account_users = list(filtered_account_users.iterate())
 
-    assert len(account_users) == 1
+    result = list(filtered_account_users.iterate())
 
+    assert len(result) == 1
 
-def test_create_account_user(created_account_user):  # noqa: AAA01
+
+def test_create_account_user(created_account_user):
     """Test creating an account user."""
-    account_user_data = created_account_user()
-    assert account_user_data is not None
+    result = created_account_user()
+
+    assert result is not None
 
 
-def test_delete_account_user(mpt_vendor, created_account_user, account_id):  # noqa: AAA01
+def test_delete_account_user(mpt_vendor, created_account_user, account_id):
     """Test deleting an account user."""
     account_user_data = created_account_user()
-    users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id)
-    users_obj.delete(account_user_data.id)
 
+    result = mpt_vendor.accounts.accounts.users(account_id=account_id)
+
+    result.delete(account_user_data.id)
 
-def test_update_account_user(  # noqa: AAA01
+
+def test_update_account_user(
     mpt_vendor,
     account_user_factory,
     created_account_user,
@@ -138,32 +142,37 @@ def test_update_account_user(  # noqa: AAA01
         first_name="E2E Updated",
         last_name="Account User",
     )
-    updated_account_user = users_obj.update(
+
+    result = users_obj.update(
         account_user_data.id,
         updated_account_user_data,
     )
-    assert updated_account_user is not None
+
+    assert result is not None
 
 
-def test_account_user_resend_invite(  # noqa: AAA01
+def test_account_user_resend_invite(
     mpt_vendor,
     created_account_user,
     account_id,
 ):
     """Test resending an invite to an account user."""
     account_user_data = created_account_user()
     users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id)
-    resend_invite = users_obj.resend_invite(account_user_data.id)
-    assert resend_invite is not None
+
+    result = users_obj.resend_invite(account_user_data.id)
+
+    assert result is not None
 
 
-def test_account_user_group_post(created_account_user_group):  # noqa: AAA01
+def test_account_user_group_post(created_account_user_group):
     """Test creating an account user group."""
-    created_account_user_group_data = created_account_user_group
-    assert created_account_user_group_data is not None
+    result = created_account_user_group
 
+    assert result is not None
 
-def test_account_user_group_update(  # noqa: AAA01
+
+def test_account_user_group_update(
     mpt_vendor,
     created_account_user,
     created_user_group,
@@ -173,13 +182,13 @@ def test_account_user_group_update(  # noqa: AAA01
     created_account_user_data = created_account_user()
     users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id)
     update_user_group_data = [{"id": created_user_group.id}]
-    updated_account_user_group = users_obj.groups(user_id=created_account_user_data.id).update(
-        update_user_group_data
-    )
-    assert updated_account_user_group is not None
 
+    result = users_obj.groups(user_id=created_account_user_data.id).update(update_user_group_data)
+
+    assert result is not None
 
-def test_account_user_group_delete(  # noqa: AAA01
+
+def test_account_user_group_delete(
     mpt_vendor,
     created_account_user,
     created_user_group,
@@ -190,4 +199,5 @@ def test_account_user_group_delete(  # noqa: AAA01
     users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id)
     create_user_group_data = {"id": created_user_group.id}
     users_obj.groups(user_id=created_account_user_data.id).create(create_user_group_data)
-    users_obj.groups(user_id=created_account_user_data.id).delete(created_user_group.id)
+
+    users_obj.groups(user_id=created_account_user_data.id).delete(created_user_group.id)  # act