Gmsh file parsing logic defect

[j8xixo12]

Thanks @tigercosmos to point out this issue in https://github.com/solvcon/modmesh/pull/429/files#r1788654979

The logic of paring physical names section and nodes section has a defect, that need to be fixed.

Before closing this issue, the following item should be finish:

• Use const reference as argument in bool Gmsh::is_valid_transition(const std::string s)
• Fix parser logic defect in parsing physical name and nodes section.
• Use constexpr for the version number.
• Maintain a table to save the token string.
• Use emplace in

  modmesh/cpp/modmesh/inout/gmsh.hpp

  Line 211 in 180e911

  m_elems.insert(std::pair{idx, nds_temp});

• remove void in function declaration.

[yungyuc]

Improvement of the gmsh reader can be considered with issue #424.

[yungyuc]

@j8xixo12 could you please make a check-list for all the improvements listed in #429 ?

[j8xixo12]

Check-list for all the improvements in #429

• Use const reference as argument in bool Gmsh::is_valid_transition(const std::string s)
• Fix parser logic defect in parsing physical name and nodes section.
• Use constexpr for the version number.
• Maintain a table to save the token string.
• Use emplace in

  modmesh/cpp/modmesh/inout/gmsh.hpp

  Line 211 in 180e911

  m_elems.insert(std::pair{idx, nds_temp});

• remove void in function declaration.

[yungyuc]

Could you please copy the check list to the issue description (by editing it)? It will be easier to track.

[j8xixo12]

Could you please copy the check list to the issue description (by editing it)? It will be easier to track.

No problem !