Implement feedback

marekweb · marekweb · commit d28f44edd789 · 2020-10-23T16:51:13.000-04:00
diff --git a/src/register-action.ts b/src/register-action.ts
@@ -60,6 +60,7 @@ export const registerFindReplaceAction = (): Subscription => {
                         description,
                         steps: [
                             {
+                                // fileFilter is a required property, but we want it to be a noop.
                                 fileFilter: () => true,
                                 editFile: (path, text) => {
                                     if (!text.includes(findString)) {
@@ -89,7 +90,7 @@ export const registerFindReplaceAction = (): Subscription => {
                     })
             )
             sourcegraph.app.activeWindow!.showNotification(
-                `[**Find-replace changes**](${applyURL}) are ready to preview and apply.<br/><br/><small>${diffStat.changed} changes made.</small>`,
+                `[**Find-replace changes**](${applyURL}) are ready to preview and apply.\n\n<small>${diffStat.changed} changes made.</small>`,
                 sourcegraph.NotificationType.Success
             )
         })

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@ export const registerFindReplaceAction = (): Subscription => {`
`60`	`60`	`description,`
`61`	`61`	`steps: [`
`62`	`62`	`{`
	`63`	`+ // fileFilter is a required property, but we want it to be a noop.`
`63`	`64`	`fileFilter: () => true,`
`64`	`65`	`editFile: (path, text) => {`
`65`	`66`	`if (!text.includes(findString)) {`
`@@ -89,7 +90,7 @@ export const registerFindReplaceAction = (): Subscription => {`
`89`	`90`	`})`
`90`	`91`	`)`
`91`	`92`	`sourcegraph.app.activeWindow!.showNotification(`
`92`		- `[Find-replace changes](${applyURL}) are ready to preview and apply.<br/><br/><small>${diffStat.changed} changes made.</small>`,
	`93`	+ `[Find-replace changes](${applyURL}) are ready to preview and apply.\n\n<small>${diffStat.changed} changes made.</small>`,
`93`	`94`	`sourcegraph.NotificationType.Success`
`94`	`95`	`)`
`95`	`96`	`})`