fix: eslint errors

Author: olafurpg

src/commands/updateCompareRangeCommand.ts

@@ -8,13 +8,13 @@ import { gitReferenceTag } from './switchGitRevisionCommand'
 export async function updateCompareRange(diffs: DiffsTreeDataProvider, commandArguments: any[]): Promise<void> {
     const repositoryName: string = commandArguments[0]
     if (typeof repositoryName !== 'string') {
-        log.error(`updateCompareRange(${JSON.stringify(arguments)})`, `first argument is not a string`)
-        throw new Error(`updateCompareRange(${JSON.stringify(arguments)})`)
+        log.error(`updateCompareRange(${JSON.stringify(commandArguments)})`, 'first argument is not a string')
+        throw new Error(`updateCompareRange(${JSON.stringify(commandArguments)})`)
     }
     const kind: 'base' | 'head' = commandArguments[1]
     if (kind !== 'base' && kind !== 'head') {
-        log.error(`updateCompareRange(${JSON.stringify(arguments)})`, `second argument is not 'base' or 'head'`)
-        throw new Error(`updateCompareRange(${JSON.stringify(arguments)})`)
+        log.error(`updateCompareRange(${JSON.stringify(commandArguments)})`, "second argument is not 'base' or 'head'")
+        throw new Error(`updateCompareRange(${JSON.stringify(commandArguments)})`)
     }
     const quick = new SourcegraphQuickPick(diffs.fs)
     quick.pick.title = 'Search for a git branch, git tag or a git commit'

src/extension.ts

@@ -99,11 +99,7 @@ export function activate(context: vscode.ExtensionContext): void {
     for (const color of ['green', 'orange', 'red']) {
         for (const index of [1, 2, 3]) {
             const name = `extension.${color}${index}`
-            context.subscriptions.push(
-                vscode.commands.registerCommand(name, () => {
-                    log.appendLine(`COMMAND ${name}`)
-                })
-            )
+            context.subscriptions.push(vscode.commands.registerCommand(name, () => {}))
         }
     }
     context.subscriptions.push(
@@ -136,8 +132,8 @@ export function activate(context: vscode.ExtensionContext): void {
         )
     )
     context.subscriptions.push(
-        vscode.commands.registerCommand('extension.updateCompareRange', (...commandArguments) => {
-            updateCompareRange(diffsTreeProvider, commandArguments)
+        vscode.commands.registerCommand('extension.updateCompareRange', async (...commandArguments) => {
+            await updateCompareRange(diffsTreeProvider, commandArguments)
         })
     )
     context.subscriptions.push(

src/file-system/DiffsTreeDataProvider.ts

@@ -60,7 +60,7 @@ export class DiffsTreeDataProvider implements vscode.TreeDataProvider<string> {
                         label: `${node.kind[0].toUpperCase()}${node.kind.slice(1)}: ${
                             this.compareRange(node)[node.kind]
                         }`,
-                        resourceUri: vscode.Uri.parse(`sourcegraph://host/.gitignore`),
+                        resourceUri: vscode.Uri.parse('sourcegraph://host/.gitignore'),
                         tooltip: `Update ${node.kind} revision`,
                         command: {
                             command: 'extension.updateCompareRange',
@@ -276,7 +276,6 @@ export class DiffsTreeDataProvider implements vscode.TreeDataProvider<string> {
 
         const fileStats = fileDiffStats(uri, fileDiff, comparison)
         const label = uri.treeItemLabel(parent)
-        log.appendLine(`label=${label} contextValue=${fileStats.contextValue}`)
         return {
             id: childNode.toString(),
             label,
@@ -316,7 +315,7 @@ function fileDiffStats(
             }
         }
     }
-    let parts: string[] = []
+    const parts: string[] = []
     const addCount = (what: string, count: number): void => {
         if (count < 1) {
             return
@@ -397,8 +396,8 @@ class DiffNode {
     }
     private static fromAny(any: any): DiffNode {
         const repositoryName = any?.repositoryName
-        if (typeof repositoryName != 'string') {
-            throw new Error(`DiffUri.fromAny() missing repositoryName`)
+        if (typeof repositoryName !== 'string') {
+            throw new TypeError('DiffUri.fromAny() missing repositoryName')
         }
         let kind: DiffNodeKind | undefined
         if (any?.kind === 'base' || any?.kind === 'head' || any?.kind === 'commits' || any?.kind === 'files') {

src/file-system/FilesTreeDataProvider.ts

@@ -91,8 +91,11 @@ export class FilesTreeDataProvider implements vscode.TreeDataProvider<string> {
             }
             return ancestor
         } catch (error) {
-            log.error(`getParent(${uriString})`, error)
-            throw error
+            log.error(`getParent(${uriString || 'undefined'})`, error)
+            if (error instanceof Error) {
+                throw error
+            }
+            return undefined
         }
     }
 
@@ -113,7 +116,10 @@ export class FilesTreeDataProvider implements vscode.TreeDataProvider<string> {
             return directChildren
         } catch (error) {
             log.error(`getChildren(${uriString || ''})`, error)
-            throw error
+            if (error instanceof Error) {
+                throw error
+            }
+            return undefined
         }
     }
 
@@ -146,8 +152,11 @@ export class FilesTreeDataProvider implements vscode.TreeDataProvider<string> {
             return this.newTreeItem(uri, parentUri ? SourcegraphUri.parse(parentUri) : undefined, 0)
         } catch (error) {
             log.error(`getTreeItem(${uriString})`, error)
-            throw error
+            if (error instanceof Error) {
+                throw error
+            }
         }
+        return {}
     }
 
     private async didFocusString(