add AuthMode to config

- AuthModeAccessToken and AuthModeOAuth
- And check for CI and required AuthModeAccessToken

Author: burmudar

cmd/src/main.go

@@ -82,6 +82,7 @@ var (
 
 	errConfigMerge                 = errors.New("when using a configuration file, zero or all environment variables must be set")
 	errConfigAuthorizationConflict = errors.New("when passing an 'Authorization' additional headers, SRC_ACCESS_TOKEN must never be set")
+	errCIAccessTokenRequired       = errors.New("SRC_ACCESS_TOKEN must be set in CI")
 )
 
 // commands contains all registered subcommands.
@@ -122,6 +123,20 @@ type config struct {
 	ConfigFilePath    string
 }
 
+type AuthMode int
+
+const (
+	AuthModeOAuth AuthMode = iota
+	AuthModeAccessToken
+)
+
+func (c *config) AuthMode() AuthMode {
+	if c.AccessToken != "" {
+		return AuthModeAccessToken
+	}
+	return AuthModeOAuth
+}
+
 // apiClient returns an api.Client built from the configuration.
 func (c *config) apiClient(flags *api.Flags, out io.Writer) api.Client {
 	opts := api.ClientOpts{
@@ -260,9 +275,18 @@ func readConfig() (*config, error) {
 
 	cfg.Endpoint = cleanEndpoint(cfg.Endpoint)
 
+	if isCI() && cfg.AccessToken == "" {
+		return nil, errCIAccessTokenRequired
+	}
+
 	return &cfg, nil
 }
 
+func isCI() bool {
+	value, ok := os.LookupEnv("CI")
+	return ok && value != ""
+}
+
 func cleanEndpoint(urlStr string) string {
 	return strings.TrimSuffix(urlStr, "/")
 }

cmd/src/main_test.go

@@ -30,6 +30,7 @@ func TestReadConfig(t *testing.T) {
 	tests := []struct {
 		name         string
 		fileContents *config
+		envCI        string
 		envToken     string
 		envFooHeader string
 		envHeaders   string
@@ -283,6 +284,24 @@ func TestReadConfig(t *testing.T) {
 			envHeaders:  "Authorization:Bearer",
 			wantErr:     errConfigAuthorizationConflict.Error(),
 		},
+		{
+			name:    "CI requires access token",
+			envCI:   "1",
+			wantErr: errCIAccessTokenRequired.Error(),
+		},
+		{
+			name:  "CI allows access token from config file",
+			envCI: "1",
+			fileContents: &config{
+				Endpoint:    "https://example.com/",
+				AccessToken: "deadbeef",
+			},
+			want: &config{
+				Endpoint:          "https://example.com",
+				AccessToken:       "deadbeef",
+				AdditionalHeaders: map[string]string{},
+			},
+		},
 	}
 
 	for _, test := range tests {
@@ -297,6 +316,7 @@ func TestReadConfig(t *testing.T) {
 			setEnv("SRC_ACCESS_TOKEN", test.envToken)
 			setEnv("SRC_ENDPOINT", test.envEndpoint)
 			setEnv("SRC_PROXY", test.envProxy)
+			setEnv("CI", test.envCI)
 
 			tmpDir := t.TempDir()
 			testHomeDir = tmpDir
@@ -345,3 +365,17 @@ func TestReadConfig(t *testing.T) {
 		})
 	}
 }
+
+func TestConfigAuthMode(t *testing.T) {
+	t.Run("oauth when access token is empty", func(t *testing.T) {
+		if got := (&config{}).AuthMode(); got != AuthModeOAuth {
+			t.Fatalf("AuthMode() = %v, want %v", got, AuthModeOAuth)
+		}
+	})
+
+	t.Run("access token when configured", func(t *testing.T) {
+		if got := (&config{AccessToken: "token"}).AuthMode(); got != AuthModeAccessToken {
+			t.Fatalf("AuthMode() = %v, want %v", got, AuthModeAccessToken)
+		}
+	})
+}