From 65ca47c2e2b340d971a5497b51293f71952104ee Mon Sep 17 00:00:00 2001 From: Michael Bahr Date: Thu, 30 Apr 2026 07:23:15 +0000 Subject: [PATCH 1/4] Agentic Batch Change --- cmd/src/batch_common.go | 4 ++++ lib/batches/schema/batch_spec_stringdata.go | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/cmd/src/batch_common.go b/cmd/src/batch_common.go index e294347dcf..59b462ba96 100644 --- a/cmd/src/batch_common.go +++ b/cmd/src/batch_common.go @@ -373,6 +373,10 @@ func executeBatchSpec(ctx context.Context, opts executeBatchSpecOpts) (err error } execUI.ParsingBatchSpecSuccess() + if batchSpec.Version == 3 { + return errors.New("batch spec version 3 is not supported for local execution, please run server-side") + } + execUI.ResolvingNamespace() namespace, err := svc.ResolveNamespace(ctx, opts.flags.namespace) if err != nil { diff --git a/lib/batches/schema/batch_spec_stringdata.go b/lib/batches/schema/batch_spec_stringdata.go index 6d412a0a33..1123970faf 100644 --- a/lib/batches/schema/batch_spec_stringdata.go +++ b/lib/batches/schema/batch_spec_stringdata.go @@ -15,7 +15,7 @@ const BatchSpecJSON = `{ "version": { "type": "number", "description": "The version of the batch spec schema. Defaults to 1.", - "enum": [1, 2] + "enum": [1, 2, 3] }, "name": { "type": "string", From 7e5c19047758ebdfbebbb97a5d80e18b620b2da2 Mon Sep 17 00:00:00 2001 From: bahrmichael Date: Thu, 30 Apr 2026 09:33:24 +0200 Subject: [PATCH 2/4] fix --- .gitignore | 1 + internal/batches/service/service.go | 2 +- internal/batches/service/service_test.go | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 2d73227cc4..0091b7092a 100644 --- a/.gitignore +++ b/.gitignore @@ -14,3 +14,4 @@ bazel-zoekt bazel-src-cli .DS_Store samples +.amp diff --git a/internal/batches/service/service.go b/internal/batches/service/service.go index a21de45903..761c09654c 100644 --- a/internal/batches/service/service.go +++ b/internal/batches/service/service.go @@ -526,7 +526,7 @@ func validateMount(batchSpecDir string, spec *batcheslib.BatchSpec) error { return nil } -const exampleSpecTmpl = `version: 2 # Use the latest schema version +const exampleSpecTmpl = `version: 3 # Use the latest schema version name: NAME-OF-YOUR-BATCH-CHANGE description: DESCRIPTION-OF-YOUR-BATCH-CHANGE diff --git a/internal/batches/service/service_test.go b/internal/batches/service/service_test.go index da877edc33..7034ff7da6 100644 --- a/internal/batches/service/service_test.go +++ b/internal/batches/service/service_test.go @@ -268,12 +268,12 @@ some-new-field: Foo bar { name: "supported version", rawSpec: ` -version: 2 +version: 3 name: test-spec description: A test spec `, - expectedSpec: &batcheslib.BatchSpec{Version: 2, Name: "test-spec", Description: "A test spec"}, + expectedSpec: &batcheslib.BatchSpec{Version: 3, Name: "test-spec", Description: "A test spec"}, }, { name: "unsupported version", @@ -282,7 +282,7 @@ version: 99 name: test-spec description: A test spec `, - expectedErr: errors.New("parsing batch spec: version: version must be one of the following: 1, 2"), + expectedErr: errors.New("parsing batch spec: version: version must be one of the following: 1, 2, 3"), }, { name: "mount absolute file", From d5c74a4bc12e84fd9c5352604ed07bafbd321760 Mon Sep 17 00:00:00 2001 From: Michael Bahr <1830132+bahrmichael@users.noreply.github.com> Date: Thu, 30 Apr 2026 09:40:04 +0200 Subject: [PATCH 3/4] Update service.go --- internal/batches/service/service.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/batches/service/service.go b/internal/batches/service/service.go index 761c09654c..a21de45903 100644 --- a/internal/batches/service/service.go +++ b/internal/batches/service/service.go @@ -526,7 +526,7 @@ func validateMount(batchSpecDir string, spec *batcheslib.BatchSpec) error { return nil } -const exampleSpecTmpl = `version: 3 # Use the latest schema version +const exampleSpecTmpl = `version: 2 # Use the latest schema version name: NAME-OF-YOUR-BATCH-CHANGE description: DESCRIPTION-OF-YOUR-BATCH-CHANGE From 7e169985b1d2c7153db87ed809833fc2803d09c6 Mon Sep 17 00:00:00 2001 From: Michael Bahr <1830132+bahrmichael@users.noreply.github.com> Date: Thu, 30 Apr 2026 09:40:29 +0200 Subject: [PATCH 4/4] Update service_test.go --- internal/batches/service/service_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/batches/service/service_test.go b/internal/batches/service/service_test.go index 7034ff7da6..bdff83acfc 100644 --- a/internal/batches/service/service_test.go +++ b/internal/batches/service/service_test.go @@ -268,12 +268,12 @@ some-new-field: Foo bar { name: "supported version", rawSpec: ` -version: 3 +version: 2 name: test-spec description: A test spec `, - expectedSpec: &batcheslib.BatchSpec{Version: 3, Name: "test-spec", Description: "A test spec"}, + expectedSpec: &batcheslib.BatchSpec{Version: 2, Name: "test-spec", Description: "A test spec"}, }, { name: "unsupported version",