From 75cd014c33e69864baa81253400dbef6a9b2e2ef Mon Sep 17 00:00:00 2001
From: Lee Leahy <lpleahyjr@gmail.com>
Date: Sat, 21 Feb 2026 07:14:45 -1000
Subject: [PATCH] Test to catch index bug in sempFirstByte, verifies all
 parsers called

---
 examples/Mixed_Parser/Parser_Tests.ino | 47 +++++++++++++++++++++-----
 1 file changed, 38 insertions(+), 9 deletions(-)

diff --git a/examples/Mixed_Parser/Parser_Tests.ino b/examples/Mixed_Parser/Parser_Tests.ino
index a2873e3..74017e1 100644
--- a/examples/Mixed_Parser/Parser_Tests.ino
+++ b/examples/Mixed_Parser/Parser_Tests.ino
@@ -126,19 +126,20 @@ typedef struct _DataStream
 {
     size_t length;
     const uint8_t *data;
+    int parser;
 } DataStream;
 
-#define DATA_STREAM_INIT(x, extraBytes)     {sizeof(x) - extraBytes, &x[0]}
+#define DATA_STREAM_INIT(x, extraBytes, parser)     {sizeof(x) - extraBytes, &x[0], parser}
 const DataStream dataStream[] =
 {
-    DATA_STREAM_INIT(nmea_1, 1),
-    DATA_STREAM_INIT(ublox_1, 0),
-    DATA_STREAM_INIT(nmea_2, 1),
-    DATA_STREAM_INIT(ublox_2, 0),
-    DATA_STREAM_INIT(nmea_3, 1),
-    DATA_STREAM_INIT(ublox_3, 0),
-    DATA_STREAM_INIT(nmea_4, 1),
-    DATA_STREAM_INIT(ublox_4, 0)
+    DATA_STREAM_INIT(nmea_1, 1, NMEA_PARSER_INDEX),
+    DATA_STREAM_INIT(ublox_1, 0, UBLOX_PARSER_INDEX),
+    DATA_STREAM_INIT(nmea_2, 1, NMEA_PARSER_INDEX),
+    DATA_STREAM_INIT(ublox_2, 0, UBLOX_PARSER_INDEX),
+    DATA_STREAM_INIT(nmea_3, 1, NMEA_PARSER_INDEX),
+    DATA_STREAM_INIT(ublox_3, 0, UBLOX_PARSER_INDEX),
+    DATA_STREAM_INIT(nmea_4, 1, NMEA_PARSER_INDEX),
+    DATA_STREAM_INIT(ublox_4, 0, UBLOX_PARSER_INDEX)
 };
 
 #define DATA_STREAM_ENTRIES     (sizeof(dataStream) / sizeof(dataStream[0]))
@@ -151,7 +152,9 @@ uint8_t buffer[3099];
 int byteOffset;
 int dataIndex;
 uint32_t dataOffset;
+int expectedParser;
 SEMP_PARSE_STATE *parse;
+volatile int parserMessageCounts[2];
 
 //------------------------------------------------------------------------------
 // Test routines
@@ -192,12 +195,31 @@ void parserTests()
     sempDebugOutputEnable(parse, output);
     for (dataIndex = 0; dataIndex < DATA_STREAM_ENTRIES; dataIndex++)
     {
+        int previousCount;
+
+        expectedParser = dataStream[dataIndex].parser;
+        previousCount = parserMessageCounts[expectedParser];
         for (byteOffset = 0; byteOffset < dataStream[dataIndex].length; byteOffset++)
         {
             // Update the parser state based on the incoming byte
             sempParseNextByte(parse, dataStream[dataIndex].data[byteOffset]);
             dataOffset += 1;
         }
+
+        // Validate that the message was properly parsed
+        if (parserMessageCounts[expectedParser] == previousCount)
+        {
+            sempPrintString(output, "dataOffset: ");
+            sempPrintDecimalI32Ln(output, dataOffset);
+
+            sempPrintString(output, "byteOffset: ");
+            sempPrintDecimalI32Ln(output, byteOffset);
+
+            sempPrintString(output, "ERROR: ");
+            sempPrintString(output, parserTable[expectedParser]->parserName);
+            sempPrintStringLn(output, " failed to process message!");
+            reportFatalError("Bug in parser or sempFirstByte!");
+        }
     }
 
     // Done parsing the data
@@ -219,6 +241,9 @@ void processMessage(SEMP_PARSE_STATE *parse, uint16_t type)
     switch (type) // Index into parserTable array
     {
         case NMEA_PARSER_INDEX:
+            // Account for this message
+            parserMessageCounts[type] = parserMessageCounts[type] + 1;
+
             // Determine the raw data stream offset
             offset = dataOffset + 2 - parse->length;
             byteIndex = byteOffset + 2 - parse->length;
@@ -238,6 +263,10 @@ void processMessage(SEMP_PARSE_STATE *parse, uint16_t type)
             break;
 
         case UBLOX_PARSER_INDEX:
+            // Account for this message
+            parserMessageCounts[type] = parserMessageCounts[type] + 1;
+
+            // Determine the raw data stream offset
             offset = dataOffset + 1 - parse->length;
             sempPrintString(output, "Valid u-blox message: ");
             sempPrintDecimalI32(output, parse->length);