Fails if `git` is not found

[matthiasbeyer]

bikeshed fails if git cannot be found:

FileNotFoundError: [Errno 2] No such file or directory: 'git'

[tabatkins]

Lol, that certainly shows the assumptions I work under; nobody has ever reported this before. ^_^

Can you give me the full error message, so I can see where I'm invoking git unconditionally?

[matthiasbeyer]

Meh, I already closed that terminal and removed the call from my CI pipeline (didn't even commit because if these basic things don't work, you know...)

I also found that bikeshed tries to call pip, which instantly got me to remove it from my system (where pip is not available, because NixOS).

[tabatkins]

Okay, I see the issue, I'm checking for CalledProcessError in all the locations I invoke git, which is thrown if the process exits with an error, but it turns out that if git doesn't exist at all it throws FileNotFound. I'll fix.

I also found that bikeshed tries to call pip, which instantly got me to remove it from my system (where pip is not available, because NixOS).

How do you install Bikeshed on NixOS, when it has requirements from pypi? (The pip call is just pip check, to verify that all the required packages are installed.)

[matthiasbeyer]

How do you install Bikeshed on NixOS, when it has requirements from pypi? (The pip call is just pip check, to verify that all the required packages are installed

Via the package manager of course. bikeshed is packaged in nixpkgs.

IMO its not the task of the software to check whether its dependencies are present, that's the task of the package manager!