Branch settings Validate() is never called

[xfischer]

Describe the bug
When I override a branch setting using

public override ValidationResult Validate()

[EDIT] the base Validate() method is never called.

Here is a full example (taken from the docs) :

public class AddSettings : CommandSettings
{
    [CommandArgument(0, "[PROJECT]")]
    public string Project { get; set; }

    // This is never called
    public override ValidationResult Validate() => ValidationResult.Success();
}

public class AddPackageSettings : AddSettings
{
    [CommandArgument(0, "<PACKAGE_NAME>")]
    public string PackageName { get; set; }

    [CommandOption("-v|--version <VERSION>")]
    public string Version { get; set; }

    // This one is called
    public override ValidationResult Validate() => ValidationResult.Success();
}

public class AddReferenceSettings : AddSettings
{
    [CommandArgument(0, "<PROJECT_REFERENCE>")]
    public string ProjectReference { get; set; }

    // This one is called
    public override ValidationResult Validate() => ValidationResult.Success();
}

The problem is that I don't want to call base.Validate() for every child command as it complicates future additions to the project: every new setting would have to remember to call base.Validate().

I don't know if this is because it's declared as a branch or because it has child settings.

[kumaraashish435]

Hi, I reproduced this issue locally.

I implemented a ValidateRecursive() method in CommandSettings that calls Validate() from base classes up to the derived class automatically.
I added a unit test (ValidateRecursiveTests) to verify that the base Validate() is now called without requiring child classes to call base.Validate().

Please let me know if this approach suitable to fix this issue so that i can open a PR.
here is my branch link
[https://github.com/kumaraashish435/spectre.console/commit/ed85614b8334075c2fd5b3cf3b72efc35bb1b03c]

[xfischer]

@kumaraashish435 thanks! Seems you are testing the actual behaviour, not the fix.