From 3d78f38e8206e45223edbb0eed96be22a175d0c1 Mon Sep 17 00:00:00 2001 From: Pham Quang Nghi <133509274+nghiphaam@users.noreply.github.com> Date: Tue, 21 Apr 2026 12:44:17 +0700 Subject: [PATCH 1/2] close resp2.Body and out before Fatal calls --- src/cmd/update.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/cmd/update.go b/src/cmd/update.go index 3900cdde07..4b4abcd3ac 100644 --- a/src/cmd/update.go +++ b/src/cmd/update.go @@ -57,18 +57,23 @@ func Update(currentVersion string) bool { resp2, err := http.Get(assetURL) if err != nil { + out.Close() spinner.Fail("Failed to download Spicetify") utils.Fatal(err) } - defer resp2.Body.Close() if resp2.StatusCode != http.StatusOK { + resp2.Body.Close() + out.Close() spinner.Fail("Failed to download Spicetify") utils.Fatal(fmt.Errorf("unexpected HTTP status: %s for %s", resp2.Status, assetURL)) } + defer resp2.Body.Close() + _, err = io.Copy(out, resp2.Body) if err != nil { + resp2.Body.Close() spinner.Fail("Failed to download Spicetify") utils.Fatal(err) } From 05ef30efec400e7f4ee704a47ec0ee39db04866b Mon Sep 17 00:00:00 2001 From: Pham Quang Nghi <133509274+nghiphaam@users.noreply.github.com> Date: Tue, 21 Apr 2026 12:52:05 +0700 Subject: [PATCH 2/2] add out.Close() in io.Copy error path --- src/cmd/update.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cmd/update.go b/src/cmd/update.go index 4b4abcd3ac..8b1117fc56 100644 --- a/src/cmd/update.go +++ b/src/cmd/update.go @@ -74,6 +74,7 @@ func Update(currentVersion string) bool { _, err = io.Copy(out, resp2.Body) if err != nil { resp2.Body.Close() + out.Close() spinner.Fail("Failed to download Spicetify") utils.Fatal(err) }