Skip to content

Commit cbfe46e

Browse files
fixing lints
1 parent 0676acf commit cbfe46e

2 files changed

Lines changed: 19 additions & 31 deletions

File tree

splunklib/ai/engines/langchain.py

Lines changed: 16 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -280,12 +280,12 @@ async def awrap_tool_call(
280280

281281
if resp.name.startswith(AGENT_PREFIX):
282282
resp.artifact = SubagentFailureResult(
283-
str(resp.content)
284-
) # pyright: ignore[reportUnknownArgumentType]
283+
str(resp.content) # pyright: ignore[reportUnknownArgumentType]
284+
)
285285
else:
286286
resp.artifact = ToolFailureResult(
287-
str(resp.content)
288-
) # pyright: ignore[reportUnknownArgumentType]
287+
str(resp.content) # pyright: ignore[reportUnknownArgumentType]
288+
)
289289

290290
return resp
291291

@@ -971,9 +971,9 @@ async def _sdk_handler(request: ToolRequest) -> ToolResponse:
971971
lc_request = _convert_tool_request_to_lc(request, original_request)
972972
result = await handler(lc_request)
973973
sdk_result = _convert_tool_message_from_lc(result)
974-
assert isinstance(
975-
sdk_result, ToolMessage
976-
), "Expected tool response from tool middleware handler"
974+
assert isinstance(sdk_result, ToolMessage), (
975+
"Expected tool response from tool middleware handler"
976+
)
977977
return ToolResponse(sdk_result.result)
978978

979979
return _sdk_handler
@@ -991,9 +991,9 @@ async def _sdk_handler(
991991
lc_request = _convert_subagent_request_to_lc(request, original_request)
992992
result = await handler(lc_request)
993993
sdk_result = _convert_tool_message_from_lc(result)
994-
assert isinstance(
995-
sdk_result, SubagentMessage
996-
), "Expected subagent response from subagent middleware handler"
994+
assert isinstance(sdk_result, SubagentMessage), (
995+
"Expected subagent response from subagent middleware handler"
996+
)
997997
return SubagentResponse(sdk_result.result)
998998

999999
return _sdk_handler
@@ -1186,18 +1186,16 @@ def _convert_tool_message_from_lc(
11861186
)
11871187
case LC_ToolMessage():
11881188
# If this is reached, we likely passed an invalid tool name to LangChain.
1189-
assert (
1190-
message.name is not None
1191-
), "LangChain responded with a nameless tool call"
1189+
assert message.name is not None, (
1190+
"LangChain responded with a nameless tool call"
1191+
)
11921192

11931193
if message.name.startswith(TOOL_STRATEGY_TOOL_PREFIX):
11941194
return StructuredOutputMessage(
11951195
name=message.name.removeprefix(TOOL_STRATEGY_TOOL_PREFIX),
11961196
call_id=message.tool_call_id,
11971197
status=message.status,
1198-
content=str(
1199-
message.content
1200-
), # pyright: ignore[reportUnknownArgumentType]
1198+
content=str(message.content), # pyright: ignore[reportUnknownArgumentType]
12011199
)
12021200

12031201
assert isinstance(message.artifact, ToolResult) or isinstance(
@@ -1357,9 +1355,7 @@ async def _tool_call(
13571355
except ToolException as e:
13581356
raise LC_ToolException(*e.args) from e
13591357
except LC_ToolException:
1360-
assert (
1361-
False
1362-
), ( # noqa: PT015
1358+
assert False, ( # noqa: PT015
13631359
"ToolException from LangChain should not be raised in tool.func"
13641360
)
13651361

@@ -1650,9 +1646,7 @@ def _get_approximate_token_counter(model: BaseChatModel) -> LC_TokenCounter:
16501646
# NOTE: This is adapted from the backend provider library
16511647
# 3.3 was estimated in an offline experiment, comparing with Claude's token-counting
16521648
# API: https://platform.claude.com/docs/en/build-with-claude/token-counting
1653-
if (
1654-
model._llm_type == ANTHROPIC_CHAT_MODEL_TYPE
1655-
): # pyright: ignore[reportPrivateUsage]
1649+
if model._llm_type == ANTHROPIC_CHAT_MODEL_TYPE: # pyright: ignore[reportPrivateUsage]
16561650
return partial(count_tokens_approximately, chars_per_token=3.3)
16571651
return count_tokens_approximately
16581652

tests/unit/ai/test_default_limits.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,9 @@ def test_default_values_match_constants(self) -> None:
7575
token = next(m for m in mw if isinstance(m, TokenLimitMiddleware))
7676
step = next(m for m in mw if isinstance(m, StepLimitMiddleware))
7777
timeout = next(m for m in mw if isinstance(m, TimeoutLimitMiddleware))
78-
assert (
79-
token._limit == DEFAULT_TOKEN_LIMIT
80-
) # pyright: ignore[reportPrivateUsage]
78+
assert token._limit == DEFAULT_TOKEN_LIMIT # pyright: ignore[reportPrivateUsage]
8179
assert step._limit == DEFAULT_STEP_LIMIT # pyright: ignore[reportPrivateUsage]
82-
assert (
83-
timeout._seconds == DEFAULT_TIMEOUT_SECONDS
84-
) # pyright: ignore[reportPrivateUsage]
80+
assert timeout._seconds == DEFAULT_TIMEOUT_SECONDS # pyright: ignore[reportPrivateUsage]
8581

8682
def test_user_token_limit_suppresses_default(self) -> None:
8783
agent = _make_agent(middleware=[TokenLimitMiddleware(50_000)])
@@ -153,9 +149,7 @@ async def test_deadline_is_none_before_first_invoke(self) -> None:
153149

154150
async def test_timeout_fires_when_deadline_exceeded(self) -> None:
155151
mw = TimeoutLimitMiddleware(60.0)
156-
mw._deadline = (
157-
monotonic() - 1.0
158-
) # pyright: ignore[reportPrivateUsage] # already in the past
152+
mw._deadline = monotonic() - 1.0 # pyright: ignore[reportPrivateUsage] # already in the past
159153

160154
state = AgentState(
161155
messages=[],

0 commit comments

Comments
 (0)