Merge branch 'wip-pg-extension' of https://github.com/sqliteai/sqlite-sync into wip-pg-extension

Author: marcobambini

.vscode/launch.json

@@ -15,6 +15,21 @@
           "description": "Enable pretty-printing for gdb",
           "text": "-enable-pretty-printing",
           "ignoreFailures": true
+        },
+        {
+          "description": "Add PostgreSQL source dir",
+          "text": "dir /usr/src/postgresql-16/src",
+          "ignoreFailures": true
+        },
+        {
+          "description": "Map Postgres build paths to source",
+          "text": "set substitute-path /build/src /usr/src/postgresql-16/src",
+          "ignoreFailures": true
+        },
+        {
+          "description": "Map Postgres build paths (relative) to source",
+          "text": "set substitute-path ./build/src /usr/src/postgresql-16/src",
+          "ignoreFailures": true
         }
       ]
     }

docker/postgresql/Dockerfile.debug

@@ -1,13 +1,29 @@
 # PostgreSQL Docker image with CloudSync extension (debug build)
 FROM postgres:16
 
-# Install build dependencies
+# Install build dependencies and debug symbols
 RUN apt-get update && apt-get install -y \
+    ca-certificates \
+    gnupg \
+    wget \
+    && . /etc/os-release \
+    && echo "deb http://apt.postgresql.org/pub/repos/apt ${VERSION_CODENAME}-pgdg main" > /etc/apt/sources.list.d/pgdg.list \
+    && echo "deb-src http://apt.postgresql.org/pub/repos/apt ${VERSION_CODENAME}-pgdg main" > /etc/apt/sources.list.d/pgdg-src.list \
+    && wget -qO- https://www.postgresql.org/media/keys/ACCC4CF8.asc | gpg --dearmor -o /etc/apt/trusted.gpg.d/postgresql.gpg \
+    && echo "deb http://deb.debian.org/debian-debug ${VERSION_CODENAME}-debug main" > /etc/apt/sources.list.d/debian-debug.list \
+    && echo "deb-src http://deb.debian.org/debian ${VERSION_CODENAME} main" > /etc/apt/sources.list.d/debian-src.list \
+    && apt-get update && apt-get install -y \
     build-essential \
+    dpkg-dev \
     gdb \
     postgresql-server-dev-16 \
+    postgresql-16-dbgsym \
     git \
     make \
+    && apt-get source postgresql-16 \
+    && mkdir -p /usr/src/postgresql-16 \
+    && srcdir="$(find . -maxdepth 1 -type d -name 'postgresql-16*' | head -n 1)" \
+    && if [ -n "$srcdir" ]; then cp -a "$srcdir"/. /usr/src/postgresql-16/; fi \
     && rm -rf /var/lib/apt/lists/*
 
 # Create directory for extension source

src/postgresql/cloudsync_postgresql.c

@@ -72,23 +72,40 @@ void _PG_init(void) {
     // Extension initialization
     // SPI will be connected per-function call
     elog(DEBUG1, "CloudSync extension loading");
-
+    
     // Initialize memory debugger (NOOP in production)
     cloudsync_memory_init(1);
-
+    
     // load config, if exists
     cloudsync_context *ctx = get_cloudsync_context();
-    if (cloudsync_config_exists(NULL)) {
-        if (cloudsync_context_init(ctx) == NULL) {
-            ereport(ERROR,
+    
+    int spi_rc = SPI_connect();
+    if (spi_rc != SPI_OK_CONNECT) {
+        ereport(ERROR,
                 (errcode(ERRCODE_INTERNAL_ERROR),
-                 errmsg("An error occurred while trying to initialize context")));
-
+                 errmsg("SPI_connect failed: %d", spi_rc)));
+    }
+    
+    PG_TRY();
+    {
+        if (cloudsync_config_exists(ctx)) {
+            if (cloudsync_context_init(ctx) == NULL) {
+                ereport(ERROR,
+                        (errcode(ERRCODE_INTERNAL_ERROR),
+                         errmsg("An error occurred while trying to initialize context")));
+            }
+            
+            // make sure to update internal version to current version
+            dbutils_settings_set_key_value(ctx, CLOUDSYNC_KEY_LIBVERSION, CLOUDSYNC_VERSION);
         }
-        
-        // make sure to update internal version to current version
-        dbutils_settings_set_key_value(ctx, CLOUDSYNC_KEY_LIBVERSION, CLOUDSYNC_VERSION);
+        SPI_finish();
+    }
+    PG_CATCH();
+    {
+        SPI_finish();
+        PG_RE_THROW();
     }
+    PG_END_TRY();
 }
 
 void _PG_fini(void) {