Py_SIZE() was misused for dict.

serhiy-storchaka · serhiy-storchaka · commit 3023ebb43f76 · 2017-01-13T08:34:34.000+02:00
diff --git a/Modules/_json.c b/Modules/_json.c
@@ -1609,7 +1609,7 @@ encoder_listencode_dict(PyEncoderObject *s, _PyAccu *acc,
         if (open_dict == NULL || close_dict == NULL || empty_dict == NULL)
             return -1;
     }
-    if (Py_SIZE(dct) == 0)
+    if (PyDict_Size(dct) == 0)  /* Fast path */
         return _PyAccu_Accumulate(acc, empty_dict);
 
     if (s->markers != Py_None) {

Original file line number	Diff line number	Diff line change
`@@ -1609,7 +1609,7 @@ encoder_listencode_dict(PyEncoderObject s, _PyAccu acc,`
`1609`	`1609`	`if (open_dict == NULL \|\| close_dict == NULL \|\| empty_dict == NULL)`
`1610`	`1610`	`return -1;`
`1611`	`1611`	`}`
`1612`		`- if (Py_SIZE(dct) == 0)`
	`1612`	`+ if (PyDict_Size(dct) == 0) /* Fast path */`
`1613`	`1613`	`return _PyAccu_Accumulate(acc, empty_dict);`
`1614`	`1614`
`1615`	`1615`	`if (s->markers != Py_None) {`