fix: Use importlib.metadata instead of pkg_resources#416
Open
riddell-stan wants to merge 5 commits intomainfrom
Open
fix: Use importlib.metadata instead of pkg_resources#416riddell-stan wants to merge 5 commits intomainfrom
riddell-stan wants to merge 5 commits intomainfrom
Conversation
riddell-stan
force-pushed
the
feature/pkg-resources-gone
branch
2 times, most recently
from
b1ba4b9 to
3845b1e
Compare
setuptools 82.0.0 removes pkg_resources, breaking this software. This patch replaces pkg_resources with the recommended importlib.metadata. PyStan was using pkg_resources for compatibility with versions older than Python 3.12, versions which should use importlib.metadata instead (see https://docs.python.org/3/library/importlib.metadata.html#entry-points). Also updates pyproject.toml to require Python ≥3.12. Older versions will need to use setuptools < 82.0.0. See pypa/setuptools#5174 for tips on how to deal with broken builds. Also uncap the version of pysimdjson. The package does not seem to use semantic versioning and users will likely want to use wheels that are (only) being built for newer Pythons.
riddell-stan
force-pushed
the
feature/pkg-resources-gone
branch
4 times, most recently
from
70388a1 to
4d1050b
Compare
riddell-stan
force-pushed
the
feature/pkg-resources-gone
branch
from
4d1050b to
6ff0dda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools 82.0.0 removes pkg_resources, breaking this software. This patch replaces pkg_resources with the recommended importlib.metadata.
PyStan was using pkg_resources for compatibility with versions older than Python 3.12, versions which should use importlib.metadata instead (see https://docs.python.org/3/library/importlib.metadata.html#entry-points).
Also updates pyproject.toml to require Python ≥3.12. Older versions will need to use setuptools < 82.0.0. See pypa/setuptools#5174 for tips on how to deal with broken builds.
Also uncap the version of pysimdjson. The package does not seem to use semantic versioning and users will likely want to use wheels that are (only) being built for newer Pythons.