You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Observe Static Analysis (typecheck) fails with TypeScript errors
Expected Behavior
TypeScript typecheck passes with 0 errors.
Actual Behavior
Multiple TypeScript errors in `client/` test files because the UAT fix (commit `91bc6fc`) added `sourceEntityTitle` as a required field to `DiaryEntrySummary` and `DiaryEntryDetail` types in `@cornerstone/shared`, but the QA integration test mock objects were not updated.
Affected files:
`client/src/lib/diaryApi.test.ts` — mock objects missing `sourceEntityTitle` field
BUG: TypeScript type errors in diary unit tests after sourceEntityTitle added to shared types
Severity: Major
Component: QA Integration Tests / Shared Types
Found in: CI Static Analysis job on PR #846
Steps to Reproduce
fix/836-845-diary-uat-fixesExpected Behavior
TypeScript typecheck passes with 0 errors.
Actual Behavior
Multiple TypeScript errors in `client/` test files because the UAT fix (commit `91bc6fc`) added `sourceEntityTitle` as a required field to `DiaryEntrySummary` and `DiaryEntryDetail` types in `@cornerstone/shared`, but the QA integration test mock objects were not updated.
Affected files:
Error:
```
Property 'sourceEntityTitle' is missing in type '{ id: string; entryType: "daily_log"; ... }'
but required in type 'DiaryEntryDetail'.
```
Fix Required
Add `sourceEntityTitle: null` to all mock objects of type `DiaryEntrySummary` and `DiaryEntryDetail` in the affected test files.
Environment
Notes
This is a qa-integration-tester responsibility. The E2E tests are not affected.