fix(rust-napi-ci): ensure cargo bin is on PATH after rust-toolchain#32
Merged
Conversation
dtolnay/rust-toolchain only prepends $CARGO_HOME/bin to PATH when it installs rustup itself. On GitHub macOS runners with pre-installed rustup but no active toolchain, the action installs the toolchain but PATH still resolves `cargo` to a `rustup-init` symlink. Calls like `cargo metadata` (from @napi-rs/cli) then fail with: Internal Error: cargo metadata exited with code 1 error: error: unexpected argument 'metadata' found Usage: rustup-init[EXE] [OPTIONS] Adding `$HOME/.cargo/bin` to $GITHUB_PATH after every rust-toolchain invocation makes the just-installed toolchain win on PATH.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dtolnay/rust-toolchainonly adds\$CARGO_HOME/binto PATH when it installs rustup itself (itsinstall rustup if neededstep). On GitHub macOS runners that ship with rustup pre-installed but no active toolchain, the action installs the toolchain viarustup toolchain install stable, but PATH still resolvescargoto arustup-initsymlink. Subsequentcargo metadatacalls (e.g. from@napi-rs/cli) then fail intermittently with:```
Internal Error: cargo metadata exited with code 1
error: error: unexpected argument 'metadata' found
Usage: rustup-init[EXE] [OPTIONS]
```
Adding
\$HOME/.cargo/binto\$GITHUB_PATHafter eachrust-toolchainaction invocation makes the just-installed toolchain win on PATH unconditionally.Hit at least 3 times today across stella/aho-corasick, stella/fuzzy-search PRs on macOS aarch64/x86_64 build matrices.
Test plan
napi-ci / Build - aarch64-apple-darwinandx86_64-apple-darwinstop intermittent failures.