fix(ui/reference_picker): allow later top-level refs with same basename

Author: sudo-tee

lua/opencode/ui/reference_picker.lua

@@ -81,7 +81,6 @@ function M.parse_references(text, message_id)
       refs = {},
       ranges = {},
       seen_paths = {},
-      seen_basenames = {},
     }
     cache[message_id] = c
   end
@@ -107,18 +106,14 @@ function M.parse_references(text, message_id)
         local abs_ms = ms + abs_offset
         local abs_me = me + abs_offset
         local path_key = path .. ':' .. (l or '') .. ':' .. (col or '')
-        local basename = path:match('[^/]+$') or path
-        local shadowed = entry.check_exists and c.seen_basenames[basename]
 
         if
-          not shadowed
-          and not is_url_path(path, chunk, ms)
+          not is_url_path(path, chunk, ms)
           and not c.seen_paths[path_key]
           and not overlaps(c.ranges, abs_ms, abs_me)
           and (not entry.check_exists or file_exists(path))
         then
           c.seen_paths[path_key] = true
-          c.seen_basenames[basename] = true
           table.insert(c.ranges, { abs_ms, abs_me })
           table.insert(c.refs, make_ref(path, l or '', col or '', abs_ms, abs_me))
         end

tests/unit/reference_picker_spec.lua

@@ -244,6 +244,17 @@ describe('opencode.ui.reference_picker', function()
       assert.equal('src/main.lua', refs[1].file_path)
     end)
 
+    it('keeps later top-level references with the same basename', function()
+      local text = 'See `src/main.lua:10` first, then check main.lua:42 too.'
+      local refs = reference_picker.parse_references(text, 'msg1')
+
+      assert.equal(2, #refs)
+      assert.equal('src/main.lua', refs[1].file_path)
+      assert.equal(10, refs[1].line)
+      assert.equal('main.lua', refs[2].file_path)
+      assert.equal(42, refs[2].line)
+    end)
+
     it('ref struct contains file_path, line, col, match_start, match_end', function()
       local text = 'See `src/test.lua:5:3` for details.'
       local refs = reference_picker.parse_references(text, 'msg1')