Skip to content

parity(storage): expose additional parameters in Download method [from supabase-js] #233

@grdsdev

Description

@grdsdev

SDK Parity: C# implementation needed

A change was made in supabase-js that needs to be implemented in this repository for SDK parity.

Reference Implementation (supabase-js)

  • Commit: 4b87b9d
  • PR: #2090
  • Module: storage
  • Type: enhancement

What Changed

The download method on StorageFileApi now accepts an optional parameters argument supporting signal (request cancellation) and cache (HTTP cache control).

Code Reference

export interface FetchParameters {
  signal?: AbortSignal
  cache?: RequestCache
}

download(path: string, options?: { transform?: TransformOptions }, parameters?: FetchParameters)

Implementation Guidance

Expected API Surface (C#)

public async Task<byte[]> Download(
    string supabasePath,
    TransformOptions? transformOptions = null,
    CancellationToken cancellationToken = default,
    EventHandler<float>? onProgress = null)

Key Behaviors to Match

  • Download accepts CancellationToken for request cancellation (C# equivalent of AbortSignal)
  • Optionally support cache-related HTTP headers
  • No breaking changes to existing signature

Acceptance Criteria

  • Download method accepts CancellationToken for cancellation
  • Unit tests cover cancellation scenarios
  • Documentation updated
  • No breaking changes to existing API

Context

  • supabase-js version: v2.95.3
  • Parity tracking: This issue was auto-generated by SDK parity analysis
  • Related parity issues: SDK-694 (py)

Generated with Claude Code /sync-sdk-parity

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions