chore: add unit tests for GenerateOtp #2281
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lock in the current behavior of GenerateOtp with unit tests. This required a small change to allow passing an io.Reader. In addition I added a TODO comment about a minor defensive change to include bounds checks, error propagation and the correct way to support larger digits.
cstockton
force-pushed
the
cs/crypto-generate-otp-tests
branch
from
d382ca7 to
8b9c83e
Compare
This is a deliberate usage for deterministic outputs.
issuedat
approved these changes
Dec 5, 2025
Pull Request Test Coverage Report for Build 19968396814Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change locks in the current behavior of GenerateOtp with unit tests. This required a small change to allow passing an io.Reader. In addition I added a TODO comment about a minor defensive change to include bounds checks, error propagation and the correct way to support larger digits.
This is in response to #2272