fix(tests): correct library naming and symlinks for background worker extensions

Test assertions were inconsistent: expecting {version}.so and {extension_name}-{version}.so
patterns while actual libraries use {lib_name}-{version}.so (e.g. pg_partman_bgw-5.3.1.so,
timescaledb-loader-2.16.1.so). Updated PostgresExtensionTest to accept Optional[str] lib_name
parameter and use consistent {lib_name}-{version}.so assertions throughout.

Added missing timescaledb-loader.so symlink creation and updated the switch script to
maintain both symlinks when switching versions.

Fixes 'Expected timescaledb version 2.16.1, but found timescaledb-loader-2.16.1.so' and
'Expected pg_partman version 5.3.1, but found pg_partman_bgw-5.3.1.so' test failures.

Author: yvan-sraka

nix/ext/tests/default.nix

@@ -168,7 +168,7 @@ let
           server.wait_for_unit("multi-user.target")
           server.wait_for_unit("postgresql.service")
 
-          test = PostgresExtensionTest(server, extension_name, versions, sql_test_directory, support_upgrade, ext_schema)
+          test = PostgresExtensionTest(server, extension_name, versions, sql_test_directory, support_upgrade, ext_schema, lib_name)
           test.create_schema()
 
           with subtest("Check upgrade path with postgresql 15"):

nix/ext/tests/lib.py

@@ -5,7 +5,7 @@
 installation, upgrades, and version verification of PostgreSQL extensions.
 """
 
-from typing import Sequence, Mapping
+from typing import Sequence, Mapping, Optional
 from pathlib import Path
 from test_driver.machine import Machine
 
@@ -21,6 +21,7 @@ def __init__(
         sql_test_dir: Path,
         support_upgrade: bool = True,
         schema: str = "public",
+        lib_name: Optional[str] = None,
     ):
         """Initialize the PostgreSQL extension test framework.
 
@@ -30,13 +31,15 @@ def __init__(
             versions: Mapping of PostgreSQL versions to available extension versions
             sql_test_dir: Directory containing SQL test files for pg_regress
             support_upgrade: Whether the extension supports in-place upgrades
+            lib_name: Name of the shared library (defaults to extension_name)
         """
         self.vm = vm
         self.extension_name = extension_name
         self.versions = versions
         self.support_upgrade = support_upgrade
         self.sql_test_dir = sql_test_dir
         self.schema = schema
+        self.lib_name = lib_name or extension_name
 
     def create_schema(self):
         self.run_sql(f"CREATE SCHEMA IF NOT EXISTS {self.schema};")
@@ -163,7 +166,7 @@ def check_switch_extension_with_background_worker(
                 f"No versions available for PostgreSQL version {pg_version}"
             )
         last_version = available_versions[-1]
-        assert ext_version.endswith(f"{last_version}.so"), (
+        assert ext_version.endswith(f"{self.lib_name}-{last_version}.so"), (
             f"Expected {self.extension_name} version {last_version}, but found {ext_version}"
         )
 
@@ -173,15 +176,15 @@ def check_switch_extension_with_background_worker(
 
         # Check that we are using the first version now
         ext_version = self.vm.succeed(f"readlink -f {extension_lib_path}").strip()
-        assert ext_version.endswith(f"{first_version}.so"), (
+        assert ext_version.endswith(f"{self.lib_name}-{first_version}.so"), (
             f"Expected {self.extension_name} version {first_version}, but found {ext_version}"
         )
 
         # Switch to the last version
         self.vm.succeed(f"switch_{self.extension_name}_version {last_version}")
         # Check that we are using the last version now
         ext_version = self.vm.succeed(f"readlink -f {extension_lib_path}").strip()
-        assert ext_version.endswith(f"{self.extension_name}-{last_version}.so"), (
+        assert ext_version.endswith(f"{self.lib_name}-{last_version}.so"), (
             f"Expected {self.extension_name} version {last_version}, but found {ext_version}"
         )
 

nix/ext/tests/timescaledb.nix

@@ -88,12 +88,12 @@ self.inputs.nixpkgs.lib.nixos.runTest {
       support_upgrade = True
       sql_test_directory = Path("${../../tests}")
 
-      test = PostgresExtensionTest(server, extension_name, versions, sql_test_directory, support_upgrade)
+      test = PostgresExtensionTest(server, extension_name, versions, sql_test_directory, support_upgrade, "public", "timescaledb-loader")
 
       with subtest("Check upgrade path with postgresql 15"):
         test.check_upgrade_path("15")
 
       with subtest("Test switch_${pname}_version"):
-        test.check_switch_extension_with_background_worker(Path("${psql_15}/lib/${pname}.so"), "15")
+        test.check_switch_extension_with_background_worker(Path("${psql_15}/lib/timescaledb-loader.so"), "15")
     '';
 }

nix/ext/timescaledb.nix

@@ -108,6 +108,7 @@ let
       EXT_LOADER_TO_USE="$EXT_WRAPPER_LIB/$EXT_NAME-loader-$VERSION${postgresql.dlSuffix}"
       if [ -f "$EXT_LOADER_TO_USE" ]; then
         ln -sfnv "$EXT_LOADER_TO_USE" "$EXT_WRAPPER_LIB/$EXT_NAME${postgresql.dlSuffix}"
+        ln -sfnv "$EXT_LOADER_TO_USE" "$EXT_WRAPPER_LIB/$EXT_NAME-loader${postgresql.dlSuffix}"
       fi
     '';
   };
@@ -125,6 +126,9 @@ buildEnv {
     # Create symlink from the latest versioned loader to timescaledb.so
     ln -sfn ${pname}-loader-${latestVersion}${postgresql.dlSuffix} $out/lib/${pname}${postgresql.dlSuffix}
 
+    # Create symlink for timescaledb-loader.so (used by background worker tests)
+    ln -sfn ${pname}-loader-${latestVersion}${postgresql.dlSuffix} $out/lib/${pname}-loader${postgresql.dlSuffix}
+
     # The versioned extension libraries (timescaledb-VERSION.so) are already in place
 
     # checks - we should have loader files and versioned extension files
@@ -143,6 +147,7 @@ buildEnv {
   passthru = {
     inherit versions numberOfVersions switch-ext-version;
     hasBackgroundWorker = true;
+    libName = "timescaledb-loader";
     defaultSettings = {
       shared_preload_libraries = [ "timescaledb" ];
     };