chore: v8 has been removed from nixpkgs and replaced with nodejs.libv8

Author: jfroche

nix/ext/plv8.nix

@@ -2,12 +2,12 @@
   stdenv,
   lib,
   fetchFromGitHub,
-  v8,
+  nodejs,
   perl,
   postgresql,
   # For passthru test on various systems, and local development on macos
   # not we are not currently using passthru tests but retaining for possible contrib
-  # to nixpkgs 
+  # to nixpkgs
   clang,
   xcbuild,
   darwin,
@@ -40,7 +40,7 @@ stdenv.mkDerivation (finalAttrs: {
 
   buildInputs =
     [
-      v8
+      nodejs.libv8
       postgresql
     ]
     ++ lib.optionals stdenv.isDarwin [
@@ -54,20 +54,20 @@ stdenv.mkDerivation (finalAttrs: {
     [
       # Nixpkgs build a v8 monolith instead of separate v8_libplatform.
       "USE_SYSTEM_V8=1"
-      "V8_OUTDIR=${v8}/lib"
+      "V8_OUTDIR=${nodejs.libv8}/lib"
       "PG_CONFIG=${postgresql}/bin/pg_config"
     ]
     ++ lib.optionals stdenv.isDarwin [
       "CC=${clang}/bin/clang"
       "CXX=${clang}/bin/clang++"
-      "SHLIB_LINK=-L${v8}/lib -lv8_monolith -Wl,-rpath,${v8}/lib"
+      "SHLIB_LINK=-L${nodejs.libv8}/lib -lv8_monolith -Wl,-rpath,${nodejs.libv8}/lib"
     ]
     ++ lib.optionals (!stdenv.isDarwin) [ "SHLIB_LINK=-lv8" ];
 
   NIX_LDFLAGS = (
     lib.optionals stdenv.isDarwin [
       "-L${postgresql}/lib"
-      "-L${v8}/lib"
+      "-L${nodejs.libv8}/lib"
       "-lv8_monolith"
       "-lpq"
       "-lpgcommon"
@@ -119,30 +119,26 @@ stdenv.mkDerivation (finalAttrs: {
       sed -i 's|module_pathname = '"'"'$libdir/plv8-[0-9.]*'"'"'|module_pathname = '"'"'$libdir/plv8'"'"'|' "$out/share/postgresql/extension/plls.control"
 
       ${lib.optionalString stdenv.isDarwin ''
-        install_name_tool -add_rpath "${v8}/lib" $out/lib/plv8.so
+        install_name_tool -add_rpath "${nodejs.libv8}/lib" $out/lib/plv8.so
         install_name_tool -add_rpath "${postgresql}/lib" $out/lib/plv8.so
         install_name_tool -add_rpath "${stdenv.cc.cc.lib}/lib" $out/lib/plv8.so
-        install_name_tool -change @rpath/libv8_monolith.dylib ${v8}/lib/libv8_monolith.dylib $out/lib/plv8.so
+        install_name_tool -change @rpath/libv8_monolith.dylib ${nodejs.libv8}/lib/libv8_monolith.dylib $out/lib/plv8.so
       ''}
 
-      ${
-        lib.optionalString (!stdenv.isDarwin) ''
-          ${patchelf}/bin/patchelf --set-rpath "${v8}/lib:${postgresql}/lib:${stdenv.cc.cc.lib}/lib" $out/lib/plv8.so
-        ''
-      }
+      ${lib.optionalString (!stdenv.isDarwin) ''
+        ${patchelf}/bin/patchelf --set-rpath "${nodejs.libv8}/lib:${postgresql}/lib:${stdenv.cc.cc.lib}/lib" $out/lib/plv8.so
+      ''}
     else
       ${lib.optionalString stdenv.isDarwin ''
-        install_name_tool -add_rpath "${v8}/lib" $out/lib/plv8-${finalAttrs.version}${postgresql.dlSuffix}
+        install_name_tool -add_rpath "${nodejs.libv8}/lib" $out/lib/plv8-${finalAttrs.version}${postgresql.dlSuffix}
         install_name_tool -add_rpath "${postgresql}/lib" $out/lib/plv8-${finalAttrs.version}${postgresql.dlSuffix}
         install_name_tool -add_rpath "${stdenv.cc.cc.lib}/lib" $out/lib/plv8-${finalAttrs.version}${postgresql.dlSuffix}
-        install_name_tool -change @rpath/libv8_monolith.dylib ${v8}/lib/libv8_monolith.dylib $out/lib/plv8-${finalAttrs.version}${postgresql.dlSuffix}
+        install_name_tool -change @rpath/libv8_monolith.dylib ${nodejs.libv8}/lib/libv8_monolith.dylib $out/lib/plv8-${finalAttrs.version}${postgresql.dlSuffix}
       ''}
 
-      ${
-        lib.optionalString (!stdenv.isDarwin) ''
-          ${patchelf}/bin/patchelf --set-rpath "${v8}/lib:${postgresql}/lib:${stdenv.cc.cc.lib}/lib" $out/lib/plv8-${finalAttrs.version}${postgresql.dlSuffix}
-        ''
-      }
+      ${lib.optionalString (!stdenv.isDarwin) ''
+        ${patchelf}/bin/patchelf --set-rpath "${nodejs.libv8}/lib:${postgresql}/lib:${stdenv.cc.cc.lib}/lib" $out/lib/plv8-${finalAttrs.version}${postgresql.dlSuffix}
+      ''}
     fi
   '';