fix(auth): skip navigator lock when persistSession is false #1928
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
when
persistSession: falseis set, the auth client was still using navigator locks for cross-tab coordination. this causedNavigatorLockAcquireTimeoutErrorto appear in the console even though there's no shared state between tabs when sessions are stored in memory only.why
navigator locks are used for cross-tab session coordination. when
persistSession: false:this is consistent with how
BroadcastChannelis already handled in the same file, which also checkspersistSessionbefore enabling cross-tab communication.how
added
his.persistSessioncheck to the condition for usingavigatorLock. whenpersistSession: falsethe client now useslockNoOpinstead.closes #1517