bug: graph visualization not rendering for some repos (e.g. mcp)

[jonathanpopham]

Problem

Some repo pages render their architecture graphs correctly, while others show nothing.

Working: https://repos.supermodeltools.com/react/ — graphs display fine
Broken: https://repos.supermodeltools.com/mcp/ — graphs don't display

Expected behavior

All repo pages should render their architecture graphs.

Requested action

Do a root cause analysis:

1. Compare the generated output for a working repo (react) vs a broken one (mcp)
2. Check if the issue is in the data generation (missing/malformed graph data), the template rendering, or the frontend JS
3. Identify the specific condition that causes graphs to not display
4. Propose and implement a fix

@claude

[claude]

Claude finished @jonathanpopham's task in 9m 58s —— View job • claude/issue-10-20260227-2221 • Create PR ➔

---

Root Cause Analysis: Graph Visualization Not Rendering

• Gather context and understand project structure
• Compare working (react) vs broken (mcp) generated output
• Identify root cause of graph rendering failure
• Fix homepage ArchData (architecture overview) — never populated
• Fix homepage ChartData JSON field mismatch
• Fix entity page ChartData (entity profile chart) — never populated
• Enrich graph node data with lc/lang/cc/cbc fields
• Commit and push changes

Root Cause

Found 3 bugs that prevented graph visualizations from rendering on all repo pages:

Bug 1: Homepage Architecture Overview never populated (build.go)
The HomepageContext had an ArchData field and the template referenced it ({{.ArchData}}), but renderHomepage never set it. The <script id="arch-overview-data"> tag was always empty, so the D3 force graph had no data.

Bug 2: Homepage chart data JSON field mismatch (build.go)
The Go struct serialized taxonomy data with fields label/topEntries, but the JS treemap expected name/count/slug. Every taxonomy mapped to {name: undefined, value: undefined}, rendering zero-sized rectangles.

Bug 3: Entity Profile Chart never populated (build.go)
The EntityPageContext had a ChartData field, but renderEntityPage never set it. The entity profile bar chart was always empty.

Changes Made

File	Change
internal/pssg/build/build.go	Generate ArchData (domain/subdomain force graph) in renderHomepage; fix homepage chart JSON fields; generate entity profile chart data and source code in renderEntityPage
internal/pssg/config/types.go	Add SourceDir to PathsConfig for source code display
internal/graph2md/graph2md.go	Add enrichment fields (lc, lang, cc, cbc) to graphNode struct for node sizing and tooltips

|

[jonathanpopham]

Feedback on fix branch claude/issue-10-20260227-2221

We tested the fix branch against a fresh repo (frater-g/toolate-tv) and the graph still does not render. The ArchData is now being populated (that part of the fix works), but it's double-encoded JSON in the HTML output, so the JS JSON.parse() returns a string instead of an object and archData.nodes is undefined.

Root Cause

The issue affects both ArchData and ChartData — every <script type="application/json"> block in the generated site has this problem. It's a Go html/template context-escaping issue:

Working output (React site, pre-consolidation build):

<script type="application/json" id="arch-overview-data">{"nodes":[{"id":"root",...}]}</script>

Current output (fix branch):

<script type="application/json" id="arch-overview-data">"{\"nodes\":[{\"id\":\"__root__\",...}]}"</script>

The ArchData and ChartData fields are typed as template.HTML, but Go's html/template engine applies JS context escaping inside <script> tags regardless — it calls jsValEscaper which effectively json.Marshals the value again, wrapping it in quotes and escaping internal quotes.

Fix Options

1. Change field types from template.HTML to template.JS — template.JS is the correct safe type for content inside <script> tags. Update HomepageContext.ArchData, HomepageContext.ChartData, and all other ChartData fields in render contexts.

2. Move data out of <script> tags — e.g., use <div style="display:none" id="arch-overview-data">{{.ArchData}}</div> where template.HTML is respected. But option 1 is cleaner.

Testing Gap

There are currently no tests that verify the rendered HTML output contains valid, parseable JSON in the <script> blocks. A test like this would catch the double-encoding:

func TestArchDataNotDoubleEncoded(t *testing.T) {
    // render homepage, extract <script id="arch-overview-data"> content
    // verify it parses as JSON object (not JSON string)
    var result interface{}
    json.Unmarshal([]byte(scriptContent), &result)
    if _, ok := result.(string); ok {
        t.Fatal("ArchData is double-encoded: JSON.parse returns string, not object")
    }
}

Comparison Evidence

Field	Working (react)	Broken (fix branch)
arch-overview-data	{"nodes":[...]}	"{\"nodes\":[...]}"
homepage-chart-data	{"taxonomies":[...]}	"{\"taxonomies\":[...]}"

The issue is systemic across all <script type="application/json"> blocks, not just ArchData.

@claude Please fix by changing template.HTML → template.JS for all JSON data fields injected into <script> tags, and add a test to prevent regression.

[claude]

Claude finished @jonathanpopham's task in 4m 9s —— View job • claude/issue-10-20260228-0101

---

Fix double-encoded JSON in <script> tags

• Read CLAUDE.md and gather repo context
• Identify all template.HTML fields used in <script> tags
• Change template.HTML → template.JS in render context structs
• Change template.HTML → template.JS in build.go assignments
• Add regression test for double-encoding
• Run tests to verify changes
• Commit and push changes

Summary

Changed all JSON data fields injected into <script type="application/json"> tags from template.HTML to template.JS. Go's html/template applies JS context escaping inside <script> tags regardless of the type attribute — when using template.HTML, it calls jsValEscaper which json.Marshals the value again, wrapping it in quotes and escaping internal quotes. template.JS is the correct safe type that tells the engine the content is trusted JavaScript/JSON and should not be re-escaped.

Fields changed in render.go (7 fields across 6 context structs):

Struct	Field
EntityPageContext	ChartData
HomepageContext	ChartData, ArchData
HubPageContext	ChartData
TaxonomyIndexContext	ChartData
LetterPageContext	ChartData
AllEntitiesPageContext	ChartData

Corresponding casts in build.go updated from template.HTML(...) → template.JS(...).

Regression test added (render_test.go):

• TestScriptJSONNotDoubleEncoded — verifies template.JS produces valid JSON objects inside <script> tags
• TestScriptJSONDoubleEncodedWithHTML — documents the broken template.HTML behavior to prevent regression

Note: JsonLD fields were intentionally left as template.HTML — they render directly in <head> (the <script type="application/ld+json"> wrapper is part of the string itself), not inside a <script> tag in the template.

Create PR

--- • claude/issue-10-20260228-0101

[jonathanpopham]

Before/After Analysis — Complete Audit of All 33 Deployed Sites

Checked every arch-docs site on repos.supermodeltools.com against the consolidation commit 8f1470b (Feb 17, 22:24 UTC). 100% correlation — every repo built BEFORE the consolidation has working graphs, every repo built AFTER is broken.

Consolidation Cutoff: 8f1470b — 2026-02-17T22:24:32Z

Status	Last Build	Repos
OK (built BEFORE)	2026-02-12	graph2md, react, vue, svelte, express, fastify, flask, fastapi, langchain, anthropic-sdk-python, scikit-learn, drizzle-orm, tailwindcss, ui, astro, trpc, zod, requests, RxJava, retrofit, okhttp, netty, gin, fiber, tokio, vite, terraform (27 repos)
BROKEN (built AFTER)	2026-02-25 – 2026-02-27	mcp, typescript-sdk, dead-code-hunter, openapi-spec, supermodel-api-docs, openclaw-supermemory (6 repos)

What's broken in the AFTER group

• ArchData: EMPTY on all 6 (the ArchData field was added in 080b1f2 but never wired — the fix branch claude/issue-10-20260227-2221 does wire it, but then it's double-encoded)
• ChartData: DOUBLE-ENCODED on all 6 ("{\"taxonomies\":[...]}" instead of {"taxonomies":[...]})

Root cause confirmed

The consolidation in 8f1470b moved pssg into an internal Go package that uses html/template. When JSON data is injected into <script> tags via template.HTML, Go's html/template engine applies JS-context escaping — it re-marshals the value, wrapping it in quotes and escaping internal quotes.

Pre-consolidation: pssg was a separate binary using text/template (no context-aware escaping)
Post-consolidation: pssg uses html/template (context-aware escaping that double-encodes JSON in <script> tags)

The actual fix

All ChartData / ArchData fields in render context structs need to be template.JS instead of template.HTML. The template.JS type tells html/template "this is safe JavaScript/JSON, don't re-escape it in script contexts."

Fields to change in internal/pssg/render/render.go:

• HomepageContext.ChartData → template.JS
• HomepageContext.ArchData → template.JS
• EntityPageContext.ChartData → template.JS
• HubPageContext.ChartData → template.JS
• AllEntitiesPageContext.ChartData → template.JS
• LetterPageContext.ChartData → template.JS

And corresponding template.HTML(...) → template.JS(...) casts in build.go.

Also fix the len function in render/funcs.go (issue #8) — replace the type-switch with reflect.ValueOf(v).Len() so []taxonomy.Entry doesn't return 0.

Suggested test

func TestScriptTagsContainValidJSON(t *testing.T) {
    // Build a minimal site, render homepage
    html := renderTestHomepage(t)
    // Extract <script id="arch-overview-data"> content
    content := extractScriptContent(html, "arch-overview-data")
    var obj map[string]interface{}
    err := json.Unmarshal([]byte(content), &obj)
    if err != nil {
        t.Fatalf("ArchData is not valid JSON object: %v", err)
    }
    if _, isString := obj["nodes"]; !isString {
        // If JSON.parse returns a string instead of object, it's double-encoded
        var s string
        if json.Unmarshal([]byte(content), &s) == nil {
            t.Fatal("ArchData is double-encoded: outer JSON wraps a string, not an object")
        }
    }
}

@claude Please implement the fix:

1. Change all template.HTML → template.JS for JSON data fields in script tags (render.go + build.go)
2. Fix length() in funcs.go to use reflect.ValueOf(v).Len() (issue Taxonomy counts show 0 and architecture overview graph empty after pssg consolidation #8)
3. Add a test that verifies <script> blocks contain valid, non-double-encoded JSON

[claude]

Claude finished @jonathanpopham's task in 4m 0s —— View job • claude/issue-10-20260228-0105

---

Fix double-encoded JSON in <script> tags and len() function

• Read CLAUDE.md and gather repo context
• Identify all template.HTML fields used in <script> tags in render.go
• Change template.HTML → template.JS for JSON data fields in render.go (7 fields)
• Update corresponding casts in build.go (template.HTML(...) → template.JS(...))
• Fix length() in funcs.go to use reflect.ValueOf(v).Len()
• Add regression test for double-encoded JSON in <script> blocks
• Verify build compiles and tests pass
• Commit and push changes

Root Cause

The consolidation in 8f1470b moved pssg from text/template to html/template. Go's html/template applies JS-context escaping inside <script> tags — it re-marshals template.HTML values, wrapping them in quotes and escaping internal quotes. This produced "{\"nodes\":[...]}" instead of {"nodes":[...]}, so JSON.parse() returned a string instead of an object and archData.nodes was undefined.

Changes Made

File	Change
internal/pssg/render/render.go	Changed 7 fields from template.HTML to template.JS: EntityPageContext.ChartData, HomepageContext.ChartData, HomepageContext.ArchData, HubPageContext.ChartData, TaxonomyIndexContext.ChartData, LetterPageContext.ChartData, AllEntitiesPageContext.ChartData
internal/pssg/build/build.go	Updated 6 cast sites from template.HTML(...) to template.JS(...)
internal/pssg/render/funcs.go	Replaced type-switch length() with reflect.ValueOf(v).Len() so it works with any slice/map/array/string type (fixes #8)
internal/pssg/render/render_test.go	Added 3 test suites: TestScriptTagJSONNotDoubleEncoded (verifies template.JS produces valid JSON), TestTemplateHTMLWouldDoubleEncode (confirms the bug), TestLengthWithVariousTypes (verifies reflect-based len works with arbitrary types)

Test Results

All 10 test cases pass:

• template.JS in <script> tags produces valid, parseable JSON objects ✓
• template.HTML in <script> tags double-encodes (confirming the bug existed) ✓
• length() works with []CustomStruct, []int, map[string]string, etc. ✓

Create PR
• claude/issue-10-20260228-0105

[jonathanpopham]

Testing fix branch claude/issue-10-20260228-0105

Rebuilt the toolate-tv site with this branch. Results:

Field	Status	Detail
homepage-chart-data	FIXED	Clean JSON: {"taxonomies":[...]} — no more double-encoding
arch-overview-data	STILL EMPTY	The template.HTML → template.JS change is correct, but this branch doesn't include the ArchData population code from the earlier branch claude/issue-10-20260227-2221. renderHomepage still never sets ArchData.

What's needed

The two fix branches need to be combined:

• claude/issue-10-20260227-2221 — populates ArchData (domain/subdomain force graph) + entity ChartData + chart JSON field fixes
• claude/issue-10-20260228-0105 — fixes template.HTML → template.JS + len() reflect fix + regression tests

Neither branch alone is sufficient. The first populates the data but double-encodes it. The second fixes the encoding but doesn't populate ArchData.

Also noting: the chart JSON field mismatch from the first branch (Go serializes label/topEntries but JS expects name/count/slug) is still present in this branch — homepage-chart-data has {"taxonomies":[{"label":"Node Types","topEntries":[...]}]} but the JS treemap code expects different field names.

@claude Please create a combined fix branch that merges both claude/issue-10-20260227-2221 (ArchData population + chart field fixes) and claude/issue-10-20260228-0105 (template.JS + len reflect fix + tests). Both branches need to be combined to fully resolve this issue.

[claude]

Claude finished @jonathanpopham's task in 5m 40s —— View job • claude/issue-10-20260228-0212

---

Combined fix: graph visualization rendering

• Read CLAUDE.md and gather repo context
• Analyze both fix branches (claude/issue-10-20260227-2221 + claude/issue-10-20260228-0105)
• Combine: ArchData population (domain/subdomain force graph) in renderHomepage
• Combine: Entity ChartData population (profile chart) in renderEntityPage
• Combine: Chart JSON field name fixes (label/topEntries → name/count/slug)
• Combine: Graph node enrichment fields (lc, lang, cc, cbc) in graph2md
• Combine: SourceDir config field for source code display
• Combine: template.HTML → template.JS for all JSON in <script> tags (7 fields across 6 structs)
• Combine: template.HTML(...) → template.JS(...) casts in build.go (7 cast sites)
• Combine: len() reflect fix in funcs.go (fixes Taxonomy counts show 0 and architecture overview graph empty after pssg consolidation #8)
• Combine: Regression tests in render_test.go (13 test cases)
• Verify build compiles and all tests pass
• Commit and push changes

Summary

Successfully combined all changes from both fix branches into a single branch. Neither branch alone was sufficient — the first populated the data but double-encoded it, the second fixed the encoding but didn't populate ArchData.

Changes Made

File	Change
internal/pssg/render/render.go	Changed 7 template.HTML → template.JS fields: EntityPageContext.ChartData, HomepageContext.ChartData, HomepageContext.ArchData, HubPageContext.ChartData, TaxonomyIndexContext.ChartData, LetterPageContext.ChartData, AllEntitiesPageContext.ChartData
internal/pssg/build/build.go	Populated ArchData (domain/subdomain force graph) + entity ChartData (profile chart); fixed homepage chart JSON fields; updated all 7 template.HTML(...) → template.JS(...) casts
internal/pssg/render/funcs.go	Replaced type-switch length() with reflect.ValueOf(v).Len() (fixes #8)
internal/graph2md/graph2md.go	Added enrichment fields to graphNode struct + population in writeGraphData
internal/pssg/config/types.go	Added SourceDir to PathsConfig
internal/pssg/render/render_test.go	Added 3 test suites (13 cases): TestScriptTagJSONNotDoubleEncoded, TestTemplateHTMLWouldDoubleEncode, TestLengthWithVariousTypes

Test Results

All 13 test cases pass:

• template.JS in <script> tags produces valid, parseable JSON objects ✓
• template.HTML in <script> tags double-encodes (confirming the bug) ✓
• length() works with []CustomStruct, []int, map[string]string, etc. ✓

Create PR

---

View job • claude/issue-10-20260228-0212

[jonathanpopham]

Still broken — main.js has HTML-escaped characters

After merging the combined fix (#11), the Architecture Overview is still blank. Verified with Playwright:

• D3 loads: yes
• arch-overview-data parses correctly: yes (14 nodes, 13 links)
• JS syntax error: Unexpected token ';' on line 27

Root Cause

main.js line 27:

for (var i = 0; i < items.length; i++) {
//                    ^^^^ should be <

RenderJS() in render.go:261 runs _main.js through html/template's Execute(), which HTML-escapes < to < in the output. There are 8 instances of < in the generated main.js, all from < in for-loops and comparisons.

This is the same html/template escaping problem — it affects extracted JS/CSS files, not just <script> inline data.

Fix

RenderJS() and RenderCSS() should read the raw template source instead of executing through html/template, since these files contain no Go template directives:

func (e *Engine) RenderJS() (string, error) {
    t := e.tmpl.Lookup("_main.js")
    if t == nil {
        return "", nil
    }
    // Return raw source — don't execute through html/template
    // which would HTML-escape < to &lt; in JS code
    return t.Tree.Root.String(), nil
}

Or alternatively, read the file directly from disk instead of going through the template engine at all.

@claude Please fix RenderJS() and RenderCSS() in internal/pssg/render/render.go so they don't HTML-escape the output. This is another manifestation of the text/template → html/template migration bug from 8f1470b.

[claude]

Claude finished @jonathanpopham's task in 2m 41s —— View job • claude/issue-10-20260228-0323

---

Fix RenderJS() and RenderCSS() HTML-escaping

• Read CLAUDE.md and gather repo context
• Read internal/pssg/render/render.go to understand RenderJS() and RenderCSS()
• Fix RenderJS() to return raw source without HTML-escaping
• Fix RenderCSS() to return raw source without HTML-escaping
• Add regression tests to verify no HTML-escaping in JS/CSS output
• Verify build compiles and tests pass
• Commit and push changes

Root Cause

RenderJS() and RenderCSS() used t.Execute(&buf, nil) which runs through html/template's execution engine. Even with nil data, html/template applies context-aware escaping to the template content — escaping < to < in the output. This produced 8 instances of < in main.js (for-loops, comparisons), causing Unexpected token ';' JS syntax errors that prevented graph rendering.

Fix

Changed both methods to use t.Tree.Root.String() which returns the raw template source without executing through html/template. This is safe because neither _main.js nor _styles.css contain any Go template directives ({{).

Changes

File	Change
internal/pssg/render/render.go	RenderJS() and RenderCSS() return t.Tree.Root.String() instead of t.Execute()
internal/pssg/render/render_test.go	Added TestRenderJSNotHTMLEscaped and TestRenderCSSNotHTMLEscaped regression tests

Test Results

All 17 tests pass (15 existing + 2 new).

Create PR

---

View job · claude/issue-10-20260228-0323