Tollerate more data after request body is cancelled (#617)

* Tollerate more data after request body is cancelled

* wait is not needed if we shutdown the server first

* Remove test that depends on external resources

* Remove unused conformance to Equatable

* SwiftFormat

* run generate_linux_tests.rb

* Increase timeout for CI

Author: dnadoba

Sources/AsyncHTTPClient/AsyncAwait/Transaction+StateMachine.swift

@@ -429,17 +429,20 @@ extension Transaction {
             case .executing(_, _, .waitingForResponseHead):
                 preconditionFailure("If we receive a response body, we must have received a head before")
 
-            case .executing(let context, let requestState, .buffering(let streamID, var currentBuffer, next: let next)):
-                guard case .askExecutorForMore = next else {
-                    preconditionFailure("If we have received an error or eof before, why did we get another body part? Next: \(next)")
-                }
+            case .executing(_, _, .buffering(_, _, next: .endOfFile)):
+                preconditionFailure("If we have received an eof before, why did we get another body part?")
 
+            case .executing(_, _, .buffering(_, _, next: .error)):
+                // we might still get pending buffers if the user has canceled the request
+                return .none
+
+            case .executing(let context, let requestState, .buffering(let streamID, var currentBuffer, next: .askExecutorForMore)):
                 if currentBuffer.isEmpty {
                     currentBuffer = buffer
                 } else {
                     currentBuffer.append(contentsOf: buffer)
                 }
-                self.state = .executing(context, requestState, .buffering(streamID, currentBuffer, next: next))
+                self.state = .executing(context, requestState, .buffering(streamID, currentBuffer, next: .askExecutorForMore))
                 return .none
 
             case .executing(let executor, let requestState, .waitingForResponseIterator(var currentBuffer, next: let next)):
@@ -690,10 +693,11 @@ extension Transaction {
             case .finished:
                 // the request failed or was cancelled before, we can ignore all events
                 return .none
-
+            case .executing(_, _, .buffering(_, _, next: .error)):
+                // we might still get pending buffers if the user has canceled the request
+                return .none
             case .executing(_, _, .waitingForResponseIterator(_, next: .error)),
                  .executing(_, _, .waitingForResponseIterator(_, next: .endOfFile)),
-                 .executing(_, _, .buffering(_, _, next: .error)),
                  .executing(_, _, .buffering(_, _, next: .endOfFile)),
                  .executing(_, _, .finished(_, _)):
                 preconditionFailure("Already received an eof or error before. Must not receive further events. Invalid state: \(self.state)")

Tests/AsyncHTTPClientTests/AsyncAwaitEndToEndTests+XCTest.swift

@@ -43,6 +43,7 @@ extension AsyncAwaitEndToEndTests {
             ("testInvalidURL", testInvalidURL),
             ("testRedirectChangesHostHeader", testRedirectChangesHostHeader),
             ("testShutdown", testShutdown),
+            ("testCancelingBodyDoesNotCrash", testCancelingBodyDoesNotCrash),
         ]
     }
 }

Tests/AsyncHTTPClientTests/AsyncAwaitEndToEndTests.swift

@@ -578,6 +578,26 @@ final class AsyncAwaitEndToEndTests: XCTestCase {
         }
         #endif
     }
+
+    /// Regression test for https://github.com/swift-server/async-http-client/issues/612
+    func testCancelingBodyDoesNotCrash() {
+        #if compiler(>=5.5.2) && canImport(_Concurrency)
+        guard #available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *) else { return }
+        XCTAsyncTest {
+            let client = makeDefaultHTTPClient()
+            defer { XCTAssertNoThrow(try client.syncShutdown()) }
+            let bin = HTTPBin(.http2(compress: true))
+            defer { XCTAssertNoThrow(try bin.shutdown()) }
+
+            let request = HTTPClientRequest(url: "https://127.0.0.1:\(bin.port)/mega-chunked")
+            let response = try await client.execute(request, deadline: .now() + .seconds(10))
+
+            await XCTAssertThrowsError(try await response.body.collect(upTo: 100)) { error in
+                XCTAssert(error is NIOTooManyBytesError)
+            }
+        }
+        #endif
+    }
 }
 
 #if compiler(>=5.5.2) && canImport(_Concurrency)