Revert "Minimally integrate per-page HTML content into each "index.html" file…" (#1392)

This reverts commit 8b49f1b.

Author: beccadax

Package.swift

@@ -44,7 +44,6 @@ let package = Package(
             name: "SwiftDocC",
             dependencies: [
                 .target(name: "DocCCommon"),
-                .target(name: "DocCHTML"),
                 .product(name: "Markdown", package: "swift-markdown"),
                 .product(name: "SymbolKit", package: "swift-docc-symbolkit"),
                 .product(name: "CLMDB", package: "swift-lmdb"),

Sources/SwiftDocC/CMakeLists.txt

@@ -175,8 +175,6 @@ add_library(SwiftDocC
   Model/Rendering/Diffing/Differences.swift
   Model/Rendering/Diffing/RenderNode+Diffable.swift
   Model/Rendering/DocumentationContentRenderer.swift
-  Model/Rendering/HTML/HTMLContentConsumer.swift
-  Model/Rendering/HTML/HTMLRenderer.swift
   Model/Rendering/LinkTitleResolver.swift
   "Model/Rendering/Navigation Tree/RenderHierarchy.swift"
   "Model/Rendering/Navigation Tree/RenderHierarchyChapter.swift"
@@ -467,8 +465,6 @@ add_library(SwiftDocC
   Utility/Version.swift)
 target_link_libraries(SwiftDocC PRIVATE
   DocCCommon)
-target_link_libraries(SwiftDocC PRIVATE
-  DocCHTML)
 target_link_libraries(SwiftDocC PUBLIC
   SwiftMarkdown::Markdown
   DocC::SymbolKit

Sources/SwiftDocC/Infrastructure/ConvertActionConverter.swift

@@ -26,15 +26,13 @@ package enum ConvertActionConverter {
     /// - Parameters:
     ///   - context: The context that the bundle is a part of.
     ///   - outputConsumer: The consumer that the conversion passes outputs of the conversion to.
-    ///   - htmlContentConsumer: The consumer for HTML content that the conversion produces, or `nil` if the conversion shouldn't produce any HTML content.
     ///   - sourceRepository: The source repository where the documentation's sources are hosted.
     ///   - emitDigest: Whether the conversion should pass additional metadata output––such as linkable entities information, indexing information, or asset references by asset type––to the consumer.
     ///   - documentationCoverageOptions: The level of experimental documentation coverage information that the conversion should pass to the consumer.
     /// - Returns: A list of problems that occurred during the conversion (excluding the problems that the context already encountered).
     package static func convert(
         context: DocumentationContext,
         outputConsumer: some ConvertOutputConsumer & ExternalNodeConsumer,
-        htmlContentConsumer: (any HTMLContentConsumer)?,
         sourceRepository: SourceRepository?,
         emitDigest: Bool,
         documentationCoverageOptions: DocumentationCoverageOptions
@@ -105,27 +103,15 @@ package enum ConvertActionConverter {
 
         let renderSignpostHandle = signposter.beginInterval("Render", id: signposter.makeSignpostID(), "Render \(context.knownPages.count) pages")
 
-        var conversionProblems: [Problem] = context.knownPages.concurrentPerform { [htmlContentConsumer] identifier, results in
+        var conversionProblems: [Problem] = context.knownPages.concurrentPerform { identifier, results in
             // If cancelled skip all concurrent conversion work in this block.
             guard !Task.isCancelled else { return }
 
             // Wrap JSON encoding in an autorelease pool to avoid retaining the autoreleased ObjC objects returned by `JSONSerialization`
             autoreleasepool {
                 do {
                     let entity = try context.entity(with: identifier)
-                    
-                    if let htmlContentConsumer {
-                        var renderer = HTMLRenderer(reference: identifier, context: context, goal: .conciseness)
-                        
-                        if let symbol = entity.semantic as? Symbol {
-                            let renderedPageInfo = renderer.renderSymbol(symbol)
-                            try htmlContentConsumer.consume(pageInfo: renderedPageInfo, forPage: identifier)
-                        } else if let article = entity.semantic as? Article {
-                            let renderedPageInfo = renderer.renderArticle(article)
-                            try htmlContentConsumer.consume(pageInfo: renderedPageInfo, forPage: identifier)
-                        }
-                    }
-                    
+
                     guard let renderNode = converter.renderNode(for: entity) else {
                         // No render node was produced for this entity, so just skip it.
                         return
@@ -261,16 +247,3 @@ package enum ConvertActionConverter {
         return conversionProblems
     }
 }
-
-private extension HTMLContentConsumer {
-    func consume(pageInfo: HTMLRenderer.RenderedPageInfo, forPage reference: ResolvedTopicReference) throws {
-        try consume(
-            mainContent: pageInfo.content,
-            metadata: (
-                title: pageInfo.metadata.title,
-                description: pageInfo.metadata.plainDescription
-            ),
-            forPage: reference
-        )
-    }
-}

Sources/SwiftDocC/Infrastructure/ConvertOutputConsumer.swift

@@ -8,6 +8,8 @@
  See https://swift.org/CONTRIBUTORS.txt for Swift project authors
 */
 
+import Foundation
+
 /// A consumer for output produced by a documentation conversion.
 ///
 /// Types that conform to this protocol manage what to do with documentation conversion products, for example persist them to disk