Fix PHP notices and warning

Author: technicalguru

src/WebApp/BootstrapTheme/DefaultLayout.php

@@ -16,6 +16,7 @@ public function __construct($theme, $page) {
 	}
 
 	protected function getBootstrapUri() {
+		$webroot = $this->app->request->webRoot;
 		return $this->page->getAnnotation(BootstrapTheme::CSS_URI, $webroot.Bootstrap::getCssUri());
 	}
 

src/WebApp/BootstrapTheme/MmenuLayout.php

@@ -130,6 +130,7 @@ protected function renderMmenu() {
 	protected function renderMenuItem($item, $level) {
 		$rc = '';
 		if ($item != NULL) {
+			$icon = '';
 			if (get_class($item) == 'WebApp\Component\Divider') {
 				$rc .= '<li class="mm-divider">';
 				if ($level == 0) {

src/WebApp/BootstrapTheme/VerticalFormRenderer.php

@@ -6,6 +6,8 @@
 
 class VerticalFormRenderer extends \WebApp\DefaultTheme\ContainerRenderer {
 
+	public $form;
+
 	public function __construct($theme, $component) {
 		parent::__construct($theme, $component, 'form');
 	}

src/WebApp/Component/Input.php

@@ -4,6 +4,9 @@
 
 class Input extends BasicFormElement {
 
+	public $prependContent;
+	public $appendContent;
+
 	public function __construct($parent, $id, $type = 'text', $value = null) {
 		parent::__construct($parent, $id, $value);
 		$this->setType($type);

src/WebApp/Component/LoginForm.php

@@ -60,7 +60,7 @@ protected function createForm($tfa, $return) {
 
 	protected function createUserInput($form) {
 		$userid = $this->request->getPostParam('userid', '');
-		$user   = new TextInput($form, 'userid', $uid);
+		$user   = new TextInput($form, 'userid', $userid);
 		//$user->setLabel('login_email_label');
 		$user->setPlaceholder('login_email_placeholder');
 		return $user;

src/WebApp/Component/SearchFilterBar.php

@@ -17,7 +17,8 @@ public function __construct($parent) {
 	}
 
 	public static function getSearchPhrase() {
-		return trim(Request::getRequest()->getParam('search'));
+		$s = Request::getRequest()->getParam('search');
+		return $s != null ? trim($s) : NULL;
 	}
 
 	public static function getFilters() {

src/WebApp/DataModel/AccessLog.php

@@ -4,6 +4,8 @@
 
 class AccessLog {
 
+	public $log_time;
+
 	public function __construct() {
 		if (is_string($this->log_time)) $this->log_time = new \TgUtils\Date($this->log_time, WFW_TIMEZONE);
 	}

src/WebApp/Renderer.php

@@ -14,7 +14,7 @@ class Renderer {
 	public function __construct($theme, $component) {
 		$this->app        = $theme->app;
 		$this->theme      = $theme;
-		$this->parent     = $parent;
+		$this->parent     = NULL; //$parent;
 		$this->component  = $component;
 		$this->attributes = array();
 		$this->styles     = array();
@@ -63,9 +63,9 @@ public function setStyle($name, $value) {
 	}
 
 	protected function getAttribute($name, $combined = FALSE) {
-		$rc = $this->attributes[$name];
+		$rc = isset($this->attributes[$name]) ? $this->attributes[$name] : NULL;
 		if ($combined) {
-			if (isset($rc)) {
+			if ($rc != NULL) {
 				$rc = $this->_combineValues($this->component->getAttribute($name), $rc);
 			} else {
 				$rc = $this->component->getAttribute($name);

src/WebApp/Router.php

@@ -253,7 +253,7 @@ protected function searchPageInNamespace($pagePath, $namespace) {
 		if ($names[0] == '') array_shift($names);
 
 		// Replace special characters by whitespace and make it camel case and concatenate again
-		$className = $name;
+		$className = '';$name;
 		foreach ($names AS $idx => $path) {
 			if ($idx > 0) $className .= '\\';
 			$path       = str_replace(' ', '', ucwords(str_replace(array('_','-'), array(' ', ' '), $path)));

src/WebApp/Session/DatabaseSessionHandler.php

@@ -22,7 +22,7 @@ public function __construct($dao) {
 	 * @param string $name
 	 * @return bool
 	 */
-	public function open($save_path, $name) {
+	public function open($save_path, $name):bool {
 		return TRUE;
 	}
 
@@ -32,7 +32,7 @@ public function open($save_path, $name) {
 	 * @param string $session_id
 	 * @return string
 	 */
-	public function read($session_id) {
+	public function read($session_id):string|false {
 		$this->session = $this->dao->get($session_id);
 		if (!$this->session) $this->createFreshSession($session_id);
 		return $this->session->data;
@@ -66,19 +66,19 @@ protected function createFreshSession($session_id) {
 	 * @param string $data
 	 * @return bool
 	 */
-	public function write($session_id, $data) {
+	public function write($session_id, $data):bool {
 
 		// In case there is no object yet
 		if ($this->session == NULL) $this->createFreshSession($session_id);
 
 		// Update fields
 		$now        = new Date(time(), WFW_TIMEZONE);
-		$expiryTime = $_SESSION['persistent'] ? 365*24*3600 : ini_get('session.gc_maxlifetime');
+		$expiryTime = isset($_SESSION['persistent']) && $_SESSION['persistent'] ? 365*24*3600 : ini_get('session.gc_maxlifetime');
 		$expiry     = new Date(time()+$expiryTime, WFW_TIMEZONE);
 		$this->session->update_time   = $now->toMysql(TRUE);
 		$this->session->expiry_time   = $expiry->toMysql(TRUE);
 		$this->session->data          = $data;
-		$this->session->persistent    = $_SESSION['persistent'] ? 1 : 0;
+		$this->session->persistent    = isset($_SESSION['persistent']) && $_SESSION['persistent'] ? 1 : 0;
 
 		// Persist
 		$session = $this->dao->get($session_id);
@@ -101,7 +101,7 @@ public function write($session_id, $data) {
 	 *
 	 * @return bool
 	 */
-	public function close() {
+	public function close():bool {
 		if ($this->session) {
 			return $this->gc(ini_get('session.gc_maxlifetime'));
 		}
@@ -114,7 +114,7 @@ public function close() {
 	 * @param int $session_id
 	 * @return bool
 	 */
-	public function destroy($session_id) {
+	public function destroy($session_id):bool {
 		$this->createFreshSession($session_id);
 		$this->dao->delete($this->session);
 		return TRUE;
@@ -126,7 +126,7 @@ public function destroy($session_id) {
 	 * @param int $maxlifetime
 	 * @return bool
 	 */
-	public function gc($maxlifetime) {
+	public function gc($maxlifetime):int|false {
 		// As we had the expiry set explicitely, we dont need the max lifetime
 		$expired = $this->dao->expire($maxlifetime);
 		return TRUE;