From 27609f062c6581348c691353f50195964deaa3bf Mon Sep 17 00:00:00 2001 From: Mark Baumgartner <42626826+mabaumgartner@users.noreply.github.com> Date: Fri, 23 May 2025 11:49:11 -0500 Subject: [PATCH 1/4] update to new versions of github actions --- .github/workflows/pester.yml | 2 +- .github/workflows/publishtogallery.yml | 2 +- .github/workflows/reminders.yml | 23 +++++++++++++---------- .github/workflows/scriptanalyzer.yml | 2 +- 4 files changed, 16 insertions(+), 13 deletions(-) diff --git a/.github/workflows/pester.yml b/.github/workflows/pester.yml index 75fe547..3cf4dc1 100644 --- a/.github/workflows/pester.yml +++ b/.github/workflows/pester.yml @@ -16,7 +16,7 @@ jobs: os: [macos-latest, windows-latest] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Install dependencies run: Install-Module -Name 'Pester' -Force -SkipPublisherCheck shell: pwsh diff --git a/.github/workflows/publishtogallery.yml b/.github/workflows/publishtogallery.yml index b70c3a5..e4fb35b 100644 --- a/.github/workflows/publishtogallery.yml +++ b/.github/workflows/publishtogallery.yml @@ -8,7 +8,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Run publish script env: NuGetApiKey: ${{ secrets.NuGetApiKey }} diff --git a/.github/workflows/reminders.yml b/.github/workflows/reminders.yml index a6e8314..fb8cb8a 100644 --- a/.github/workflows/reminders.yml +++ b/.github/workflows/reminders.yml @@ -1,15 +1,18 @@ name: PRs reviews reminder + on: schedule: - # Every weekday every 2 hours during working hours, send notification - - cron: "0 14-23/2 * * 1-5" + # Every weekday at 8:30a CST / 14:30 UTC and 1:30p CST / 19:30 UTC + - cron: '30 14,19 * * 1-5' + jobs: pr-reviews-reminder: - runs-on: ubuntu-latest - steps: - - uses: DavideViolante/pr-reviews-reminder-action@v1.3.0 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - with: - webhook-url: ${{ secrets.TEAMS_WEBHOOK }} - provider: 'msteams' + runs-on: ubuntu-latest + steps: + - uses: DavideViolante/pr-reviews-reminder-action@v2.8.0 + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + with: + webhook-url: ${{ secrets.TEAMS_WEBHOOK }} + provider: 'msteams' + github-provider-map: ${{ vars.MAP_USERNAMES_TEAMS }} diff --git a/.github/workflows/scriptanalyzer.yml b/.github/workflows/scriptanalyzer.yml index add7685..297f970 100644 --- a/.github/workflows/scriptanalyzer.yml +++ b/.github/workflows/scriptanalyzer.yml @@ -16,7 +16,7 @@ jobs: os: [windows-latest] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Install dependencies run: Install-Module -Name 'PSScriptAnalyzer' -Force -SkipPublisherCheck shell: pwsh From 78eef56cc87be2ea7001c8c5957ffbabe909173b Mon Sep 17 00:00:00 2001 From: Mark Baumgartner <42626826+mabaumgartner@users.noreply.github.com> Date: Fri, 23 May 2025 11:51:37 -0500 Subject: [PATCH 2/4] fix: remove previous unicode quote fix --- CHANGELOG.md | 7 +++++++ src/UofISplunkCloud/UofISplunkCloud.psd1 | 2 +- .../functions/public/Send-SplunkHECEvent.ps1 | 6 ------ 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1a3628c..49fcdcd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Removed +## [1.1.5] - 2024-05-23 + +### Changed + +- Removed a previous v1.1.1 fix in Send-SplunkHECEvent.ps1 to address a case where Splunk was treating unicode quotation characters as U+0022. PowerShell escapes U+0022 with ConvertTo-Json. This change removes the escapes of the unicode quote characters since this now causes an error. Splunk must have resolved this bug and therefore the pervious fix was preventing some events from being accepted by the HEC endpoint. +- Update GitHub actions for `checkout` and `pr-reviews-reminder-action` workflows. + ## [1.1.4] - 2024-11-06 ### Changed diff --git a/src/UofISplunkCloud/UofISplunkCloud.psd1 b/src/UofISplunkCloud/UofISplunkCloud.psd1 index c10a553..1a75caf 100644 --- a/src/UofISplunkCloud/UofISplunkCloud.psd1 +++ b/src/UofISplunkCloud/UofISplunkCloud.psd1 @@ -10,7 +10,7 @@ RootModule = 'UofISplunkCloud.psm1' # Version number of this module. -ModuleVersion = '1.1.4' +ModuleVersion = '1.1.5' # Supported PSEditions # CompatiblePSEditions = @() diff --git a/src/UofISplunkCloud/functions/public/Send-SplunkHECEvent.ps1 b/src/UofISplunkCloud/functions/public/Send-SplunkHECEvent.ps1 index e9d8762..99d8cd8 100644 --- a/src/UofISplunkCloud/functions/public/Send-SplunkHECEvent.ps1 +++ b/src/UofISplunkCloud/functions/public/Send-SplunkHECEvent.ps1 @@ -82,12 +82,6 @@ function Send-SplunkHECEvent { 'event' = $EventArray[$i] } | ConvertTo-Json -Depth 5 -Compress - # ConvertTo-Json escapes unicode U+0022 quotes automatically - # https://www.ietf.org/rfc/rfc8259.txt - # Splunk HEC seems to interpret other unicode quotes as legitimate quotes - # Escape these quotes to prevent a HEC error of: text":"Invalid data format","code":6," - $Body = $Body -replace "`u{201c}", "\`u{201c}" -replace "`u{201d}", "\`u{201d}" -replace "`u{201f}", "\`u{201f}" - $BulkEvent += $Body $count++ From 466e88739b8514a875e850ec699b797cb8e1cedd Mon Sep 17 00:00:00 2001 From: Mark Baumgartner <42626826+mabaumgartner@users.noreply.github.com> Date: Tue, 27 May 2025 13:28:13 -0500 Subject: [PATCH 3/4] update end of service dates --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0837527..43f349b 100644 --- a/README.md +++ b/README.md @@ -24,11 +24,11 @@ Submit a PR on GitHub # End-of-Life and End-of-Support Dates -As of the last update to this README, the expected End-of-Life and End-of-Support dates of this product are November 2024. +As of the last update to this README, the expected End-of-Life and End-of-Support dates of this product are November 2026. End-of-Life was decided upon based on these dependencies and their End-of-Life dates: -- Powershell 7.2 (November 2024) +- Powershell 7.4 (November 2026) # To Do From f39e1aa5a34e525e4973d631a3de295ec33ccd76 Mon Sep 17 00:00:00 2001 From: Mark Baumgartner <42626826+mabaumgartner@users.noreply.github.com> Date: Tue, 27 May 2025 13:33:07 -0500 Subject: [PATCH 4/4] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 49fcdcd..680cdfc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Removed a previous v1.1.1 fix in Send-SplunkHECEvent.ps1 to address a case where Splunk was treating unicode quotation characters as U+0022. PowerShell escapes U+0022 with ConvertTo-Json. This change removes the escapes of the unicode quote characters since this now causes an error. Splunk must have resolved this bug and therefore the pervious fix was preventing some events from being accepted by the HEC endpoint. - Update GitHub actions for `checkout` and `pr-reviews-reminder-action` workflows. +- README.md - update the end of support to November 2026 to align with PowerShell 7.4 ## [1.1.4] - 2024-11-06