From abff50d1cfd5fbdfc66a9de4c615b494454bfa90 Mon Sep 17 00:00:00 2001 From: Kannan Rajah Date: Thu, 9 Apr 2026 18:51:55 -0700 Subject: [PATCH 1/2] Fix proto generation failing when new subdirectories are added MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `mv -f` command cannot merge directories — it fails when the destination directory already exists. Replace with `cp -rf` so that new proto subdirectories (e.g. nexusservices) are handled correctly. Co-Authored-By: Claude Opus 4.6 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 3c3a463c..71f71103 100644 --- a/Makefile +++ b/Makefile @@ -61,7 +61,7 @@ go-grpc: clean .go-helpers-installed $(PROTO_OUT) -p grpc-gateway_out=allow_patch_feature=false,$(PROTO_PATHS) \ -p go-helpers_out=$(PROTO_PATHS) - mv -f $(PROTO_OUT)/temporal/api/* $(PROTO_OUT) && rm -rf $(PROTO_OUT)/temporal + cp -rf $(PROTO_OUT)/temporal/api/* $(PROTO_OUT) && rm -rf $(PROTO_OUT)/temporal http-api-docs: go-grpc go run cmd/encode-openapi-spec/main.go \ From b2228a265101f357193669ae7f86d5700ed959b3 Mon Sep 17 00:00:00 2001 From: Kannan Rajah Date: Thu, 9 Apr 2026 19:34:01 -0700 Subject: [PATCH 2/2] Add comment explaining cp vs mv choice Co-Authored-By: Claude Opus 4.6 --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 71f71103..b05efe1a 100644 --- a/Makefile +++ b/Makefile @@ -61,6 +61,7 @@ go-grpc: clean .go-helpers-installed $(PROTO_OUT) -p grpc-gateway_out=allow_patch_feature=false,$(PROTO_PATHS) \ -p go-helpers_out=$(PROTO_PATHS) + # cp is safer than mv because mv cannot merge into existing directories cp -rf $(PROTO_OUT)/temporal/api/* $(PROTO_OUT) && rm -rf $(PROTO_OUT)/temporal http-api-docs: go-grpc