Add __getattr__ to _ReplaySafeSpan to delegate SDK-specific attributes (#1392)

Instrumentation libraries like opentelemetry-instrumentation-asgi access
attributes beyond the Span ABC (e.g. .name, .kind, .resource, .attributes)
directly on spans. _ReplaySafeSpan now forwards these via __getattr__ to
the wrapped span. Also removes dead self._status assignment in set_status.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: tconley1428

temporalio/contrib/opentelemetry/_tracer_provider.py

@@ -33,6 +33,9 @@ def __init__(self, span: Span):
         self._exception: BaseException | None = None
         self._span = span
 
+    def __getattr__(self, name: str) -> object:
+        return getattr(self._span, name)
+
     def end(self, end_time: int | None = None) -> None:
         if workflow.in_workflow() and workflow.unsafe.is_replaying_history_events():
             # Skip ending spans during workflow replay to avoid duplicate telemetry
@@ -75,7 +78,6 @@ def is_recording(self) -> bool:
     def set_status(
         self, status: Status | StatusCode, description: str | None = None
     ) -> None:
-        self._status = status
         self._span.set_status(status, description)
 
     def record_exception(

tests/contrib/opentelemetry/test_opentelemetry_plugin.py

@@ -576,3 +576,34 @@ async def test_otel_tracing_workflow_failure(
     assert (
         actual_hierarchy == expected_hierarchy
     ), f"Span hierarchy mismatch.\nExpected:\n{expected_hierarchy}\nActual:\n{actual_hierarchy}"
+
+
+def test_replay_safe_span_delegates_extra_attributes():
+    """Test that _ReplaySafeSpan delegates attribute access to the underlying span.
+
+    Concrete span implementations (e.g. opentelemetry.sdk.trace.Span) expose
+    attributes beyond the Span ABC such as .attributes, .name, .kind, and
+    .resource. _ReplaySafeSpan must forward these so that instrumentation
+    libraries that rely on them work correctly.
+    """
+    from opentelemetry.sdk.trace import TracerProvider as SdkTracerProvider
+
+    from temporalio.contrib.opentelemetry._tracer_provider import _ReplaySafeSpan
+
+    provider = SdkTracerProvider()
+    tracer = provider.get_tracer("test")
+    inner_span = tracer.start_span("test-span")
+
+    wrapper = _ReplaySafeSpan(inner_span)
+
+    # These properties exist on the SDK span but not on the Span ABC
+    assert wrapper.name == "test-span"
+    assert wrapper.kind is not None
+    assert wrapper.resource is not None
+    assert wrapper.attributes is not None or wrapper.attributes == {}
+
+    # Verify that AttributeError is still raised for truly missing attributes
+    with pytest.raises(AttributeError):
+        _ = wrapper.nonexistent_attribute_xyz
+
+    inner_span.end()