OpenAI - Fix generics is instance (#1261)

tconley1428 · VegetarianOrc · web-flow · commit f0bd341450ef · 2025-12-19T13:33:24.000-08:00
* bump version to 1.21.1

* Restrict tool type check to reject callable because of the inability to check against generic type.

---------

Co-authored-by: Alex Mazzeo &lt;alex.mazzeo@temporal.io&gt;
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [project]
 name = "temporalio"
-version = "1.21.0"
+version = "1.21.1"
 description = "Temporal.io Python SDK"
 authors = [{ name = "Temporal Technologies Inc", email = "sdk@temporal.io" }]
 requires-python = ">=3.10"
diff --git a/temporalio/contrib/openai_agents/_openai_runner.py b/temporalio/contrib/openai_agents/_openai_runner.py
@@ -98,9 +98,8 @@ async def run(
                 **kwargs,
             )
 
-        tool_types = typing.get_args(Tool)
         for t in starting_agent.tools:
-            if not isinstance(t, tool_types):
+            if callable(t):
                 raise ValueError(
                     "Provided tool is not a tool type. If using an activity, make sure to wrap it with openai_agents.workflow.activity_as_tool."
                 )
diff --git a/temporalio/service.py b/temporalio/service.py
@@ -23,7 +23,7 @@
 import temporalio.exceptions
 import temporalio.runtime
 
-__version__ = "1.21.0"
+__version__ = "1.21.1"
 
 ServiceRequest = TypeVar("ServiceRequest", bound=google.protobuf.message.Message)
 ServiceResponse = TypeVar("ServiceResponse", bound=google.protobuf.message.Message)
diff --git a/uv.lock b/uv.lock

Original file line number	Diff line number	Diff line change
`@@ -98,9 +98,8 @@ async def run(`
`98`	`98`	`**kwargs,`
`99`	`99`	`)`
`100`	`100`
`101`		`- tool_types = typing.get_args(Tool)`
`102`	`101`	`for t in starting_agent.tools:`
`103`		`- if not isinstance(t, tool_types):`
	`102`	`+ if callable(t):`
`104`	`103`	`raise ValueError(`
`105`	`104`	`"Provided tool is not a tool type. If using an activity, make sure to wrap it with openai_agents.workflow.activity_as_tool."`
`106`	`105`	`)`