Merge pull request #16 from lucasmichot/ccn-type-check

Ensure short number cannot be considered as valid credit card number

Author: greydnls

src/Omnipay/Common/CreditCard.php

@@ -248,6 +248,10 @@ public function validate()
         if (!Helper::validateLuhn($this->getNumber())) {
             throw new InvalidCreditCardException('Card number is invalid');
         }
+
+        if (!is_null($this->getNumber()) && !preg_match('/^\d{12,19}$/i', $this->getNumber())) {
+            throw new InvalidCreditCardException('Card number should have 12 to 19 digits');
+        }
     }
 
     /**

tests/Omnipay/Common/CreditCardTest.php

@@ -589,4 +589,13 @@ public function testGender()
         $this->card->setGender('female');
         $this->assertEquals('female', $this->card->getGender());
     }
+
+    /**
+     * @expectedException Omnipay\Common\Exception\InvalidCreditCardException
+     */
+    public function testInvalidShortCard()
+    {
+        $this->card->setNumber('43');
+        $this->card->validate();
+    }
 }