Not really an issue after some research, the subi's RPM is almost the same
here is the difference for anyone else that dips into the Nisan world on this project.
// ---------- RPM (CA18DET) ----------
static constexpr uint8_t PULSES_PER_REV = 2; // CA18DET = 2 pulses per crank rev
static constexpr uint32_t RPM_MIN_PULSE_US = 2000; // Nissan tach signals are sharper
static constexpr float RPM_MAX = 8000.0f; // Stock redline ~7600
static constexpr uint32_t RPM_STOP_TIMEOUT_MS = 300; // Faster decay looks OEM
static constexpr float DECEL_RPM_PER_SEC = 18000.0f;
Not really an issue after some research, the subi's RPM is almost the same
here is the difference for anyone else that dips into the Nisan world on this project.
// ---------- RPM (CA18DET) ----------
static constexpr uint8_t PULSES_PER_REV = 2; // CA18DET = 2 pulses per crank rev
static constexpr uint32_t RPM_MIN_PULSE_US = 2000; // Nissan tach signals are sharper
static constexpr float RPM_MAX = 8000.0f; // Stock redline ~7600
static constexpr uint32_t RPM_STOP_TIMEOUT_MS = 300; // Faster decay looks OEM
static constexpr float DECEL_RPM_PER_SEC = 18000.0f;