Fix TRACE_enable panic on missing file to match C fopen append behavior#313
Merged
folkertdev merged 1 commit intoMay 13, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
b438c75
into
trifectatechfoundation:main
20 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #312
Changes
.create(true)toOpenOptionsinprograms/zstdcli_trace.rs. This ensures that opening a trace log file with--traceautomatically creates the file if it does not exist, matching C'sfopen(..., "a")append behavior and resolving the runtime panic on fresh runs.Verification
Verified locally that running
zstdclion a fresh run successfully createstrace.log, writes the CSV header row, and captures compression metrics without panicking.PR was supported by AI.