sort snapshots by created at everywhere

Author: nicktrn

internal-packages/run-engine/src/engine/systems/dequeueSystem.ts

@@ -409,6 +409,7 @@ export class DequeueSystem {
                     friendlyId: newSnapshot.friendlyId,
                     executionStatus: newSnapshot.executionStatus,
                     description: newSnapshot.description,
+                    createdAt: newSnapshot.createdAt,
                   },
                   image: result.deployment?.imageReference ?? undefined,
                   checkpoint: newSnapshot.checkpoint ?? undefined,

internal-packages/run-engine/src/engine/systems/executionSnapshotSystem.ts

@@ -144,6 +144,7 @@ export function executionResultFromSnapshot(snapshot: TaskRunExecutionSnapshot):
       friendlyId: SnapshotId.toFriendlyId(snapshot.id),
       executionStatus: snapshot.executionStatus,
       description: snapshot.description,
+      createdAt: snapshot.createdAt,
     },
     run: {
       id: snapshot.runId,
@@ -162,6 +163,7 @@ export function executionDataFromSnapshot(snapshot: EnhancedExecutionSnapshot):
       friendlyId: snapshot.friendlyId,
       executionStatus: snapshot.executionStatus,
       description: snapshot.description,
+      createdAt: snapshot.createdAt,
     },
     run: {
       id: snapshot.runId,

internal-packages/run-engine/src/engine/systems/runAttemptSystem.ts

@@ -892,6 +892,7 @@ export class RunAttemptSystem {
           friendlyId: newSnapshot.friendlyId,
           executionStatus: newSnapshot.executionStatus,
           description: newSnapshot.description,
+          createdAt: newSnapshot.createdAt,
         },
         run: {
           id: newSnapshot.runId,

packages/cli-v3/src/entryPoints/managed/snapshot.test.ts

@@ -728,6 +728,7 @@ function createRunExecutionData(
       friendlyId: snapshotFriendlyId,
       executionStatus: overrides.executionStatus ?? "EXECUTING",
       description: overrides.description ?? "Test snapshot",
+      createdAt: new Date(),
     },
     completedWaitpoints: [],
   };

packages/cli-v3/src/entryPoints/managed/snapshot.ts

@@ -199,7 +199,7 @@ export class SnapshotManager {
 
       // Sort queue:
       // 1. Suspendable changes always go to the back
-      // 2. Snapshot changes are ordered by ID
+      // 2. Snapshot changes are ordered by creation time, with the latest snapshot last
       this.changeQueue.sort((a, b) => {
         if (a.change.type === "suspendable" && b.change.type === "snapshot") {
           return 1; // a goes after b
@@ -208,17 +208,15 @@ export class SnapshotManager {
           return -1; // a goes before b
         }
         if (a.change.type === "snapshot" && b.change.type === "snapshot") {
-          // sort snapshot changes by creation time of the latest snapshot, CUIDs are sortable
-          const aLatestSnapshot = a.change.snapshots[a.change.snapshots.length - 1];
-          const bLatestSnapshot = b.change.snapshots[b.change.snapshots.length - 1];
+          const snapshotA = a.change.snapshots[a.change.snapshots.length - 1];
+          const snapshotB = b.change.snapshots[b.change.snapshots.length - 1];
 
-          if (!aLatestSnapshot || !bLatestSnapshot) {
+          if (!snapshotA || !snapshotB) {
             return 0;
           }
 
-          return aLatestSnapshot.snapshot.friendlyId.localeCompare(
-            bLatestSnapshot.snapshot.friendlyId
-          );
+          // Sort snapshot changes by creation time, old -> new
+          return snapshotA.snapshot.createdAt.getTime() - snapshotB.snapshot.createdAt.getTime();
         }
         return 0; // both suspendable, maintain insertion order
       });

packages/core/src/v3/schemas/runEngine.ts

@@ -109,6 +109,7 @@ const ExecutionSnapshot = z.object({
   friendlyId: z.string(),
   executionStatus: z.enum(Object.values(TaskRunExecutionStatus) as [TaskRunExecutionStatus]),
   description: z.string(),
+  createdAt: z.coerce.date(),
 });
 
 const BaseRunMetadata = z.object({