Respect ChatOptions.Instructions in HuggingFaceClient.GetResponseAsync

stephentoub · stephentoub · commit 6d6447f30c6b · 2025-09-23T12:55:46.000-04:00
diff --git a/src/libs/HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs b/src/libs/HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs
@@ -34,6 +34,13 @@ async Task<ChatResponse> IChatClient.GetResponseAsync(IEnumerable<ChatMessage> m
             }
             prompt.AppendLine();
         }
+
+        if (options?.Instructions is { } instructions)
+        {
+            AppendRole(ChatRole.System);
+            prompt.Append(instructions).AppendLine();
+        }
+
         AppendRole(ChatRole.Assistant);
 
         void AppendRole(ChatRole role) => prompt.Append("<|").Append(role.Value).Append("|>");

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,13 @@ async Task<ChatResponse> IChatClient.GetResponseAsync(IEnumerable<ChatMessage> m`
`34`	`34`	`}`
`35`	`35`	`prompt.AppendLine();`
`36`	`36`	`}`
	`37`	`+`
	`38`	`+ if (options?.Instructions is { } instructions)`
	`39`	`+ {`
	`40`	`+ AppendRole(ChatRole.System);`
	`41`	`+ prompt.Append(instructions).AppendLine();`
	`42`	`+ }`
	`43`	`+`
`37`	`44`	`AppendRole(ChatRole.Assistant);`
`38`	`45`
`39`	`46`	`void AppendRole(ChatRole role) => prompt.Append("<\|").Append(role.Value).Append("\|>");`