Merge pull request #61 from ushiboy/release/1.1.2

[WIP] Release 1.1.2

Author: ushiboy

README.md

@@ -459,6 +459,10 @@ nmcli.set_lang(lang: str) -> None
 
 ## Change Log
 
+### 1.1.2
+
+- Fixed a problem with environment variables being scraped.
+
 ### 1.1.1
 
 - Include LICENSE.txt in the tar.

nmcli/_system.py

@@ -1,3 +1,4 @@
+import os
 from subprocess import CalledProcessError, run
 from typing import List, Union
 
@@ -38,8 +39,9 @@ def nmcli(self, parameters: CommandParameter) -> str:
         c = ['sudo', 'nmcli'] if self._use_sudo else ['nmcli']
         commands = c + parameters
         try:
+            env = dict(os.environ, **{'LANG': self._lang})
             r = self._run(commands, capture_output=True,
-                          check=True, env={'LANG': self._lang})
+                          check=True, env=env)
             return r.stdout.decode('utf-8')
         except CalledProcessError as e:
             rc = e.returncode

setup.py

@@ -13,7 +13,7 @@ def run_tests(self):
 
 setup(
     name='nmcli',
-    version='1.1.1',
+    version='1.1.2',
     author='ushiboy',
     license='MIT',
     license_files = ('LICENSE.txt',),

tests/test_system.py

@@ -1,4 +1,5 @@
 # pylint: disable=line-too-long
+import os
 from subprocess import CalledProcessError, CompletedProcess
 
 import pytest
@@ -44,15 +45,15 @@ def test_nmcli_when_successed():
     s = SystemCommand(run)
     assert s.nmcli('connection') == 'test'
     assert run.passed_args == ['sudo', 'nmcli', 'connection']
-    assert run.passed_env == {'LANG': 'C'}
+    assert run.passed_env == dict(os.environ, **{'LANG': 'C'})
 
 
 def test_nmcli_when_successed_with_list_args():
     run = DummySubprocessRunner(stdout=b'test')
     s = SystemCommand(run)
     assert s.nmcli(['device', 'wifi']) == 'test'
     assert run.passed_args == ['sudo', 'nmcli', 'device', 'wifi']
-    assert run.passed_env == {'LANG': 'C'}
+    assert run.passed_env == dict(os.environ, **{'LANG': 'C'})
 
 
 def test_nmcli_when_failed_with_invalid_user_input():
@@ -152,4 +153,4 @@ def test_set_lang():
     s.set_lang('C.UTF-8')
     assert s.nmcli('connection') == 'test'
     assert run.passed_args == ['sudo', 'nmcli', 'connection']
-    assert run.passed_env == {'LANG': 'C.UTF-8'}
+    assert run.passed_env == dict(os.environ, **{'LANG': 'C.UTF-8'})